diff mbox series

dt-bindings: pwm: imx: document i.MX compatibles

Message ID 20200925212609.23093-1-krzk@kernel.org
State Changes Requested
Headers show
Series dt-bindings: pwm: imx: document i.MX compatibles | expand

Checks

Context Check Description
robh/checkpatch warning total: 0 errors, 1 warnings, 17 lines checked

Commit Message

Krzysztof Kozlowski Sept. 25, 2020, 9:26 p.m. UTC
Document all ARMv5, ARMv6 and ARMv7 i.MX compatibles to fix dtbs_check
warnings like:

  arch/arm/boot/dts/imx6dl-colibri-eval-v3.dt.yaml: pwm@2080000: compatible:0:
    'fsl,imx6q-pwm' is not one of ['fsl,imx8mm-pwm', 'fsl,imx8mn-pwm', 'fsl,imx8mp-pwm', 'fsl,imx8mq-pwm']

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 Documentation/devicetree/bindings/pwm/imx-pwm.yaml | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Uwe Kleine-König Sept. 26, 2020, 1:22 p.m. UTC | #1
On Fri, Sep 25, 2020 at 11:26:09PM +0200, Krzysztof Kozlowski wrote:
> Document all ARMv5, ARMv6 and ARMv7 i.MX compatibles to fix dtbs_check
> warnings like:
> 
>   arch/arm/boot/dts/imx6dl-colibri-eval-v3.dt.yaml: pwm@2080000: compatible:0:
>     'fsl,imx6q-pwm' is not one of ['fsl,imx8mm-pwm', 'fsl,imx8mn-pwm', 'fsl,imx8mp-pwm', 'fsl,imx8mq-pwm']
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  Documentation/devicetree/bindings/pwm/imx-pwm.yaml | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> index 473863eb67e5..379d693889f6 100644
> --- a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> +++ b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> @@ -25,6 +25,17 @@ properties:
>            - fsl,imx27-pwm
>        - items:
>            - enum:
> +              - fsl,imx25-pwm

The driver actually used fsl,imx27-pwm to bind ...

Also since v5.1-rc1~38^2~17 the driver is split into pwm-imx27 and
pwm-imx1. So maybe this file should be renamed to fsl,imx27-pwm.yaml?
(And we need a volunteer to write fsl,imx1-pwm.yaml.)

> +              - fsl,imx31-pwm
> +              - fsl,imx50-pwm
> +              - fsl,imx51-pwm
> +              - fsl,imx53-pwm
> +              - fsl,imx6q-pwm
> +              - fsl,imx6sl-pwm
> +              - fsl,imx6sll-pwm
> +              - fsl,imx6sx-pwm
> +              - fsl,imx6ul-pwm
> +              - fsl,imx7d-pwm
>                - fsl,imx8mm-pwm
>                - fsl,imx8mn-pwm
>                - fsl,imx8mp-pwm

Best regards
Uwe
Krzysztof Kozlowski Sept. 26, 2020, 1:41 p.m. UTC | #2
On Sat, Sep 26, 2020 at 03:22:17PM +0200, Uwe Kleine-König wrote:
> On Fri, Sep 25, 2020 at 11:26:09PM +0200, Krzysztof Kozlowski wrote:
> > Document all ARMv5, ARMv6 and ARMv7 i.MX compatibles to fix dtbs_check
> > warnings like:
> > 
> >   arch/arm/boot/dts/imx6dl-colibri-eval-v3.dt.yaml: pwm@2080000: compatible:0:
> >     'fsl,imx6q-pwm' is not one of ['fsl,imx8mm-pwm', 'fsl,imx8mn-pwm', 'fsl,imx8mp-pwm', 'fsl,imx8mq-pwm']
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> >  Documentation/devicetree/bindings/pwm/imx-pwm.yaml | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> > index 473863eb67e5..379d693889f6 100644
> > --- a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> > +++ b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> > @@ -25,6 +25,17 @@ properties:
> >            - fsl,imx27-pwm
> >        - items:
> >            - enum:
> > +              - fsl,imx25-pwm
> 
> The driver actually used fsl,imx27-pwm to bind ...

Yes, most of i.MX drivers use only few compatibles but DTSes and
bindings use multiple of them.  I was convinced during various talks
that the specific compatibles (so "fsl,imx6q-pwm, fsl,imx27-pwm") are
preferred than generic ones (so only "fsl,imx27-pwm"). NXP took it
to the another level creating compatibles for absolutely every flavor of
their CPU. And they mainlined it in DTSes...

The PWM is this crazy examples where, as you say, only two compatibles
are actually used for binding but DTSes uses more.

> 
> Also since v5.1-rc1~38^2~17 the driver is split into pwm-imx27 and
> pwm-imx1. So maybe this file should be renamed to fsl,imx27-pwm.yaml?
> (And we need a volunteer to write fsl,imx1-pwm.yaml.)

I think there is no need, because the binding describes the hardware and
could be supported by multiple drivers. I actually recently merged few
bindings (i.MX 8 clocks, NXP PCA953x/max GPIO expanders).

Best regards,
Krzysztof
Thierry Reding Oct. 9, 2020, 12:02 p.m. UTC | #3
On Sat, Sep 26, 2020 at 03:41:57PM +0200, Krzysztof Kozlowski wrote:
> On Sat, Sep 26, 2020 at 03:22:17PM +0200, Uwe Kleine-König wrote:
> > On Fri, Sep 25, 2020 at 11:26:09PM +0200, Krzysztof Kozlowski wrote:
> > > Document all ARMv5, ARMv6 and ARMv7 i.MX compatibles to fix dtbs_check
> > > warnings like:
> > > 
> > >   arch/arm/boot/dts/imx6dl-colibri-eval-v3.dt.yaml: pwm@2080000: compatible:0:
> > >     'fsl,imx6q-pwm' is not one of ['fsl,imx8mm-pwm', 'fsl,imx8mn-pwm', 'fsl,imx8mp-pwm', 'fsl,imx8mq-pwm']
> > > 
> > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > > ---
> > >  Documentation/devicetree/bindings/pwm/imx-pwm.yaml | 11 +++++++++++
> > >  1 file changed, 11 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> > > index 473863eb67e5..379d693889f6 100644
> > > --- a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> > > +++ b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> > > @@ -25,6 +25,17 @@ properties:
> > >            - fsl,imx27-pwm
> > >        - items:
> > >            - enum:
> > > +              - fsl,imx25-pwm
> > 
> > The driver actually used fsl,imx27-pwm to bind ...
> 
> Yes, most of i.MX drivers use only few compatibles but DTSes and
> bindings use multiple of them.  I was convinced during various talks
> that the specific compatibles (so "fsl,imx6q-pwm, fsl,imx27-pwm") are
> preferred than generic ones (so only "fsl,imx27-pwm"). NXP took it
> to the another level creating compatibles for absolutely every flavor of
> their CPU. And they mainlined it in DTSes...
> 
> The PWM is this crazy examples where, as you say, only two compatibles
> are actually used for binding but DTSes uses more.

Yeah, these new compatible strings all seem to be used in the kernel, so
we might as well document them.

That said, I did want to apply this patch, but that fails. Am I missing
some other patch that you have sent out that touches this file? Actually
it looks like this is because you've based this patch on linux-next, or
perhaps the devicetree tree, because that contains commit d058717bdff4
("dt-bindings: pwm: imx-pwm: Add i.MX 8M compatibles") from you that
adds a couple more compatible strings. Probably best for Rob to pick
this up, then:

Acked-by: Thierry Reding <treding@nvidia.com>

Rob, here's a patchwork link for you if you need one:

	https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20200925212609.23093-1-krzk@kernel.org/

Although, looking at the devicetree-bindings instance version of that
patch, I see that it's got a failing check attached (which looks like
it can be ignored) and it's marked "Changes Requested", but no comments
saying so.

Not sure if you want anything done here?

Thierry
Krzysztof Kozlowski Oct. 12, 2020, 5:16 p.m. UTC | #4
On Fri, 9 Oct 2020 at 14:02, Thierry Reding <thierry.reding@gmail.com> wrote:
>
> On Sat, Sep 26, 2020 at 03:41:57PM +0200, Krzysztof Kozlowski wrote:
> > On Sat, Sep 26, 2020 at 03:22:17PM +0200, Uwe Kleine-König wrote:
> > > On Fri, Sep 25, 2020 at 11:26:09PM +0200, Krzysztof Kozlowski wrote:
> > > > Document all ARMv5, ARMv6 and ARMv7 i.MX compatibles to fix dtbs_check
> > > > warnings like:
> > > >
> > > >   arch/arm/boot/dts/imx6dl-colibri-eval-v3.dt.yaml: pwm@2080000: compatible:0:
> > > >     'fsl,imx6q-pwm' is not one of ['fsl,imx8mm-pwm', 'fsl,imx8mn-pwm', 'fsl,imx8mp-pwm', 'fsl,imx8mq-pwm']
> > > >
> > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > > > ---
> > > >  Documentation/devicetree/bindings/pwm/imx-pwm.yaml | 11 +++++++++++
> > > >  1 file changed, 11 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> > > > index 473863eb67e5..379d693889f6 100644
> > > > --- a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> > > > +++ b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> > > > @@ -25,6 +25,17 @@ properties:
> > > >            - fsl,imx27-pwm
> > > >        - items:
> > > >            - enum:
> > > > +              - fsl,imx25-pwm
> > >
> > > The driver actually used fsl,imx27-pwm to bind ...
> >
> > Yes, most of i.MX drivers use only few compatibles but DTSes and
> > bindings use multiple of them.  I was convinced during various talks
> > that the specific compatibles (so "fsl,imx6q-pwm, fsl,imx27-pwm") are
> > preferred than generic ones (so only "fsl,imx27-pwm"). NXP took it
> > to the another level creating compatibles for absolutely every flavor of
> > their CPU. And they mainlined it in DTSes...
> >
> > The PWM is this crazy examples where, as you say, only two compatibles
> > are actually used for binding but DTSes uses more.
>
> Yeah, these new compatible strings all seem to be used in the kernel, so
> we might as well document them.
>
> That said, I did want to apply this patch, but that fails. Am I missing
> some other patch that you have sent out that touches this file? Actually
> it looks like this is because you've based this patch on linux-next, or
> perhaps the devicetree tree, because that contains commit d058717bdff4
> ("dt-bindings: pwm: imx-pwm: Add i.MX 8M compatibles") from you that
> adds a couple more compatible strings. Probably best for Rob to pick
> this up, then:
>
> Acked-by: Thierry Reding <treding@nvidia.com>
>
> Rob, here's a patchwork link for you if you need one:
>
>         https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20200925212609.23093-1-krzk@kernel.org/
>
> Although, looking at the devicetree-bindings instance version of that
> patch, I see that it's got a failing check attached (which looks like
> it can be ignored) and it's marked "Changes Requested", but no comments
> saying so.
>
> Not sure if you want anything done here?

Thanks, I guess this will wait for the merge window to finish. It
should then apply to your tree. I can resend in two weeks.

Best regards,
Krzysztof
Rob Herring Oct. 12, 2020, 6:14 p.m. UTC | #5
On Fri, Oct 09, 2020 at 02:02:39PM +0200, Thierry Reding wrote:
> On Sat, Sep 26, 2020 at 03:41:57PM +0200, Krzysztof Kozlowski wrote:
> > On Sat, Sep 26, 2020 at 03:22:17PM +0200, Uwe Kleine-König wrote:
> > > On Fri, Sep 25, 2020 at 11:26:09PM +0200, Krzysztof Kozlowski wrote:
> > > > Document all ARMv5, ARMv6 and ARMv7 i.MX compatibles to fix dtbs_check
> > > > warnings like:
> > > > 
> > > >   arch/arm/boot/dts/imx6dl-colibri-eval-v3.dt.yaml: pwm@2080000: compatible:0:
> > > >     'fsl,imx6q-pwm' is not one of ['fsl,imx8mm-pwm', 'fsl,imx8mn-pwm', 'fsl,imx8mp-pwm', 'fsl,imx8mq-pwm']
> > > > 
> > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > > > ---
> > > >  Documentation/devicetree/bindings/pwm/imx-pwm.yaml | 11 +++++++++++
> > > >  1 file changed, 11 insertions(+)
> > > > 
> > > > diff --git a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> > > > index 473863eb67e5..379d693889f6 100644
> > > > --- a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> > > > +++ b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> > > > @@ -25,6 +25,17 @@ properties:
> > > >            - fsl,imx27-pwm
> > > >        - items:
> > > >            - enum:
> > > > +              - fsl,imx25-pwm
> > > 
> > > The driver actually used fsl,imx27-pwm to bind ...
> > 
> > Yes, most of i.MX drivers use only few compatibles but DTSes and
> > bindings use multiple of them.  I was convinced during various talks
> > that the specific compatibles (so "fsl,imx6q-pwm, fsl,imx27-pwm") are
> > preferred than generic ones (so only "fsl,imx27-pwm"). NXP took it
> > to the another level creating compatibles for absolutely every flavor of
> > their CPU. And they mainlined it in DTSes...
> > 
> > The PWM is this crazy examples where, as you say, only two compatibles
> > are actually used for binding but DTSes uses more.
> 
> Yeah, these new compatible strings all seem to be used in the kernel, so
> we might as well document them.
> 
> That said, I did want to apply this patch, but that fails. Am I missing
> some other patch that you have sent out that touches this file? Actually
> it looks like this is because you've based this patch on linux-next, or
> perhaps the devicetree tree, because that contains commit d058717bdff4
> ("dt-bindings: pwm: imx-pwm: Add i.MX 8M compatibles") from you that
> adds a couple more compatible strings. Probably best for Rob to pick
> this up, then:
> 
> Acked-by: Thierry Reding <treding@nvidia.com>
> 
> Rob, here's a patchwork link for you if you need one:
> 
> 	https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20200925212609.23093-1-krzk@kernel.org/
> 
> Although, looking at the devicetree-bindings instance version of that
> patch, I see that it's got a failing check attached (which looks like
> it can be ignored) and it's marked "Changes Requested", but no comments
> saying so.

I was assuming a rename at least.

> Not sure if you want anything done here?

I guess not, so I've applied it.

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
index 473863eb67e5..379d693889f6 100644
--- a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
+++ b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
@@ -25,6 +25,17 @@  properties:
           - fsl,imx27-pwm
       - items:
           - enum:
+              - fsl,imx25-pwm
+              - fsl,imx31-pwm
+              - fsl,imx50-pwm
+              - fsl,imx51-pwm
+              - fsl,imx53-pwm
+              - fsl,imx6q-pwm
+              - fsl,imx6sl-pwm
+              - fsl,imx6sll-pwm
+              - fsl,imx6sx-pwm
+              - fsl,imx6ul-pwm
+              - fsl,imx7d-pwm
               - fsl,imx8mm-pwm
               - fsl,imx8mn-pwm
               - fsl,imx8mp-pwm