Message ID | 20200923120817.1667149-2-mholenko@antmicro.com |
---|---|
State | Not Applicable, archived |
Headers | show |
Series | LiteX SoC controller and LiteUART serial driver | expand |
Context | Check | Description |
---|---|---|
robh/checkpatch | success | |
robh/dt-meta-schema | success |
Hi Mateusz, On Wed, Sep 23, 2020 at 12:09 PM Mateusz Holenko <mholenko@antmicro.com> wrote: > From: Pawel Czarnecki <pczarnecki@internships.antmicro.com> > > Add documentation for LiteX SoC Controller bindings. > > Signed-off-by: Pawel Czarnecki <pczarnecki@internships.antmicro.com> > Signed-off-by: Mateusz Holenko <mholenko@antmicro.com> > Reviewed-by: Rob Herring <robh@kernel.org> Thanks for your patch! > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml > @@ -0,0 +1,39 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +# Copyright 2020 Antmicro <www.antmicro.com> > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/soc/litex/litex,soc-controller.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: LiteX SoC Controller driver > + > +description: | > + This is the SoC Controller driver for the LiteX SoC Builder. > + It's purpose is to verify LiteX CSR (Control&Status Register) access Its > + operations and provide function for other drivers to read/write CSRs functions > + and to check if those accessors are ready to use. be used > + > +maintainers: > + - Karol Gugala <kgugala@antmicro.com> > + - Mateusz Holenko <mholenko@antmicro.com> > + > +properties: > + compatible: > + const: litex,soc-controller > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +examples: > + - | > + soc_ctrl0: soc-controller@f0000000 { > + compatible = "litex,soc-controller"; > + reg = <0xf0000000 0xC>; Please be consistent w.r.t. lower/upper case: "0xc". > + status = "okay"; > + }; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, On Fri, Sep 25, 2020 at 2:48 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Mateusz, > > On Wed, Sep 23, 2020 at 12:09 PM Mateusz Holenko <mholenko@antmicro.com> wrote: > > From: Pawel Czarnecki <pczarnecki@internships.antmicro.com> > > > > Add documentation for LiteX SoC Controller bindings. > > > > Signed-off-by: Pawel Czarnecki <pczarnecki@internships.antmicro.com> > > Signed-off-by: Mateusz Holenko <mholenko@antmicro.com> > > Reviewed-by: Rob Herring <robh@kernel.org> > > Thanks for your patch! Thanks for your comments! > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml > > @@ -0,0 +1,39 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +# Copyright 2020 Antmicro <www.antmicro.com> > > +%YAML 1.2 > > +--- > > +$id: "http://devicetree.org/schemas/soc/litex/litex,soc-controller.yaml#" > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > + > > +title: LiteX SoC Controller driver > > + > > +description: | > > + This is the SoC Controller driver for the LiteX SoC Builder. > > + It's purpose is to verify LiteX CSR (Control&Status Register) access > > Its > > > + operations and provide function for other drivers to read/write CSRs > > functions > > > + and to check if those accessors are ready to use. > > be used I will fix the description as suggested. > > + > > +maintainers: > > + - Karol Gugala <kgugala@antmicro.com> > > + - Mateusz Holenko <mholenko@antmicro.com> > > + > > +properties: > > + compatible: > > + const: litex,soc-controller > > + > > + reg: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + > > +examples: > > + - | > > + soc_ctrl0: soc-controller@f0000000 { > > + compatible = "litex,soc-controller"; > > + reg = <0xf0000000 0xC>; > > Please be consistent w.r.t. lower/upper case: "0xc". Sure, I will use lowercase everywhere. > > + status = "okay"; > > + }; > > Gr{oetje,eeting}s, > > Geert > > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds Best regards, Mateusz -- Mateusz Holenko Antmicro Ltd | www.antmicro.com Roosevelta 22, 60-829 Poznan, Poland
diff --git a/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml b/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml new file mode 100644 index 000000000000..53121c1fbe4d --- /dev/null +++ b/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml @@ -0,0 +1,39 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +# Copyright 2020 Antmicro <www.antmicro.com> +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/soc/litex/litex,soc-controller.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: LiteX SoC Controller driver + +description: | + This is the SoC Controller driver for the LiteX SoC Builder. + It's purpose is to verify LiteX CSR (Control&Status Register) access + operations and provide function for other drivers to read/write CSRs + and to check if those accessors are ready to use. + +maintainers: + - Karol Gugala <kgugala@antmicro.com> + - Mateusz Holenko <mholenko@antmicro.com> + +properties: + compatible: + const: litex,soc-controller + + reg: + maxItems: 1 + +required: + - compatible + - reg + +examples: + - | + soc_ctrl0: soc-controller@f0000000 { + compatible = "litex,soc-controller"; + reg = <0xf0000000 0xC>; + status = "okay"; + }; + +... diff --git a/MAINTAINERS b/MAINTAINERS index 7b58ca29cc80..39be98db7418 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9835,6 +9835,12 @@ L: kunit-dev@googlegroups.com S: Maintained F: lib/list-test.c +LITEX PLATFORM +M: Karol Gugala <kgugala@antmicro.com> +M: Mateusz Holenko <mholenko@antmicro.com> +S: Maintained +F: Documentation/devicetree/bindings/*/litex,*.yaml + LIVE PATCHING M: Josh Poimboeuf <jpoimboe@redhat.com> M: Jiri Kosina <jikos@kernel.org>