Message ID | 20200919172733.57217-1-freifunk@adrianschmutzler.de |
---|---|
State | Changes Requested, archived |
Headers | show |
Series | [v2,1/2] dt-bindings: leds: add LED_FUNCTION for wlan2g/wlan5g | expand |
Context | Check | Description |
---|---|---|
robh/checkpatch | success |
> -----Original Message----- > From: Adrian Schmutzler [mailto:freifunk@adrianschmutzler.de] > Sent: Samstag, 19. September 2020 19:28 > To: Rob Herring <robh+dt@kernel.org>; Pavel Machek <pavel@ucw.cz>; Dan > Murphy <dmurphy@ti.com>; Linus Walleij <linus.walleij@linaro.org>; > devicetree@vger.kernel.org; Adrian Schmutzler > <freifunk@adrianschmutzler.de> > Subject: [PATCH v2 1/2] dt-bindings: leds: add LED_FUNCTION for > wlan2g/wlan5g > > Many consumer "routers" have dedicated LEDs for specific WiFi bands, e.g. > one for 2.4 GHz and one for 5 GHz. These LEDs specifically indicate the state > of the relevant band, so the latter should be included in the function name. > LED_FUNCTION_WLAN will remain for general cases or when the LED is used > for more than one band. > > This essentially is equivalent to how we use LED_FUNCTION_LAN and > LED_FUNCTION_WAN instead of just having LED_FUNCTION_ETHERNET. I only just became aware of the linux-leds@vger.kernel.org mailing list, and resubmitted there. Sorry for the noise. Maybe get_maintainers.sh should be updated for this file. Best Adrian > > Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de> > > --- > > Changes in v2: > - Without typo this time. Sorry. > --- > include/dt-bindings/leds/common.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/dt-bindings/leds/common.h b/include/dt- > bindings/leds/common.h > index 52b619d44ba2..debbd406ff17 100644 > --- a/include/dt-bindings/leds/common.h > +++ b/include/dt-bindings/leds/common.h > @@ -89,6 +89,8 @@ > #define LED_FUNCTION_USB "usb" > #define LED_FUNCTION_WAN "wan" > #define LED_FUNCTION_WLAN "wlan" > +#define LED_FUNCTION_WLAN2G "wlan2g" > +#define LED_FUNCTION_WLAN5G "wlan5g" > #define LED_FUNCTION_WPS "wps" > > #endif /* __DT_BINDINGS_LEDS_H */ > -- > 2.20.1
On Sat, Sep 19, 2020 at 11:45:18PM +0200, Adrian Schmutzler wrote: > > -----Original Message----- > > From: Adrian Schmutzler [mailto:freifunk@adrianschmutzler.de] > > Sent: Samstag, 19. September 2020 19:28 > > To: Rob Herring <robh+dt@kernel.org>; Pavel Machek <pavel@ucw.cz>; Dan > > Murphy <dmurphy@ti.com>; Linus Walleij <linus.walleij@linaro.org>; > > devicetree@vger.kernel.org; Adrian Schmutzler > > <freifunk@adrianschmutzler.de> > > Subject: [PATCH v2 1/2] dt-bindings: leds: add LED_FUNCTION for > > wlan2g/wlan5g > > > > Many consumer "routers" have dedicated LEDs for specific WiFi bands, e.g. > > one for 2.4 GHz and one for 5 GHz. These LEDs specifically indicate the state > > of the relevant band, so the latter should be included in the function name. > > LED_FUNCTION_WLAN will remain for general cases or when the LED is used > > for more than one band. > > > > This essentially is equivalent to how we use LED_FUNCTION_LAN and > > LED_FUNCTION_WAN instead of just having LED_FUNCTION_ETHERNET. > > I only just became aware of the linux-leds@vger.kernel.org mailing list, and resubmitted there. It should both there and the DT list. > Sorry for the noise. Maybe get_maintainers.sh should be updated for this file. Patches welcome. Rob
diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h index 52b619d44ba2..debbd406ff17 100644 --- a/include/dt-bindings/leds/common.h +++ b/include/dt-bindings/leds/common.h @@ -89,6 +89,8 @@ #define LED_FUNCTION_USB "usb" #define LED_FUNCTION_WAN "wan" #define LED_FUNCTION_WLAN "wlan" +#define LED_FUNCTION_WLAN2G "wlan2g" +#define LED_FUNCTION_WLAN5G "wlan5g" #define LED_FUNCTION_WPS "wps" #endif /* __DT_BINDINGS_LEDS_H */
Many consumer "routers" have dedicated LEDs for specific WiFi bands, e.g. one for 2.4 GHz and one for 5 GHz. These LEDs specifically indicate the state of the relevant band, so the latter should be included in the function name. LED_FUNCTION_WLAN will remain for general cases or when the LED is used for more than one band. This essentially is equivalent to how we use LED_FUNCTION_LAN and LED_FUNCTION_WAN instead of just having LED_FUNCTION_ETHERNET. Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de> --- Changes in v2: - Without typo this time. Sorry. --- include/dt-bindings/leds/common.h | 2 ++ 1 file changed, 2 insertions(+)