diff mbox series

dt-bindings: soc: ti: ti,pruss: fix schema ID

Message ID 20200917070543.19064-1-krzk@kernel.org
State Not Applicable
Headers show
Series dt-bindings: soc: ti: ti,pruss: fix schema ID | expand

Checks

Context Check Description
robh/checkpatch warning total: 0 errors, 1 warnings, 10 lines checked

Commit Message

Krzysztof Kozlowski Sept. 17, 2020, 7:05 a.m. UTC
Add missing '#' to fix schema errors:

  $id: 'http://devicetree.org/schemas/soc/ti/ti,pruss.yaml' does not match 'http://devicetree.org/schemas/.*\\.yaml#'
  $schema: 'http://devicetree.org/meta-schemas/core.yaml' is not one of ['http://devicetree.org/meta-schemas/core.yaml#', 'http://devicetree.org/meta-schemas/base.yaml#']
  Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml: ignoring, error in schema: $id

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Grzegorz Jaszczyk Sept. 17, 2020, 8:32 a.m. UTC | #1
On Thu, 17 Sep 2020 at 09:05, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> Add missing '#' to fix schema errors:
>
>   $id: 'http://devicetree.org/schemas/soc/ti/ti,pruss.yaml' does not match 'http://devicetree.org/schemas/.*\\.yaml#'
>   $schema: 'http://devicetree.org/meta-schemas/core.yaml' is not one of ['http://devicetree.org/meta-schemas/core.yaml#', 'http://devicetree.org/meta-schemas/base.yaml#']
>   Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml: ignoring, error in schema: $id
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> index cf7dc83f724f..037c51b2f972 100644
> --- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> +++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> @@ -1,8 +1,8 @@
>  # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>  %YAML 1.2
>  ---
> -$id: http://devicetree.org/schemas/soc/ti/ti,pruss.yaml
> -$schema: http://devicetree.org/meta-schemas/core.yaml
> +$id: http://devicetree.org/schemas/soc/ti/ti,pruss.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#

I've double checked and "#" was present in the original patch sent and
ack for upstream: https://patchwork.kernel.org/patch/11729649/
It seems like something got wrong on linux-next but this is the only
diff between original patch and one found in linux-next. Thank you for
taking care of it.

Best regards,
Grzegorz
Krzysztof Kozlowski Sept. 17, 2020, 8:35 a.m. UTC | #2
On Thu, 17 Sep 2020 at 10:32, Grzegorz Jaszczyk
<grzegorz.jaszczyk@linaro.org> wrote:
>
> On Thu, 17 Sep 2020 at 09:05, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > Add missing '#' to fix schema errors:
> >
> >   $id: 'http://devicetree.org/schemas/soc/ti/ti,pruss.yaml' does not match 'http://devicetree.org/schemas/.*\\.yaml#'
> >   $schema: 'http://devicetree.org/meta-schemas/core.yaml' is not one of ['http://devicetree.org/meta-schemas/core.yaml#', 'http://devicetree.org/meta-schemas/base.yaml#']
> >   Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml: ignoring, error in schema: $id
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> >  Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> > index cf7dc83f724f..037c51b2f972 100644
> > --- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> > +++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> > @@ -1,8 +1,8 @@
> >  # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> >  %YAML 1.2
> >  ---
> > -$id: http://devicetree.org/schemas/soc/ti/ti,pruss.yaml
> > -$schema: http://devicetree.org/meta-schemas/core.yaml
> > +$id: http://devicetree.org/schemas/soc/ti/ti,pruss.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
>
> I've double checked and "#" was present in the original patch sent and
> ack for upstream: https://patchwork.kernel.org/patch/11729649/
> It seems like something got wrong on linux-next but this is the only
> diff between original patch and one found in linux-next. Thank you for
> taking care of it.

Indeed that's weird. It must get lost when applying...

Best regards,
Krzysztof
Suman Anna Sept. 17, 2020, 2:57 p.m. UTC | #3
On 9/17/20 3:35 AM, Krzysztof Kozlowski wrote:
> On Thu, 17 Sep 2020 at 10:32, Grzegorz Jaszczyk
> <grzegorz.jaszczyk@linaro.org> wrote:
>>
>> On Thu, 17 Sep 2020 at 09:05, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>>
>>> Add missing '#' to fix schema errors:
>>>
>>>   $id: 'http://devicetree.org/schemas/soc/ti/ti,pruss.yaml' does not match 'http://devicetree.org/schemas/.*\\.yaml#'
>>>   $schema: 'http://devicetree.org/meta-schemas/core.yaml' is not one of ['http://devicetree.org/meta-schemas/core.yaml#', 'http://devicetree.org/meta-schemas/base.yaml#']
>>>   Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml: ignoring, error in schema: $id
>>>

Thanks for the fix, Krzysztof.

Fixes: bd691ce0ba9d ("dt-bindings: soc: ti: Add TI PRUSS bindings")
>>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

With that,
Acked-by: Suman Anna <s-anna@ti.com>

Santosh,
Can you please pick this up before you send your pull request to arm-soc
maintainers?

You may also want to check your tooling to see what happened.

regards
Suman


>>> ---
>>>  Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>>> index cf7dc83f724f..037c51b2f972 100644
>>> --- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>>> +++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>>> @@ -1,8 +1,8 @@
>>>  # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>>  %YAML 1.2
>>>  ---
>>> -$id: http://devicetree.org/schemas/soc/ti/ti,pruss.yaml
>>> -$schema: http://devicetree.org/meta-schemas/core.yaml
>>> +$id: http://devicetree.org/schemas/soc/ti/ti,pruss.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>
>> I've double checked and "#" was present in the original patch sent and
>> ack for upstream: https://patchwork.kernel.org/patch/11729649/
>> It seems like something got wrong on linux-next but this is the only
>> diff between original patch and one found in linux-next. Thank you for
>> taking care of it.
> 
> Indeed that's weird. It must get lost when applying...
> 
> Best regards,
> Krzysztof
>
santosh.shilimkar@oracle.com Sept. 17, 2020, 6:04 p.m. UTC | #4
On 9/17/20 1:35 AM, Krzysztof Kozlowski wrote:
> On Thu, 17 Sep 2020 at 10:32, Grzegorz Jaszczyk
> <grzegorz.jaszczyk@linaro.org> wrote:
>>
>> On Thu, 17 Sep 2020 at 09:05, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>>
>>> Add missing '#' to fix schema errors:
>>>
>>>    $id: 'https://urldefense.com/v3/__http://devicetree.org/schemas/soc/ti/ti,pruss.yaml__;!!GqivPVa7Brio!NF67-KbyQr0smc7iM86dsdgoOaQrQRN4F2aNdLndleTjLn6BhqrmDBL4ekWiVIG6IBFwLA$ ' does not match 'https://urldefense.com/v3/__http://devicetree.org/schemas/.**A5C*5C.yaml*__;KiUlIw!!GqivPVa7Brio!NF67-KbyQr0smc7iM86dsdgoOaQrQRN4F2aNdLndleTjLn6BhqrmDBL4ekWiVIGpNPP7ig$ '
>>>    $schema: 'https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml__;!!GqivPVa7Brio!NF67-KbyQr0smc7iM86dsdgoOaQrQRN4F2aNdLndleTjLn6BhqrmDBL4ekWiVIEdWH0Bzw$ ' is not one of ['https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!GqivPVa7Brio!NF67-KbyQr0smc7iM86dsdgoOaQrQRN4F2aNdLndleTjLn6BhqrmDBL4ekWiVIHcNI2bOQ$ ', 'https://urldefense.com/v3/__http://devicetree.org/meta-schemas/base.yaml*__;Iw!!GqivPVa7Brio!NF67-KbyQr0smc7iM86dsdgoOaQrQRN4F2aNdLndleTjLn6BhqrmDBL4ekWiVIFH0HvA-g$ ']
>>>    Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml: ignoring, error in schema: $id
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>>> ---
>>>   Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>>> index cf7dc83f724f..037c51b2f972 100644
>>> --- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>>> +++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>>> @@ -1,8 +1,8 @@
>>>   # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>>   %YAML 1.2
>>>   ---
>>> -$id: https://urldefense.com/v3/__http://devicetree.org/schemas/soc/ti/ti,pruss.yaml__;!!GqivPVa7Brio!NF67-KbyQr0smc7iM86dsdgoOaQrQRN4F2aNdLndleTjLn6BhqrmDBL4ekWiVIG6IBFwLA$
>>> -$schema: https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml__;!!GqivPVa7Brio!NF67-KbyQr0smc7iM86dsdgoOaQrQRN4F2aNdLndleTjLn6BhqrmDBL4ekWiVIEdWH0Bzw$
>>> +$id: https://urldefense.com/v3/__http://devicetree.org/schemas/soc/ti/ti,pruss.yaml*__;Iw!!GqivPVa7Brio!NF67-KbyQr0smc7iM86dsdgoOaQrQRN4F2aNdLndleTjLn6BhqrmDBL4ekWiVIHAb7bLvA$
>>> +$schema: https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!GqivPVa7Brio!NF67-KbyQr0smc7iM86dsdgoOaQrQRN4F2aNdLndleTjLn6BhqrmDBL4ekWiVIHcNI2bOQ$
>>
>> I've double checked and "#" was present in the original patch sent and
>> ack for upstream: https://urldefense.com/v3/__https://patchwork.kernel.org/patch/11729649/__;!!GqivPVa7Brio!NF67-KbyQr0smc7iM86dsdgoOaQrQRN4F2aNdLndleTjLn6BhqrmDBL4ekWiVIEaRPpx1g$
>> It seems like something got wrong on linux-next but this is the only
>> diff between original patch and one found in linux-next. Thank you for
>> taking care of it.
> 
> Indeed that's weird. It must get lost when applying...
> 
These URLs get mangled sometimes and I needed to fix them. Will fix the
original commit. Thanks for reporting.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
index cf7dc83f724f..037c51b2f972 100644
--- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
+++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
@@ -1,8 +1,8 @@ 
 # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/soc/ti/ti,pruss.yaml
-$schema: http://devicetree.org/meta-schemas/core.yaml
+$id: http://devicetree.org/schemas/soc/ti/ti,pruss.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: |+
   TI Programmable Real-Time Unit and Industrial Communication Subsystem