diff mbox series

[05/10] dt-bindings: remoteproc: qcom,q6v5: Deprecate regulators for PDs

Message ID 20200916104135.25085-6-stephan@gerhold.net
State Changes Requested
Headers show
Series Convert MSM8916 to use rpmpd/power domains | expand

Checks

Context Check Description
robh/checkpatch success

Commit Message

Stephan Gerhold Sept. 16, 2020, 10:41 a.m. UTC
Newer platforms vote for necessary power domains through the power
domain subsystem. For historical reasons older platforms like MSM8916
or MSM8974 still control these as regulators.

Managing them as power domains is preferred since that allows us
to vote for corners instead of raw voltages. Document that those
should be specified as power domains and deprecate using them
through the regulator interface.

Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
---
 .../devicetree/bindings/remoteproc/qcom,q6v5.txt     | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Rob Herring Sept. 23, 2020, 3:35 p.m. UTC | #1
On Wed, Sep 16, 2020 at 12:41:30PM +0200, Stephan Gerhold wrote:
> Newer platforms vote for necessary power domains through the power
> domain subsystem. For historical reasons older platforms like MSM8916
> or MSM8974 still control these as regulators.

Do you plan to change these platforms? If not then I wouldn't really 
call this deprecated.

> 
> Managing them as power domains is preferred since that allows us
> to vote for corners instead of raw voltages. Document that those
> should be specified as power domains and deprecate using them
> through the regulator interface.
> 
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> ---
>  .../devicetree/bindings/remoteproc/qcom,q6v5.txt     | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
> index 1f9a62e13ebe..7ccd5534b0ae 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
> @@ -113,8 +113,8 @@ should be referenced as follows:
>  For the compatible strings below the following supplies are required:
>    "qcom,q6v5-pil"
>    "qcom,msm8916-mss-pil",
> -- cx-supply:
> -- mx-supply:
> +- cx-supply: (deprecated, use power domain instead)
> +- mx-supply: (deprecated, use power domain instead)
>  - pll-supply:
>  	Usage: required
>  	Value type: <phandle>
> @@ -123,9 +123,9 @@ For the compatible strings below the following supplies are required:
>  
>  For the compatible string below the following supplies are required:
>    "qcom,msm8974-mss-pil"
> -- cx-supply:
> +- cx-supply: (deprecated, use power domain instead)
>  - mss-supply:
> -- mx-supply:
> +- mx-supply: (deprecated, use power domain instead)
>  - pll-supply:
>  	Usage: required
>  	Value type: <phandle>
> @@ -149,11 +149,11 @@ For the compatible string below the following supplies are required:
>  	Usage: required
>  	Value type: <stringlist>
>  	Definition: The power-domains needed depend on the compatible string:
> -	qcom,q6v5-pil:
>  	qcom,ipq8074-wcss-pil:
> +		    no power-domain names required
> +	qcom,q6v5-pil:
>  	qcom,msm8916-mss-pil:
>  	qcom,msm8974-mss-pil:
> -		    no power-domain names required
>  	qcom,msm8996-mss-pil:
>  	qcom,msm8998-mss-pil:
>  		    must be "cx", "mx"
> -- 
> 2.28.0
>
Stephan Gerhold Sept. 23, 2020, 3:51 p.m. UTC | #2
On Wed, Sep 23, 2020 at 09:35:48AM -0600, Rob Herring wrote:
> On Wed, Sep 16, 2020 at 12:41:30PM +0200, Stephan Gerhold wrote:
> > Newer platforms vote for necessary power domains through the power
> > domain subsystem. For historical reasons older platforms like MSM8916
> > or MSM8974 still control these as regulators.
> 
> Do you plan to change these platforms? If not then I wouldn't really 
> call this deprecated.
> 

Yes, MSM8916 is changed as part of this patch series.

It should also be done for MSM8974, but because I don't have any test
devices with it I'm not able to do it myself.

Actually the old binding likely works only because of other side effects
(other drivers voting for the same resources), so I personally I would
definitely call it deprecated.

Thanks!
Stephan
Rob Herring Sept. 23, 2020, 8:02 p.m. UTC | #3
On Wed, Sep 23, 2020 at 9:51 AM Stephan Gerhold <stephan@gerhold.net> wrote:
>
> On Wed, Sep 23, 2020 at 09:35:48AM -0600, Rob Herring wrote:
> > On Wed, Sep 16, 2020 at 12:41:30PM +0200, Stephan Gerhold wrote:
> > > Newer platforms vote for necessary power domains through the power
> > > domain subsystem. For historical reasons older platforms like MSM8916
> > > or MSM8974 still control these as regulators.
> >
> > Do you plan to change these platforms? If not then I wouldn't really
> > call this deprecated.
> >
>
> Yes, MSM8916 is changed as part of this patch series.
>
> It should also be done for MSM8974, but because I don't have any test
> devices with it I'm not able to do it myself.
>
> Actually the old binding likely works only because of other side effects
> (other drivers voting for the same resources), so I personally I would
> definitely call it deprecated.

Okay.

Reviewed-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
index 1f9a62e13ebe..7ccd5534b0ae 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
@@ -113,8 +113,8 @@  should be referenced as follows:
 For the compatible strings below the following supplies are required:
   "qcom,q6v5-pil"
   "qcom,msm8916-mss-pil",
-- cx-supply:
-- mx-supply:
+- cx-supply: (deprecated, use power domain instead)
+- mx-supply: (deprecated, use power domain instead)
 - pll-supply:
 	Usage: required
 	Value type: <phandle>
@@ -123,9 +123,9 @@  For the compatible strings below the following supplies are required:
 
 For the compatible string below the following supplies are required:
   "qcom,msm8974-mss-pil"
-- cx-supply:
+- cx-supply: (deprecated, use power domain instead)
 - mss-supply:
-- mx-supply:
+- mx-supply: (deprecated, use power domain instead)
 - pll-supply:
 	Usage: required
 	Value type: <phandle>
@@ -149,11 +149,11 @@  For the compatible string below the following supplies are required:
 	Usage: required
 	Value type: <stringlist>
 	Definition: The power-domains needed depend on the compatible string:
-	qcom,q6v5-pil:
 	qcom,ipq8074-wcss-pil:
+		    no power-domain names required
+	qcom,q6v5-pil:
 	qcom,msm8916-mss-pil:
 	qcom,msm8974-mss-pil:
-		    no power-domain names required
 	qcom,msm8996-mss-pil:
 	qcom,msm8998-mss-pil:
 		    must be "cx", "mx"