diff mbox series

[03/25] dt-bindings: iio: adc: exynos-adc: do not require syscon on S5Pv210

Message ID 20200907161141.31034-4-krzk@kernel.org
State Superseded
Headers show
Series ARM: dts: s5pv210: Cleanup - dtschema warnings | expand

Checks

Context Check Description
robh/dt-meta-schema success
robh/checkpatch success

Commit Message

Krzysztof Kozlowski Sept. 7, 2020, 4:11 p.m. UTC
The ADC in S5Pv210 does not have ADC phy registers in separate block for
which syscon would be needed.  Remove this requirement to fix dtbs_check
warnings like:

  arch/arm/boot/dts/s5pv210-fascinate4g.dt.yaml: adc@e1700000: 'samsung,syscon-phandle' is a required property

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml          | 1 -
 1 file changed, 1 deletion(-)

Comments

Jonathan Cameron Sept. 7, 2020, 4:39 p.m. UTC | #1
On Mon,  7 Sep 2020 18:11:19 +0200
Krzysztof Kozlowski <krzk@kernel.org> wrote:

> The ADC in S5Pv210 does not have ADC phy registers in separate block for
> which syscon would be needed.  Remove this requirement to fix dtbs_check
> warnings like:
> 
>   arch/arm/boot/dts/s5pv210-fascinate4g.dt.yaml: adc@e1700000: 'samsung,syscon-phandle' is a required property
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> ---
>  .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml          | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> index 89b4f9c252a6..75174af72288 100644
> --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> @@ -81,7 +81,6 @@ allOf:
>                - samsung,exynos-adc-v2
>                - samsung,exynos3250-adc
>                - samsung,exynos4212-adc
> -              - samsung,s5pv210-adc
>      then:
>        required:
>          - samsung,syscon-phandle
Jonathan Bakker Sept. 7, 2020, 9:49 p.m. UTC | #2
Looking at this again, it appears that there is actually control for
it at offset 0x6818 of pmu_syscon (0xe0108000) [1].  However, it defaults to
enabled so it's not required for proper use of the block.  Whether it should
be present in the schema/DTS is up to you.

Thanks,
Jonathan

[1] https://android.googlesource.com/kernel/samsung/+/refs/heads/android-samsung-3.0-jb-mr0/arch/arm/mach-s5pv210/include/mach/regs-clock.h#325

On 2020-09-07 9:11 a.m., Krzysztof Kozlowski wrote:
> The ADC in S5Pv210 does not have ADC phy registers in separate block for
> which syscon would be needed.  Remove this requirement to fix dtbs_check
> warnings like:
> 
>   arch/arm/boot/dts/s5pv210-fascinate4g.dt.yaml: adc@e1700000: 'samsung,syscon-phandle' is a required property
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml          | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> index 89b4f9c252a6..75174af72288 100644
> --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> @@ -81,7 +81,6 @@ allOf:
>                - samsung,exynos-adc-v2
>                - samsung,exynos3250-adc
>                - samsung,exynos4212-adc
> -              - samsung,s5pv210-adc
>      then:
>        required:
>          - samsung,syscon-phandle
>
Krzysztof Kozlowski Sept. 8, 2020, 6:48 a.m. UTC | #3
On Mon, Sep 07, 2020 at 02:49:49PM -0700, Jonathan Bakker wrote:
> Looking at this again, it appears that there is actually control for
> it at offset 0x6818 of pmu_syscon (0xe0108000) [1].  However, it defaults to
> enabled so it's not required for proper use of the block.  Whether it should
> be present in the schema/DTS is up to you.

Indeed the driver could turn off the ADC phy via syscon however bindings
(before YAML conversion) explicitly were saying that it is not needed. I
am not going to add it as I am not able to test the change and also
adding such requirement would be a break of ABI (described by first TXT
bindings).

Best regards,
Krzysztof


> 
> Thanks,
> Jonathan
> 
> [1] https://android.googlesource.com/kernel/samsung/+/refs/heads/android-samsung-3.0-jb-mr0/arch/arm/mach-s5pv210/include/mach/regs-clock.h#325
> 
> On 2020-09-07 9:11 a.m., Krzysztof Kozlowski wrote:
> > The ADC in S5Pv210 does not have ADC phy registers in separate block for
> > which syscon would be needed.  Remove this requirement to fix dtbs_check
> > warnings like:
> > 
> >   arch/arm/boot/dts/s5pv210-fascinate4g.dt.yaml: adc@e1700000: 'samsung,syscon-phandle' is a required property
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> >  .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml          | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> > index 89b4f9c252a6..75174af72288 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> > @@ -81,7 +81,6 @@ allOf:
> >                - samsung,exynos-adc-v2
> >                - samsung,exynos3250-adc
> >                - samsung,exynos4212-adc
> > -              - samsung,s5pv210-adc
> >      then:
> >        required:
> >          - samsung,syscon-phandle
> >
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
index 89b4f9c252a6..75174af72288 100644
--- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
@@ -81,7 +81,6 @@  allOf:
               - samsung,exynos-adc-v2
               - samsung,exynos3250-adc
               - samsung,exynos4212-adc
-              - samsung,s5pv210-adc
     then:
       required:
         - samsung,syscon-phandle