diff mbox series

[1/3] dt-bindings: crypto: slimsss: Correct a typo in compatible

Message ID 20200903180400.2865-1-krzk@kernel.org
State Accepted
Headers show
Series [1/3] dt-bindings: crypto: slimsss: Correct a typo in compatible | expand

Checks

Context Check Description
robh/dt-meta-schema success
robh/checkpatch success

Commit Message

Krzysztof Kozlowski Sept. 3, 2020, 6:03 p.m. UTC
Correct a typo in the compatible - missing trailing 's'.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kamil Konieczny Sept. 4, 2020, 9:06 a.m. UTC | #1
On 9/3/20 8:04 PM, Krzysztof Kozlowski wrote:
> Pass the error directly from devm_clk_get() to describe the real reason,
> instead of fixed ENOENT.  Do not print error messages on deferred probe.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  drivers/crypto/s5p-sss.c | 15 +++++++--------
>  1 file changed, 7 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
> index f67f1e22ecd1..e83145c43b18 100644
> --- a/drivers/crypto/s5p-sss.c
> +++ b/drivers/crypto/s5p-sss.c
> @@ -2201,11 +2201,10 @@ static int s5p_aes_probe(struct platform_device *pdev)
>  	}
>  
>  	pdata->clk = devm_clk_get(dev, variant->clk_names[0]);
> -	if (IS_ERR(pdata->clk)) {
> -		dev_err(dev, "failed to find secss clock %s\n",
> -			variant->clk_names[0]);
> -		return -ENOENT;
> -	}
> +	if (IS_ERR(pdata->clk))
> +		return dev_err_probe(dev, PTR_ERR(pdata->clk),
> +				     "failed to find secss clock %s\n",
> +				     variant->clk_names[0]);
>  
>  	err = clk_prepare_enable(pdata->clk);
>  	if (err < 0) {
> @@ -2217,9 +2216,9 @@ static int s5p_aes_probe(struct platform_device *pdev)
>  	if (variant->clk_names[1]) {
>  		pdata->pclk = devm_clk_get(dev, variant->clk_names[1]);
>  		if (IS_ERR(pdata->pclk)) {
> -			dev_err(dev, "failed to find clock %s\n",
> -				variant->clk_names[1]);
> -			err = -ENOENT;
> +			err = dev_err_probe(dev, PTR_ERR(pdata->pclk),
> +					    "failed to find clock %s\n",
> +					    variant->clk_names[1]);
>  			goto err_clk;
>  		}
>  
> 

Reviewed-by: Kamil Konieczny <k.konieczny@samsung.com>
Acked-by: Kamil Konieczny <k.konieczny@samsung.com>
Kamil Konieczny Sept. 4, 2020, 9:07 a.m. UTC | #2
On 9/3/20 8:03 PM, Krzysztof Kozlowski wrote:
> Add missing and fix existing kerneldoc to silence W=1 warnings:
> 
>   drivers/crypto/s5p-sss.c:333: warning: Function parameter or member 'pclk' not described in 's5p_aes_dev'
>   drivers/crypto/s5p-sss.c:373: warning: Function parameter or member 'sgl' not described in 's5p_hash_reqctx'
>   drivers/crypto/s5p-sss.c:373: warning: Function parameter or member 'buffer' not described in 's5p_hash_reqctx'
>   drivers/crypto/s5p-sss.c:1143: warning: Function parameter or member 'new_len' not described in 's5p_hash_prepare_sgs'
>   drivers/crypto/s5p-sss.c:1143: warning: Excess function parameter 'nbytes' description in 's5p_hash_prepare_sgs'
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  drivers/crypto/s5p-sss.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
> index 341433fbcc4a..f67f1e22ecd1 100644
> --- a/drivers/crypto/s5p-sss.c
> +++ b/drivers/crypto/s5p-sss.c
> @@ -260,6 +260,7 @@ struct s5p_aes_ctx {
>   * struct s5p_aes_dev - Crypto device state container
>   * @dev:	Associated device
>   * @clk:	Clock for accessing hardware
> + * @pclk:	APB bus clock necessary to access the hardware
>   * @ioaddr:	Mapped IO memory region
>   * @aes_ioaddr:	Per-varian offset for AES block IO memory
>   * @irq_fc:	Feed control interrupt line
> @@ -342,13 +343,13 @@ struct s5p_aes_dev {
>   * @engine:	Bits for selecting type of HASH in SSS block
>   * @sg:		sg for DMA transfer
>   * @sg_len:	Length of sg for DMA transfer
> - * @sgl[]:	sg for joining buffer and req->src scatterlist
> + * @sgl:	sg for joining buffer and req->src scatterlist
>   * @skip:	Skip offset in req->src for current op
>   * @total:	Total number of bytes for current request
>   * @finup:	Keep state for finup or final.
>   * @error:	Keep track of error.
>   * @bufcnt:	Number of bytes holded in buffer[]
> - * @buffer[]:	For byte(s) from end of req->src in UPDATE op
> + * @buffer:	For byte(s) from end of req->src in UPDATE op
>   */
>  struct s5p_hash_reqctx {
>  	struct s5p_aes_dev	*dd;
> @@ -1125,7 +1126,7 @@ static int s5p_hash_copy_sg_lists(struct s5p_hash_reqctx *ctx,
>   * s5p_hash_prepare_sgs() - prepare sg for processing
>   * @ctx:	request context
>   * @sg:		source scatterlist request
> - * @nbytes:	number of bytes to process from sg
> + * @new_len:	number of bytes to process from sg
>   * @final:	final flag
>   *
>   * Check two conditions: (1) if buffers in sg have len aligned data, and (2)
> 

Reviewed-by: Kamil Konieczny <k.konieczny@samsung.com>
Acked-by: Kamil Konieczny <k.konieczny@samsung.com>
Kamil Konieczny Sept. 4, 2020, 9:07 a.m. UTC | #3
On 9/3/20 8:03 PM, Krzysztof Kozlowski wrote:
> Correct a typo in the compatible - missing trailing 's'.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml b/Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml
> index 04fe5dfa794a..7743eae049ab 100644
> --- a/Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml
> +++ b/Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml
> @@ -19,7 +19,7 @@ description: |+
>  properties:
>    compatible:
>      items:
> -      - const: samsung,exynos5433-slim-ss
> +      - const: samsung,exynos5433-slim-sss
>  
>    reg:
>      maxItems: 1
> 

Reviewed-by: Kamil Konieczny <k.konieczny@samsung.com>
Acked-by: Kamil Konieczny <k.konieczny@samsung.com>
Krzysztof Kozlowski Sept. 4, 2020, 9:17 a.m. UTC | #4
On Fri, 4 Sep 2020 at 11:07, Kamil Konieczny <k.konieczny@samsung.com> wrote:
>
>
>
> On 9/3/20 8:03 PM, Krzysztof Kozlowski wrote:
> > Correct a typo in the compatible - missing trailing 's'.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> >  Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml b/Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml
> > index 04fe5dfa794a..7743eae049ab 100644
> > --- a/Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml
> > +++ b/Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml
> > @@ -19,7 +19,7 @@ description: |+
> >  properties:
> >    compatible:
> >      items:
> > -      - const: samsung,exynos5433-slim-ss
> > +      - const: samsung,exynos5433-slim-sss
> >
> >    reg:
> >      maxItems: 1
> >
>
> Reviewed-by: Kamil Konieczny <k.konieczny@samsung.com>
> Acked-by: Kamil Konieczny <k.konieczny@samsung.com>

Thanks. In this case "Reviewed" is enough, it includes the meaning of Ack.

Best regards,
Krzysztof
Herbert Xu Sept. 11, 2020, 6:59 a.m. UTC | #5
On Thu, Sep 03, 2020 at 08:03:59PM +0200, Krzysztof Kozlowski wrote:
> Add missing and fix existing kerneldoc to silence W=1 warnings:
> 
>   drivers/crypto/s5p-sss.c:333: warning: Function parameter or member 'pclk' not described in 's5p_aes_dev'
>   drivers/crypto/s5p-sss.c:373: warning: Function parameter or member 'sgl' not described in 's5p_hash_reqctx'
>   drivers/crypto/s5p-sss.c:373: warning: Function parameter or member 'buffer' not described in 's5p_hash_reqctx'
>   drivers/crypto/s5p-sss.c:1143: warning: Function parameter or member 'new_len' not described in 's5p_hash_prepare_sgs'
>   drivers/crypto/s5p-sss.c:1143: warning: Excess function parameter 'nbytes' description in 's5p_hash_prepare_sgs'
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  drivers/crypto/s5p-sss.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

Patch applied.  Thanks.
Herbert Xu Sept. 11, 2020, 6:59 a.m. UTC | #6
On Thu, Sep 03, 2020 at 08:04:00PM +0200, Krzysztof Kozlowski wrote:
> Pass the error directly from devm_clk_get() to describe the real reason,
> instead of fixed ENOENT.  Do not print error messages on deferred probe.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  drivers/crypto/s5p-sss.c | 15 +++++++--------
>  1 file changed, 7 insertions(+), 8 deletions(-)

Patch applied.  Thanks.
Rob Herring Sept. 14, 2020, 8:34 p.m. UTC | #7
On Thu, 03 Sep 2020 20:03:58 +0200, Krzysztof Kozlowski wrote:
> Correct a typo in the compatible - missing trailing 's'.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied, thanks!
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml b/Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml
index 04fe5dfa794a..7743eae049ab 100644
--- a/Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml
+++ b/Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml
@@ -19,7 +19,7 @@  description: |+
 properties:
   compatible:
     items:
-      - const: samsung,exynos5433-slim-ss
+      - const: samsung,exynos5433-slim-sss
 
   reg:
     maxItems: 1