diff mbox series

[v4,1/4] dt-bindings: usb: add rk3328 dwc3 docs

Message ID 20200902181234.13955-1-lindsey.stanpoor@gmail.com
State Not Applicable
Headers show
Series [v4,1/4] dt-bindings: usb: add rk3328 dwc3 docs | expand

Checks

Context Check Description
robh/checkpatch success

Commit Message

Lindsey Stanpoor Sept. 2, 2020, 6:12 p.m. UTC
From: Cameron Nemo <cnemo@tutanota.com>

Document compatible for dwc3 on the Rockchip rk3328 platform.

Signed-off-by: Cameron Nemo <cnemo@tutanota.com>
---
 Documentation/devicetree/bindings/usb/dwc3.txt          | 1 +
 Documentation/devicetree/bindings/usb/rockchip,dwc3.txt | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

Comments

Rob Herring Sept. 14, 2020, 8:26 p.m. UTC | #1
On Wed, 02 Sep 2020 11:12:31 -0700, lindsey.stanpoor@gmail.com wrote:
> From: Cameron Nemo <cnemo@tutanota.com>
> 
> Document compatible for dwc3 on the Rockchip rk3328 platform.
> 
> Signed-off-by: Cameron Nemo <cnemo@tutanota.com>
> ---
>  Documentation/devicetree/bindings/usb/dwc3.txt          | 1 +
>  Documentation/devicetree/bindings/usb/rockchip,dwc3.txt | 3 ++-
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 

Acked-by: Rob Herring <robh@kernel.org>
Lindsey Stanpoor Nov. 7, 2020, 2:37 a.m. UTC | #2
On Wed, Sep 2, 2020 at 11:12 AM <lindsey.stanpoor@gmail.com> wrote:
>
> From: Cameron Nemo <cnemo@tutanota.com>
>
> Document compatible for dwc3 on the Rockchip rk3328 platform.

Hi all,

Wanted to give this patch submission a gentle ping.

Rob Herring acked the documentation changes, but I have not heard
anything
from the USB or Rockchip maintainers. This patchset would facilitate USB3
support for Rockchip rk3328 devices like the Pine Rock64.

If there is anything I can do to help move this along, please let me know.

Thank you,
Cameron

>
> Signed-off-by: Cameron Nemo <cnemo@tutanota.com>
> ---
>  Documentation/devicetree/bindings/usb/dwc3.txt          | 1 +
>  Documentation/devicetree/bindings/usb/rockchip,dwc3.txt | 3 ++-
>  2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt
> index d03edf9d3935..d625cd5966e9 100644
> --- a/Documentation/devicetree/bindings/usb/dwc3.txt
> +++ b/Documentation/devicetree/bindings/usb/dwc3.txt
> @@ -25,6 +25,7 @@ Exception for clocks:
>      "ti,am437x-dwc3"
>      "ti,dwc3"
>      "ti,keystone-dwc3"
> +    "rockchip,rk3328-dwc3"
>      "rockchip,rk3399-dwc3"
>      "xlnx,zynqmp-dwc3"
>
> diff --git a/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt b/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt
> index 94520493233b..b41f30a61be6 100644
> --- a/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt
> +++ b/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt
> @@ -1,7 +1,8 @@
>  Rockchip SuperSpeed DWC3 USB SoC controller
>
>  Required properties:
> -- compatible:  should contain "rockchip,rk3399-dwc3" for rk3399 SoC
> +- compatible:  should contain "rockchip,rk3328-dwc3" for rk3328 SoC
> +               or "rockchip,rk3399-dwc3" for rk3399 SoC
>  - clocks:      A list of phandle + clock-specifier pairs for the
>                 clocks listed in clock-names
>  - clock-names: Should contain the following:
> --
> 2.28.0
>
Felipe Balbi Nov. 7, 2020, 7:42 a.m. UTC | #3
Hi,

Lindsey Stanpoor <lindsey.stanpoor@gmail.com> writes:
> On Wed, Sep 2, 2020 at 11:12 AM <lindsey.stanpoor@gmail.com> wrote:
>>
>> From: Cameron Nemo <cnemo@tutanota.com>
>>
>> Document compatible for dwc3 on the Rockchip rk3328 platform.
>
> Hi all,
>
> Wanted to give this patch submission a gentle ping.
>
> Rob Herring acked the documentation changes, but I have not heard
> anything
> from the USB or Rockchip maintainers. This patchset would facilitate USB3
> support for Rockchip rk3328 devices like the Pine Rock64.
>
> If there is anything I can do to help move this along, please let me know.

Sorry, it had fallen through the cracks. It's now in my testing/next.
Lindsey Stanpoor Jan. 21, 2021, 4:28 a.m. UTC | #4
On Fri, Nov 6, 2020 at 11:42 PM Felipe Balbi <balbi@kernel.org> wrote:
>
>
> Hi,
>
> Lindsey Stanpoor <lindsey.stanpoor@gmail.com> writes:
> > On Wed, Sep 2, 2020 at 11:12 AM <lindsey.stanpoor@gmail.com> wrote:
> >>
> >> From: Cameron Nemo <cnemo@tutanota.com>
> >>
> >> Document compatible for dwc3 on the Rockchip rk3328 platform.
> >
> > Hi all,
> >
> > Wanted to give this patch submission a gentle ping.
> >
> > Rob Herring acked the documentation changes, but I have not heard
> > anything
> > from the USB or Rockchip maintainers. This patchset would facilitate USB3
> > support for Rockchip rk3328 devices like the Pine Rock64.
> >
> > If there is anything I can do to help move this along, please let me know.
>
> Sorry, it had fallen through the cracks. It's now in my testing/next.

Following up on this. Will this move out of your testing/next?
--
Cameron
Chen-Yu Tsai Jan. 21, 2021, 4:40 a.m. UTC | #5
On Thu, Jan 21, 2021 at 12:30 PM Lindsey Stanpoor
<lindsey.stanpoor@gmail.com> wrote:
>
> On Fri, Nov 6, 2020 at 11:42 PM Felipe Balbi <balbi@kernel.org> wrote:
> >
> >
> > Hi,
> >
> > Lindsey Stanpoor <lindsey.stanpoor@gmail.com> writes:
> > > On Wed, Sep 2, 2020 at 11:12 AM <lindsey.stanpoor@gmail.com> wrote:
> > >>
> > >> From: Cameron Nemo <cnemo@tutanota.com>
> > >>
> > >> Document compatible for dwc3 on the Rockchip rk3328 platform.
> > >
> > > Hi all,
> > >
> > > Wanted to give this patch submission a gentle ping.
> > >
> > > Rob Herring acked the documentation changes, but I have not heard
> > > anything
> > > from the USB or Rockchip maintainers. This patchset would facilitate USB3
> > > support for Rockchip rk3328 devices like the Pine Rock64.
> > >
> > > If there is anything I can do to help move this along, please let me know.
> >
> > Sorry, it had fallen through the cracks. It's now in my testing/next.
>
> Following up on this. Will this move out of your testing/next?

The binding changes are likely stale now that the dwc3 binding has been
converted to YAML. See Greg's USB tree.

Also the DT changes should go through the arm-soc tree separately, so
we can stack on additional changes enabling USB3 on other boards.

ChenYu



> --
> Cameron
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt
index d03edf9d3935..d625cd5966e9 100644
--- a/Documentation/devicetree/bindings/usb/dwc3.txt
+++ b/Documentation/devicetree/bindings/usb/dwc3.txt
@@ -25,6 +25,7 @@  Exception for clocks:
     "ti,am437x-dwc3"
     "ti,dwc3"
     "ti,keystone-dwc3"
+    "rockchip,rk3328-dwc3"
     "rockchip,rk3399-dwc3"
     "xlnx,zynqmp-dwc3"
 
diff --git a/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt b/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt
index 94520493233b..b41f30a61be6 100644
--- a/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt
+++ b/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt
@@ -1,7 +1,8 @@ 
 Rockchip SuperSpeed DWC3 USB SoC controller
 
 Required properties:
-- compatible:	should contain "rockchip,rk3399-dwc3" for rk3399 SoC
+- compatible:	should contain "rockchip,rk3328-dwc3" for rk3328 SoC
+		or "rockchip,rk3399-dwc3" for rk3399 SoC
 - clocks:	A list of phandle + clock-specifier pairs for the
 		clocks listed in clock-names
 - clock-names:	Should contain the following: