| Message ID | 20200831220601.20794-4-santiagohssl@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | KT0913 FM/AM driver | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | fail | build log |
On Mon, 31 Aug 2020 19:06:01 -0300, Santiago Hormazabal wrote: > Document bindings for the kt0913 AM/FM radio tuner. > > Signed-off-by: Santiago Hormazabal <santiagohssl@gmail.com> > --- > .../bindings/media/i2c/ktm,kt0913.yaml | 56 +++++++++++++++++++ > 1 file changed, 56 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/ktm,kt0913.yaml > My bot found errors running 'make dt_binding_check' on your patch: ./Documentation/devicetree/bindings/media/i2c/ktm,kt0913.yaml: $id: relative path/filename doesn't match actual path or filename expected: http://devicetree.org/schemas/media/i2c/ktm,kt0913.yaml# Documentation/devicetree/bindings/media/i2c/ktm,kt0913.example.dts:22.17-30: Warning (reg_format): /example-0/i2c/fm-am-tuner@35:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) Documentation/devicetree/bindings/media/i2c/ktm,kt0913.example.dt.yaml: Warning (pci_device_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/media/i2c/ktm,kt0913.example.dt.yaml: Warning (pci_device_bus_num): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/media/i2c/ktm,kt0913.example.dt.yaml: Warning (simple_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/media/i2c/ktm,kt0913.example.dts:19.13-26.11: Warning (i2c_bus_bridge): /example-0/i2c: incorrect #address-cells for I2C bus Documentation/devicetree/bindings/media/i2c/ktm,kt0913.example.dts:19.13-26.11: Warning (i2c_bus_bridge): /example-0/i2c: incorrect #size-cells for I2C bus Documentation/devicetree/bindings/media/i2c/ktm,kt0913.example.dt.yaml: Warning (i2c_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/media/i2c/ktm,kt0913.example.dt.yaml: Warning (i2c_bus_reg): Failed prerequisite 'i2c_bus_bridge' Documentation/devicetree/bindings/media/i2c/ktm,kt0913.example.dt.yaml: Warning (spi_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/media/i2c/ktm,kt0913.example.dts:20.36-25.15: Warning (avoid_default_addr_size): /example-0/i2c/fm-am-tuner@35: Relying on default #address-cells value Documentation/devicetree/bindings/media/i2c/ktm,kt0913.example.dts:20.36-25.15: Warning (avoid_default_addr_size): /example-0/i2c/fm-am-tuner@35: Relying on default #size-cells value Documentation/devicetree/bindings/media/i2c/ktm,kt0913.example.dt.yaml: Warning (unique_unit_address): Failed prerequisite 'avoid_default_addr_size' See https://patchwork.ozlabs.org/patch/1354644 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/media/i2c/ktm,kt0913.yaml b/Documentation/devicetree/bindings/media/i2c/ktm,kt0913.yaml new file mode 100644 index 000000000000..2c3d1795da43 --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/ktm,kt0913.yaml @@ -0,0 +1,56 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (c) 2020 Santiago Hormazabal <santiagohssl@gmail.com> +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/ktm,kt0913.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Device-Tree bindings for the KTMicro KT0913 FM/AM radio tuner. + +maintainers: + - Santiago Hormazabal <santiagohssl@gmail.com> + +description: |- + The KT0913 is a low cost, low components FM/AM radio chip. + It uses the I2C protocol for operation. + +properties: + compatible: + const: ktm,kt0913 + + reg: + description: I2C device address + const: 0x35 + + ktm,anti-pop: + description: | + Selects the DAC Anti-Pop capacitor. Possible values are + 0 thru 3, which corresponds to 100uF (default), 60uF, 20uF or 10uF. + $ref: "/schemas/types.yaml#/definitions/uint32" + enum: [0, 1, 2, 3] + + ktm,refclk: + description: | + Selects the reference clock used on the KT0913. Possible + values are 0 thru 9, which corresponds to 32.768kHz (default), + 6.5MHz, 7.6MHz, 12MHz, 13MHz, 15.2MHz, 19.2MHz, 24MHz, 26MHz, 38kHz. + $ref: "/schemas/types.yaml#/definitions/uint32" + enum: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9] + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + i2c { + kt0913: fm-am-tuner@35 { + compatible = "ktm,kt0913"; + reg = <0x35>; + ktm,anti-pop = <0x01>; + ktm,refclk = <0x00>; + }; + }; +...
Document bindings for the kt0913 AM/FM radio tuner. Signed-off-by: Santiago Hormazabal <santiagohssl@gmail.com> --- .../bindings/media/i2c/ktm,kt0913.yaml | 56 +++++++++++++++++++ 1 file changed, 56 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/ktm,kt0913.yaml