diff mbox series

[v2,2/2] dt-bindings: iio: adc: ti,ads7950 binding conversion

Message ID 20200830161154.3201-3-jic23@kernel.org
State Not Applicable, archived
Headers show
Series dt-bindings: yaml conversions of some simple ADC bindings. | expand

Checks

Context Check Description
robh/checkpatch warning total: 0 errors, 1 warnings, 65 lines checked
robh/dt-meta-schema success

Commit Message

Jonathan Cameron Aug. 30, 2020, 4:11 p.m. UTC
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Conversion from txt to yaml.  The binding documents that
as not all boards will make use of the ADC channels via a consumer
driver.  It does no harm however, so we will leave it as required.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: David Lechner <david@lechnology.com>
---

Changes:
* Fix patch description to make sense.
* Fix a supplies instead of supply.
* Add maximum value for spi-bus-frequency

 .../bindings/iio/adc/ti,ads7950.yaml          | 65 +++++++++++++++++++
 .../bindings/iio/adc/ti-ads7950.txt           | 23 -------
 2 files changed, 65 insertions(+), 23 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,ads7950.yaml
 delete mode 100644 Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt

Comments

David Lechner Aug. 31, 2020, 2:30 p.m. UTC | #1
On 8/30/20 11:11 AM, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Conversion from txt to yaml.  The binding documents that
> as not all boards will make use of the ADC channels via a consumer
> driver.  It does no harm however, so we will leave it as required.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: David Lechner <david@lechnology.com>
> ---

Reviewed-by: David Lechner <david@lechnology.com>
Rob Herring Sept. 14, 2020, 6:21 p.m. UTC | #2
On Sun, 30 Aug 2020 17:11:54 +0100, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Conversion from txt to yaml.  The binding documents that
> as not all boards will make use of the ADC channels via a consumer
> driver.  It does no harm however, so we will leave it as required.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: David Lechner <david@lechnology.com>
> ---
> 
> Changes:
> * Fix patch description to make sense.
> * Fix a supplies instead of supply.
> * Add maximum value for spi-bus-frequency
> 
>  .../bindings/iio/adc/ti,ads7950.yaml          | 65 +++++++++++++++++++
>  .../bindings/iio/adc/ti-ads7950.txt           | 23 -------
>  2 files changed, 65 insertions(+), 23 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,ads7950.yaml
>  delete mode 100644 Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt
> 

Reviewed-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads7950.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads7950.yaml
new file mode 100644
index 000000000000..5ab5027be97e
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/adc/ti,ads7950.yaml
@@ -0,0 +1,65 @@ 
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/adc/ti,ads7950.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments ADS7950 and similar ADCs
+
+maintainers:
+  - David Lechner <david@lechnology.com>
+
+description: |
+  Family of 4-16 channel, 8-12 bit ADCs with SPI interface.
+
+properties:
+  compatible:
+    enum:
+      - ti,ads7950
+      - ti,ads7951
+      - ti,ads7952
+      - ti,ads7953
+      - ti,ads7954
+      - ti,ads7955
+      - ti,ads7956
+      - ti,ads7957
+      - ti,ads7958
+      - ti,ads7959
+      - ti,ads7960
+      - ti,ads7961
+
+  reg:
+    maxItems: 1
+
+  spi-max-frequency:
+    maximum: 20000000
+
+  vref-supply:
+    description: Supplies the 2.5V or 5V reference voltage
+
+  "#io-channel-cells":
+    const: 1
+
+required:
+  - compatible
+  - reg
+  - vref-supply
+  - "#io-channel-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        adc@0 {
+            compatible = "ti,ads7957";
+            reg = <0>;
+            vref-supply = <&refin_supply>;
+            spi-max-frequency = <10000000>;
+            #io-channel-cells = <1>;
+        };
+    };
+...
diff --git a/Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt b/Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt
deleted file mode 100644
index e77a6f7e1001..000000000000
--- a/Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt
+++ /dev/null
@@ -1,23 +0,0 @@ 
-* Texas Instruments ADS7950 family of A/DC chips
-
-Required properties:
- - compatible: Must be one of "ti,ads7950", "ti,ads7951", "ti,ads7952",
-   "ti,ads7953", "ti,ads7954", "ti,ads7955", "ti,ads7956", "ti,ads7957",
-   "ti,ads7958", "ti,ads7959", "ti,ads7960", or "ti,ads7961"
- - reg: SPI chip select number for the device
- - #io-channel-cells: Must be 1 as per ../iio-bindings.txt
- - vref-supply: phandle to a regulator node that supplies the 2.5V or 5V
-   reference voltage
-
-Recommended properties:
- - spi-max-frequency: Definition as per
-		Documentation/devicetree/bindings/spi/spi-bus.txt
-
-Example:
-adc@0 {
-	compatible = "ti,ads7957";
-	reg = <0>;
-	#io-channel-cells = <1>;
-	vref-supply = <&refin_supply>;
-	spi-max-frequency = <10000000>;
-};