| Message ID | 20200828192037.22897-1-krzk@kernel.org |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [1/4] dt-bindings: mtd: nand-controller: Fix matching with size-cells==1 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success |
On Fri, Aug 28, 2020 at 09:20:35PM +0200, Krzysztof Kozlowski wrote: > Device tree schema expects NAND controller to be named > "nand-controller", otherwise dtbs_check complain with a warning like: > > arch/arm/boot/dts/imx28-eukrea-mbmx283lc.dt.yaml: gpmi-nand@8000c000: > $nodename:0: 'gpmi-nand@8000c000' does not match '^nand-controller(@.*)?' > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> I already applied one patch from Anson [1]. Shawn [1] https://lkml.org/lkml/2020/7/30/610
diff --git a/Documentation/devicetree/bindings/mtd/nand-controller.yaml b/Documentation/devicetree/bindings/mtd/nand-controller.yaml index 40fc5b0b2b8c..0879e1108837 100644 --- a/Documentation/devicetree/bindings/mtd/nand-controller.yaml +++ b/Documentation/devicetree/bindings/mtd/nand-controller.yaml @@ -34,7 +34,10 @@ properties: const: 1 "#size-cells": - const: 0 + description: + Depends on your controller. Put zero unless you need a mapping between CS + lines and dedicated memory regions. + enum: [0, 1] ranges: true
Most of Freescale/NXP GPMI device trees use size-cells==1 (even when actually not needed except few boards). This fixes dtbs_check warnings like: arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dt.yaml: nand-controller@33002000: #size-cells:0:0: 0 was expected Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- Documentation/devicetree/bindings/mtd/nand-controller.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)