| Message ID | 20200819124539.20239-1-geert+renesas@glider.be |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [v2] dt-bindings: net: renesas,ether: Improve schema validation | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success |
From: Geert Uytterhoeven <geert+renesas@glider.be> Date: Wed, 19 Aug 2020 14:45:39 +0200 > - Remove pinctrl consumer properties, as they are handled by core > dt-schema, > - Document missing properties, > - Document missing PHY child node, > - Add "additionalProperties: false". > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > Reviewed-by: Rob Herring <robh@kernel.org> > --- > v2: > - Add Reviewed-by. Who will take this patch or should it go via my networking tree? Thank you.
Hi David, On Wed, Aug 19, 2020 at 10:05 PM David Miller <davem@davemloft.net> wrote: > From: Geert Uytterhoeven <geert+renesas@glider.be> > Date: Wed, 19 Aug 2020 14:45:39 +0200 > > > - Remove pinctrl consumer properties, as they are handled by core > > dt-schema, > > - Document missing properties, > > - Document missing PHY child node, > > - Add "additionalProperties: false". > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Reviewed-by: Rob Herring <robh@kernel.org> > > --- > > v2: > > - Add Reviewed-by. > > Who will take this patch or should it go via my networking tree? Given Rob provided his tag, I think it should go through your networking tree. Thank you! Gr{oetje,eeting}s, Geert
On 8/19/20 3:45 PM, Geert Uytterhoeven wrote: > - Remove pinctrl consumer properties, as they are handled by core So you're removing them even from the example? > dt-schema, > - Document missing properties, > - Document missing PHY child node, > - Add "additionalProperties: false". > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > Reviewed-by: Rob Herring <robh@kernel.org> [...] Reviewed-by: Sergei Shtylyov <sergei.shtylyov@gmail.com> MBR, Sergei
Hi Sergei, On Thu, Aug 20, 2020 at 2:26 PM Sergei Shtylyov <sergei.shtylyov@gmail.com> wrote: > On 8/19/20 3:45 PM, Geert Uytterhoeven wrote: > > > - Remove pinctrl consumer properties, as they are handled by core > > So you're removing them even from the example? Yes, as they're completely generic. > > dt-schema, > > - Document missing properties, > > - Document missing PHY child node, > > - Add "additionalProperties: false". > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Reviewed-by: Rob Herring <robh@kernel.org> > [...] > > Reviewed-by: Sergei Shtylyov <sergei.shtylyov@gmail.com> Gr{oetje,eeting}s, Geert
From: Geert Uytterhoeven <geert+renesas@glider.be> Date: Wed, 19 Aug 2020 14:45:39 +0200 > - Remove pinctrl consumer properties, as they are handled by core > dt-schema, > - Document missing properties, > - Document missing PHY child node, > - Add "additionalProperties: false". > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > Reviewed-by: Rob Herring <robh@kernel.org> > --- > v2: > - Add Reviewed-by. Applied, thank you.
diff --git a/Documentation/devicetree/bindings/net/renesas,ether.yaml b/Documentation/devicetree/bindings/net/renesas,ether.yaml index 08678af5ed9364cd..8ce5ed8a58dd76e6 100644 --- a/Documentation/devicetree/bindings/net/renesas,ether.yaml +++ b/Documentation/devicetree/bindings/net/renesas,ether.yaml @@ -59,9 +59,15 @@ properties: clocks: maxItems: 1 - pinctrl-0: true + power-domains: + maxItems: 1 + + resets: + maxItems: 1 - pinctrl-names: true + phy-mode: true + + phy-handle: true renesas,no-ether-link: type: boolean @@ -74,6 +80,11 @@ properties: specify when the Ether LINK signal is active-low instead of normal active-high +patternProperties: + "^ethernet-phy@[0-9a-f]$": + type: object + $ref: ethernet-phy.yaml# + required: - compatible - reg @@ -83,7 +94,8 @@ required: - '#address-cells' - '#size-cells' - clocks - - pinctrl-0 + +additionalProperties: false examples: # Lager board @@ -99,8 +111,6 @@ examples: clocks = <&mstp8_clks R8A7790_CLK_ETHER>; phy-mode = "rmii"; phy-handle = <&phy1>; - pinctrl-0 = <ðer_pins>; - pinctrl-names = "default"; renesas,ether-link-active-low; #address-cells = <1>; #size-cells = <0>; @@ -109,7 +119,5 @@ examples: reg = <1>; interrupt-parent = <&irqc0>; interrupts = <0 IRQ_TYPE_LEVEL_LOW>; - pinctrl-0 = <&phy1_pins>; - pinctrl-names = "default"; }; };
- Remove pinctrl consumer properties, as they are handled by core dt-schema, - Document missing properties, - Document missing PHY child node, - Add "additionalProperties: false". Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Rob Herring <robh@kernel.org> --- v2: - Add Reviewed-by. --- .../bindings/net/renesas,ether.yaml | 22 +++++++++++++------ 1 file changed, 15 insertions(+), 7 deletions(-)