diff mbox series

[v5,3/3] dt-bindings: arm: fsl: Add the librem 5 phone

Message ID 20200731082725.21878-3-martin.kepplinger@puri.sm
State Not Applicable
Headers show
Series None | expand

Checks

Context Check Description
robh/dt-meta-schema success
robh/checkpatch warning total: 0 errors, 1 warnings, 8 lines checked

Commit Message

Martin Kepplinger July 31, 2020, 8:27 a.m. UTC
Add entries for the imx8mq based Librem 5 phone. The "Birch" and
"Chestnut" hardware revisions are supported by r2. The "Dogwood"
revision by r3.
See https://puri.sm/products/librem-5/ and https://developer.puri.sm/Librem5/
for the schematics and more information.

Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Rob Herring July 31, 2020, 7:35 p.m. UTC | #1
On Fri, 31 Jul 2020 10:27:25 +0200, Martin Kepplinger wrote:
> Add entries for the imx8mq based Librem 5 phone. The "Birch" and
> "Chestnut" hardware revisions are supported by r2. The "Dogwood"
> revision by r3.
> See https://puri.sm/products/librem-5/ and https://developer.puri.sm/Librem5/
> for the schematics and more information.
> 
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 


Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.

If a tag was not added on purpose, please state why and what changed.
Martin Kepplinger Aug. 1, 2020, 10:56 a.m. UTC | #2
On 31.07.20 21:35, Rob Herring wrote:
> On Fri, 31 Jul 2020 10:27:25 +0200, Martin Kepplinger wrote:
>> Add entries for the imx8mq based Librem 5 phone. The "Birch" and
>> "Chestnut" hardware revisions are supported by r2. The "Dogwood"
>> revision by r3.
>> See https://puri.sm/products/librem-5/ and https://developer.puri.sm/Librem5/
>> for the schematics and more information.
>>
>> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
>> ---
>>  Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++
>>  1 file changed, 2 insertions(+)
>>
> 
> 
> Please add Acked-by/Reviewed-by tags when posting new versions. However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.
> 
> If a tag was not added on purpose, please state why and what changed.
> 

I'm very sorry. I forgot to add to this patch:

Acked-by: Rob Herring <robh@kernel.org>

It was not done on purposes and I'll add it to a next series and equally
hope that this note would make a maintainer add it in case this series
turns out to be ready.

thanks for the explanation and again, sorry.

                           martin
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index f63895c8ce2d..1cce4ff58ff8 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -365,6 +365,8 @@  properties:
               - fsl,imx8mq-evk            # i.MX8MQ EVK Board
               - google,imx8mq-phanbell    # Google Coral Edge TPU
               - purism,librem5-devkit     # Purism Librem5 devkit
+              - purism,librem5r2          # Purism Librem5 phone "Chestnut"
+              - purism,librem5r3          # Purism Librem5 phone "Dogwood"
               - solidrun,hummingboard-pulse # SolidRun Hummingboard Pulse
               - technexion,pico-pi-imx8m  # TechNexion PICO-PI-8M evk
           - const: fsl,imx8mq