diff mbox series

[v4,2/3] dt-bindings: arm: stm32: document Odyssey compatible

Message ID 20200723193737.190291-2-marcin.sloniewski@gmail.com
State Not Applicable, archived
Headers show
Series [v4,1/3] dt-bindings: vendor-prefixes: add Seeed Studio | expand

Checks

Context Check Description
robh/checkpatch success
robh/dt-meta-schema success

Commit Message

Marcin Sloniewski July 23, 2020, 7:37 p.m. UTC
Document device tree bindings of Seeed SoM and carrier board.

Signed-off-by: Marcin Sloniewski <marcin.sloniewski@gmail.com>
Acked-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Ahmad Fatoum July 24, 2020, 9:20 a.m. UTC | #1
Hi,

On 7/23/20 9:37 PM, Marcin Sloniewski wrote:
> Document device tree bindings of Seeed SoM and carrier board.
> 
> Signed-off-by: Marcin Sloniewski <marcin.sloniewski@gmail.com>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
>  Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> index 790e6dd48e34..22b9aaa75eee 100644
> --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> @@ -39,6 +39,8 @@ properties:
>            - enum:
>                - arrow,stm32mp157a-avenger96 # Avenger96
>                - lxa,stm32mp157c-mc1
> +              - seeed,stm32mp157c-odyssey
> +              - seeed,stm32mp157c-odyssey-som

Did you run dtbs_check over it? I think this should fail.

You want something like:

# Odyssey SoM boards
- items:
  - enum:
     - seeed,stm32mp157c-odyssey
  - const: seeed,stm32mp157c-odyssey-som
  - const: st,stm32mp157

(Note 3 items vs 2 in yours)

>                - shiratech,stm32mp157a-iot-box # IoT Box
>                - shiratech,stm32mp157a-stinger96 # Stinger96
>                - st,stm32mp157c-ed1
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
index 790e6dd48e34..22b9aaa75eee 100644
--- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
+++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
@@ -39,6 +39,8 @@  properties:
           - enum:
               - arrow,stm32mp157a-avenger96 # Avenger96
               - lxa,stm32mp157c-mc1
+              - seeed,stm32mp157c-odyssey
+              - seeed,stm32mp157c-odyssey-som
               - shiratech,stm32mp157a-iot-box # IoT Box
               - shiratech,stm32mp157a-stinger96 # Stinger96
               - st,stm32mp157c-ed1