| Message ID | 20200722055816.20768-2-sumit.semwal@linaro.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add support for Tianma nt36672a video mode panel | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 1 errors, 1 warnings, 104 lines checked |
| robh/dt-meta-schema | success |
On Wed, Jul 22, 2020 at 11:28:15AM +0530, Sumit Semwal wrote: > The nt36672a panel from Tianma is a FHD+ panel with a resolution of 1080x2246 > and 6.18 inches size. It is found in some of the Poco F1 phones. > > Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org> > Change-Id: I401dfbfe23ff2d806c956002f45e349cb9688c16 You know better... > --- > v2: remove ports node, making port@0 directly under panel@0 node. > --- > .../display/panel/tianma,nt36672a.yaml | 104 ++++++++++++++++++ > 1 file changed, 104 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/tianma,nt36672a.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/tianma,nt36672a.yaml b/Documentation/devicetree/bindings/display/panel/tianma,nt36672a.yaml > new file mode 100644 > index 000000000000..cb1799fbbd32 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/tianma,nt36672a.yaml > @@ -0,0 +1,104 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/tianma,nt36672a.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Tianma model NT36672A DSI Panel display driver > + > +maintainers: > + - Sumit Semwal <sumit.semwal@linaro.org> > + > +description: | > + The nt36672a panel from Tianma is a FHD+ LCD display panel with a resolution > + of 1080x2246. It is a video mode DSI panel. > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: tianma,nt36672a > + > + reg: > + description: DSI virtual channel of the peripheral > + > + reset-gpios: > + description: phandle of gpio for reset line - This should be 8mA, gpio > + can be configured using mux, pinctrl, pinctrl-names (active high) > + > + vddio-supply: > + description: phandle of the regulator that provides the supply voltage > + Power IC supply > + > + vddpos-supply: > + description: phandle of the positive boost supply regulator > + > + vddneg-supply: > + description: phandle of the negative boost supply regulator > + > + pinctrl-names: > + description: Pinctrl for panel active and suspend > + > + pinctrl-0: > + description: Active pinctrls > + > + pinctrl-1: > + description: Suspend pinctrls > + > + port@0: Just 'port' as there can only be 1 in this case. You can do just: 'port: true' as panel-common.yaml already has a definition. > + type: object > + description: DSI input port driven by master DSI > + properties: > + reg: > + const: 0 > + > + required: > + - reg > + > +required: > + - compatible > + - reg > + - vddi0-supply > + - vddpos-supply > + - vddneg-supply > + - reset-gpios > + - pinctrl-names > + - pinctrl-0 > + - pinctrl-1 > + - port@0 > + > +unevaluatedProperties: false > + > +examples: > + - |+ > + #include <dt-bindings/gpio/gpio.h> > + dsi0 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + panel@0 { > + compatible = "tianma,nt36672a"; > + reg = <0>; > + vddi0-supply = <&vreg_l14a_1p88>; > + vddpos-supply = <&lab>; > + vddneg-supply = <&ibb>; > + > + reset-gpios = <&tlmm 6 GPIO_ACTIVE_HIGH>; > + > + pinctrl-names = "panel_active", "panel_suspend"; > + pinctrl-0 = <&sde_dsi_active>; > + pinctrl-1 = <&sde_dsi_suspend>; > + > + #address-cells = <1>; > + #size-cells = <0>; > + port@0 { > + reg = <0>; > + tianma_nt36672a_in_0: endpoint { > + remote-endpoint = <&dsi0_out>; > + }; > + }; > + }; > + }; > + > +... > -- > 2.27.0 >
Hi Rob, Thanks for the review! On Thu, 23 Jul 2020 at 23:25, Rob Herring <robh@kernel.org> wrote: > > On Wed, Jul 22, 2020 at 11:28:15AM +0530, Sumit Semwal wrote: > > The nt36672a panel from Tianma is a FHD+ panel with a resolution of 1080x2246 > > and 6.18 inches size. It is found in some of the Poco F1 phones. > > > > Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org> > > Change-Id: I401dfbfe23ff2d806c956002f45e349cb9688c16 > > You know better... Yes - Sorry :( - will correct. > > > --- > > v2: remove ports node, making port@0 directly under panel@0 node. > > --- > > .../display/panel/tianma,nt36672a.yaml | 104 ++++++++++++++++++ > > 1 file changed, 104 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/panel/tianma,nt36672a.yaml > > > > diff --git a/Documentation/devicetree/bindings/display/panel/tianma,nt36672a.yaml b/Documentation/devicetree/bindings/display/panel/tianma,nt36672a.yaml > > new file mode 100644 > > index 000000000000..cb1799fbbd32 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/panel/tianma,nt36672a.yaml > > @@ -0,0 +1,104 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/panel/tianma,nt36672a.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Tianma model NT36672A DSI Panel display driver > > + > > +maintainers: > > + - Sumit Semwal <sumit.semwal@linaro.org> > > + > > +description: | > > + The nt36672a panel from Tianma is a FHD+ LCD display panel with a resolution > > + of 1080x2246. It is a video mode DSI panel. > > + > > +allOf: > > + - $ref: panel-common.yaml# > > + > > +properties: > > + compatible: > > + const: tianma,nt36672a > > + > > + reg: > > + description: DSI virtual channel of the peripheral > > + > > + reset-gpios: > > + description: phandle of gpio for reset line - This should be 8mA, gpio > > + can be configured using mux, pinctrl, pinctrl-names (active high) > > + > > + vddio-supply: > > + description: phandle of the regulator that provides the supply voltage > > + Power IC supply > > + > > + vddpos-supply: > > + description: phandle of the positive boost supply regulator > > + > > + vddneg-supply: > > + description: phandle of the negative boost supply regulator > > + > > + pinctrl-names: > > + description: Pinctrl for panel active and suspend > > + > > + pinctrl-0: > > + description: Active pinctrls > > + > > + pinctrl-1: > > + description: Suspend pinctrls > > + > > + port@0: > > Just 'port' as there can only be 1 in this case. > > You can do just: 'port: true' as panel-common.yaml already has a > definition. Ok, let me try that and send out v3. > > > + type: object > > + description: DSI input port driven by master DSI > > + properties: > > + reg: > > + const: 0 > > + > > + required: > > + - reg > > + > > +required: > > + - compatible > > + - reg > > + - vddi0-supply > > + - vddpos-supply > > + - vddneg-supply > > + - reset-gpios > > + - pinctrl-names > > + - pinctrl-0 > > + - pinctrl-1 > > + - port@0 > > + > > +unevaluatedProperties: false > > + > > +examples: > > + - |+ > > + #include <dt-bindings/gpio/gpio.h> > > + dsi0 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + panel@0 { > > + compatible = "tianma,nt36672a"; > > + reg = <0>; > > + vddi0-supply = <&vreg_l14a_1p88>; > > + vddpos-supply = <&lab>; > > + vddneg-supply = <&ibb>; > > + > > + reset-gpios = <&tlmm 6 GPIO_ACTIVE_HIGH>; > > + > > + pinctrl-names = "panel_active", "panel_suspend"; > > + pinctrl-0 = <&sde_dsi_active>; > > + pinctrl-1 = <&sde_dsi_suspend>; > > + > > + #address-cells = <1>; > > + #size-cells = <0>; > > + port@0 { > > + reg = <0>; > > + tianma_nt36672a_in_0: endpoint { > > + remote-endpoint = <&dsi0_out>; > > + }; > > + }; > > + }; > > + }; > > + > > +... > > -- > > 2.27.0 > > > Best, Sumit.
diff --git a/Documentation/devicetree/bindings/display/panel/tianma,nt36672a.yaml b/Documentation/devicetree/bindings/display/panel/tianma,nt36672a.yaml new file mode 100644 index 000000000000..cb1799fbbd32 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/tianma,nt36672a.yaml @@ -0,0 +1,104 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/tianma,nt36672a.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Tianma model NT36672A DSI Panel display driver + +maintainers: + - Sumit Semwal <sumit.semwal@linaro.org> + +description: | + The nt36672a panel from Tianma is a FHD+ LCD display panel with a resolution + of 1080x2246. It is a video mode DSI panel. + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + const: tianma,nt36672a + + reg: + description: DSI virtual channel of the peripheral + + reset-gpios: + description: phandle of gpio for reset line - This should be 8mA, gpio + can be configured using mux, pinctrl, pinctrl-names (active high) + + vddio-supply: + description: phandle of the regulator that provides the supply voltage + Power IC supply + + vddpos-supply: + description: phandle of the positive boost supply regulator + + vddneg-supply: + description: phandle of the negative boost supply regulator + + pinctrl-names: + description: Pinctrl for panel active and suspend + + pinctrl-0: + description: Active pinctrls + + pinctrl-1: + description: Suspend pinctrls + + port@0: + type: object + description: DSI input port driven by master DSI + properties: + reg: + const: 0 + + required: + - reg + +required: + - compatible + - reg + - vddi0-supply + - vddpos-supply + - vddneg-supply + - reset-gpios + - pinctrl-names + - pinctrl-0 + - pinctrl-1 + - port@0 + +unevaluatedProperties: false + +examples: + - |+ + #include <dt-bindings/gpio/gpio.h> + dsi0 { + #address-cells = <1>; + #size-cells = <0>; + + panel@0 { + compatible = "tianma,nt36672a"; + reg = <0>; + vddi0-supply = <&vreg_l14a_1p88>; + vddpos-supply = <&lab>; + vddneg-supply = <&ibb>; + + reset-gpios = <&tlmm 6 GPIO_ACTIVE_HIGH>; + + pinctrl-names = "panel_active", "panel_suspend"; + pinctrl-0 = <&sde_dsi_active>; + pinctrl-1 = <&sde_dsi_suspend>; + + #address-cells = <1>; + #size-cells = <0>; + port@0 { + reg = <0>; + tianma_nt36672a_in_0: endpoint { + remote-endpoint = <&dsi0_out>; + }; + }; + }; + }; + +...
The nt36672a panel from Tianma is a FHD+ panel with a resolution of 1080x2246 and 6.18 inches size. It is found in some of the Poco F1 phones. Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org> Change-Id: I401dfbfe23ff2d806c956002f45e349cb9688c16 --- v2: remove ports node, making port@0 directly under panel@0 node. --- .../display/panel/tianma,nt36672a.yaml | 104 ++++++++++++++++++ 1 file changed, 104 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/tianma,nt36672a.yaml