diff mbox series

[V2,2/2] dt-bindings: arm: renesas: Document beacon-rzg2m

Message ID 20200714123419.3390-2-aford173@gmail.com
State Not Applicable
Headers show
Series None | expand

Checks

Context Check Description
robh/dt-meta-schema success
robh/checkpatch success

Commit Message

Adam Ford July 14, 2020, 12:34 p.m. UTC
Beacon EmbeddedWorks in introducing a development kit based on the
Renesas RZ/G2M platform.  This patch adds the entry to the bindings
list.

Signed-off-by: Adam Ford <aford173@gmail.com>
---
V2:	New to series

Comments

Sergei Shtylyov July 15, 2020, 8:16 a.m. UTC | #1
Hello!

On 14.07.2020 15:34, Adam Ford wrote:

> Beacon EmbeddedWorks in introducing a development kit based on the

    s/in/is/?

> Renesas RZ/G2M platform.  This patch adds the entry to the bindings
> list.
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> ---
> V2:	New to series
> 
> diff --git a/Documentation/devicetree/bindings/arm/renesas.yaml b/Documentation/devicetree/bindings/arm/renesas.yaml
> index d8fd25bccbf5..0d4dabb4a164 100644
> --- a/Documentation/devicetree/bindings/arm/renesas.yaml
> +++ b/Documentation/devicetree/bindings/arm/renesas.yaml
> @@ -118,6 +118,7 @@ properties:
>           items:
>             - enum:
>                 - hoperun,hihope-rzg2m # HopeRun HiHope RZ/G2M platform
> +              - beacon,beacon-rzg2m # Beacon EmbeddedWorks RZ/G2M Kit

    Why the vendor-prefixes.yaml file calls it Compass Electronics Group?

[...]

MBR, Sergei
Geert Uytterhoeven July 15, 2020, 8:32 a.m. UTC | #2
Hi Sergei,

On Wed, Jul 15, 2020 at 10:16 AM Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> On 14.07.2020 15:34, Adam Ford wrote:
> > Beacon EmbeddedWorks in introducing a development kit based on the
> > Renesas RZ/G2M platform.  This patch adds the entry to the bindings
> > list.
> >
> > Signed-off-by: Adam Ford <aford173@gmail.com>

> > --- a/Documentation/devicetree/bindings/arm/renesas.yaml
> > +++ b/Documentation/devicetree/bindings/arm/renesas.yaml
> > @@ -118,6 +118,7 @@ properties:
> >           items:
> >             - enum:
> >                 - hoperun,hihope-rzg2m # HopeRun HiHope RZ/G2M platform
> > +              - beacon,beacon-rzg2m # Beacon EmbeddedWorks RZ/G2M Kit
>
>     Why the vendor-prefixes.yaml file calls it Compass Electronics Group?

See commit f756619f26edf74a ("dt-bindings: vendor-prefixes: Add Beacon
vendor prefix"):

    Beacon EmebeddedWorks is the brand owned by Compass Electronics Group,
    LLC based out of the United States.

Gr{oetje,eeting}s,

                        Geert
Geert Uytterhoeven July 15, 2020, 8:58 a.m. UTC | #3
On Tue, Jul 14, 2020 at 2:34 PM Adam Ford <aford173@gmail.com> wrote:
> Beacon EmbeddedWorks in introducing a development kit based on the
> Renesas RZ/G2M platform.  This patch adds the entry to the bindings
> list.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v5.9, with the typo pointed out
by Sergei fixed.

Gr{oetje,eeting}s,

                        Geert
Adam Ford July 15, 2020, 1:27 p.m. UTC | #4
On Wed, Jul 15, 2020 at 3:58 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> On Tue, Jul 14, 2020 at 2:34 PM Adam Ford <aford173@gmail.com> wrote:
> > Beacon EmbeddedWorks in introducing a development kit based on the
> > Renesas RZ/G2M platform.  This patch adds the entry to the bindings
> > list.
> >
> > Signed-off-by: Adam Ford <aford173@gmail.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> i.e. will queue in renesas-devel for v5.9, with the typo pointed out
> by Sergei fixed.

Since you pointed out some stuff I should correct in patch 1/2.
Should I just re-submit the first patch by itself, or do you want me
to submit 2/2 with these fixes?

adam

>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
Geert Uytterhoeven July 15, 2020, 1:37 p.m. UTC | #5
Hi Adam,

On Wed, Jul 15, 2020 at 3:27 PM Adam Ford <aford173@gmail.com> wrote:
> On Wed, Jul 15, 2020 at 3:58 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Tue, Jul 14, 2020 at 2:34 PM Adam Ford <aford173@gmail.com> wrote:
> > > Beacon EmbeddedWorks in introducing a development kit based on the
> > > Renesas RZ/G2M platform.  This patch adds the entry to the bindings
> > > list.
> > >
> > > Signed-off-by: Adam Ford <aford173@gmail.com>
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > i.e. will queue in renesas-devel for v5.9, with the typo pointed out
> > by Sergei fixed.
>
> Since you pointed out some stuff I should correct in patch 1/2.
> Should I just re-submit the first patch by itself, or do you want me
> to submit 2/2 with these fixes?

Just resubmitting the first patch is fine for me.

Gr{oetje,eeting}s,

                        Geert
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/renesas.yaml b/Documentation/devicetree/bindings/arm/renesas.yaml
index d8fd25bccbf5..0d4dabb4a164 100644
--- a/Documentation/devicetree/bindings/arm/renesas.yaml
+++ b/Documentation/devicetree/bindings/arm/renesas.yaml
@@ -118,6 +118,7 @@  properties:
         items:
           - enum:
               - hoperun,hihope-rzg2m # HopeRun HiHope RZ/G2M platform
+              - beacon,beacon-rzg2m # Beacon EmbeddedWorks RZ/G2M Kit
           - const: renesas,r8a774a1
 
       - items: