| Message ID | 20200709105902.23165-1-peter.chen@nxp.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [1/4] doc: dt-binding: ci-hdrc-usb2: add property for imx picophy | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Thu, Jul 09, 2020 at 06:58:59PM +0800, Peter Chen wrote: > Add two parameters which are used to tune USB signal for imx picophy, > picophy is used at imx7d, imx8mm, and imx8mn. > > Reviewed-by: Jun Li <jun.li@nxp.com> > Signed-off-by: Peter Chen <peter.chen@nxp.com> > --- > Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt > index 51376cbe5f3d..e9858dafb08f 100644 > --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt > @@ -100,6 +100,13 @@ i.mx specific properties > It's recommended to specify the over current polarity. > - power-active-high: power signal polarity is active high > - external-vbus-divider: enables off-chip resistor divider for Vbus > +- picophy,pre-emp-curr-control: HS Transmitter Pre-Emphasis Current 'picophy' should be documented in vendor-prefixes.yaml? Shawn > + Control. This signal controls the amount of current sourced to the > + USB_OTG*_DP and USB_OTG*_DN pins after a J-to-K or K-to-J transition. > + Details can refer to TXPREEMPAMPTUNE0 bits of USBNC_n_PHY_CFG1. > +- picophy,dc-vol-level-adjust: HS DC Voltage Level Adjustment. > + Adjust the high-speed transmitter DC level voltage, details can refer > + to TXVREFTUNE0 bits of USBNC_n_PHY_CFG1. > > Example: > > -- > 2.17.1 >
On Thu, Jul 09, 2020 at 06:59:01PM +0800, Peter Chen wrote: > With these two parameters tuning, it can pass USB eye diagram at evk board. > > Reviewed-by: Jun Li <jun.li@nxp.com> > Signed-off-by: Peter Chen <peter.chen@nxp.com> It's not so consistent, but idiomatically we prefix arm i.MX platform/dts patches like 'ARM: ...', but 'arm64: ...' for arm64 ones. Also with 'imx8mm-evk' in prefix, it's good enough to know this is fsl/imx patch, so I suggest prefix like: 'arm64: dts: imx8mm-evk: ...' Shawn > --- > arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts > index 0f1d7f8aeac4..c432b628e1ed 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts > @@ -324,6 +324,8 @@ > srp-disable; > adp-disable; > usb-role-switch; > + picophy,pre-emp-curr-control = <3>; > + picophy,dc-vol-level-adjust = <7>; > status = "okay"; > > port { > -- > 2.17.1 >
> > --- > > Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt > > b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt > > index 51376cbe5f3d..e9858dafb08f 100644 > > --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt > > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt > > @@ -100,6 +100,13 @@ i.mx specific properties > > It's recommended to specify the over current polarity. > > - power-active-high: power signal polarity is active high > > - external-vbus-divider: enables off-chip resistor divider for Vbus > > +- picophy,pre-emp-curr-control: HS Transmitter Pre-Emphasis Current > > 'picophy' should be documented in vendor-prefixes.yaml? > For chipidea binding doc, there is no vendor specific doc, only there are vendor specific parts in general binding doc. Peter > Shawn > > > + Control. This signal controls the amount of current sourced to the > > + USB_OTG*_DP and USB_OTG*_DN pins after a J-to-K or K-to-J transition. > > + Details can refer to TXPREEMPAMPTUNE0 bits of USBNC_n_PHY_CFG1. > > +- picophy,dc-vol-level-adjust: HS DC Voltage Level Adjustment. > > + Adjust the high-speed transmitter DC level voltage, details can > > +refer > > + to TXVREFTUNE0 bits of USBNC_n_PHY_CFG1. > > > > Example: > > > > -- > > 2.17.1 > >
> > Reviewed-by: Jun Li <jun.li@nxp.com> > > Signed-off-by: Peter Chen <peter.chen@nxp.com> > > It's not so consistent, but idiomatically we prefix arm i.MX platform/dts patches like > 'ARM: ...', but 'arm64: ...' for arm64 ones. > Also with 'imx8mm-evk' in prefix, it's good enough to know this is fsl/imx patch, so I > suggest prefix like: > > 'arm64: dts: imx8mm-evk: ...' > Thanks, will change. Peter
diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt index 51376cbe5f3d..e9858dafb08f 100644 --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt @@ -100,6 +100,13 @@ i.mx specific properties It's recommended to specify the over current polarity. - power-active-high: power signal polarity is active high - external-vbus-divider: enables off-chip resistor divider for Vbus +- picophy,pre-emp-curr-control: HS Transmitter Pre-Emphasis Current + Control. This signal controls the amount of current sourced to the + USB_OTG*_DP and USB_OTG*_DN pins after a J-to-K or K-to-J transition. + Details can refer to TXPREEMPAMPTUNE0 bits of USBNC_n_PHY_CFG1. +- picophy,dc-vol-level-adjust: HS DC Voltage Level Adjustment. + Adjust the high-speed transmitter DC level voltage, details can refer + to TXVREFTUNE0 bits of USBNC_n_PHY_CFG1. Example: