From patchwork Fri Jun 26 11:54:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 1317598 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=cerno.tech Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=cerno.tech header.i=@cerno.tech header.a=rsa-sha256 header.s=fm3 header.b=k4vnjeMY; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=sxV2YTMI; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49tb0J4cp6z9sPF for ; Fri, 26 Jun 2020 21:54:40 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727050AbgFZLyi (ORCPT ); Fri, 26 Jun 2020 07:54:38 -0400 Received: from new1-smtp.messagingengine.com ([66.111.4.221]:33207 "EHLO new1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726827AbgFZLyi (ORCPT ); Fri, 26 Jun 2020 07:54:38 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id 4CF7C5801B6; Fri, 26 Jun 2020 07:54:37 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 26 Jun 2020 07:54:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=fm3; bh=CkLtbfFWIfT0uZIIIKCd07Py1c VQSEqZLsxH7fb1Qmk=; b=k4vnjeMYWR7vbNumRJnTd/Ovj+X0Q6lqrgPNM8AqL0 K87oJ9L0kWXL7J1kqyjBwHatrV8K6eKDnpg98rAoIkNbu+asHvGq56pPNF70Zepk 3RJ+lv+MQq8UtF1AEfFqGPduZ2F3KmGaoEsVbyBUZ5YQJHq0Fziz4E4p6dGzVbMR FfeQnWapZMcPf7X1qWnRZo2Hh0X7h0QFM//Tp8P04FzOjYm03AIHTgKC37oNGHNE BrDctaXAVBaI+JXjDkbMKp8MJSTI8S267E6ThMRxAD4UQYOpbjMqgDwV0Eit3Gy7 O6sXneICrLGFPiel+4tUlzK2rqE8EkHj7tJAHpKA8pow== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=CkLtbfFWIfT0uZIII KCd07Py1cVQSEqZLsxH7fb1Qmk=; b=sxV2YTMIwqleLcVjv2QqoFoHCvyCRoZpq tHnSqJ1MoE9mC765tRgwsZXjU4tHBHAd38M/98g+v68i68CRuEAQVrZV9VgDH3Ej GlyoEHW+dcFQ1VBq8mP/u2pPXvkkwFK5dEhUwROaZhPCiwFwYCQnGGulTdmPLt1x V/G9UI/HpQ7m2TCpNuefP8VRTsSErXdw21QVZPI61Caco4vnAWZK7V3w1mQMX3ck IHuHmhk/NhyvLmjq52TvtRU1ieScSL/X1DpDmy8H4zuBKYRSU26yi5hDTanDNm6p pVTmZeZf2SE5PhduaCzwkpr1fnOLv+TBs7ppQhHC8a2ww066kGXrA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudeluddggeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffoggfgsedtkeertdertddtnecuhfhrohhmpeforgigihhmvgcu tfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrthhtvg hrnhepjeffheduvddvvdelhfegleelfffgieejvdehgfeijedtieeuteejteefueekjeeg necukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 3BC25328005E; Fri, 26 Jun 2020 07:54:36 -0400 (EDT) From: Maxime Ripard To: Nicolas Saenz Julienne , Mike Turquette , Stephen Boyd Cc: linux-rpi-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-clk@vger.kernel.org, Mark Rutland , Rob Herring , Frank Rowand , devicetree@vger.kernel.org, Florian Fainelli , Maxime Ripard Subject: [PATCH] dt-bindings: arm: bcm: Add a select to the RPI Firmware binding Date: Fri, 26 Jun 2020 13:54:33 +0200 Message-Id: <20200626115433.125735-1-maxime@cerno.tech> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The RaspberryPi firmware binding uses two compatible, include simple-bus. The select statement generated by default will thus select any node that has simple-bus, not all of them being the raspberrypi firmware node. This results in warnings being wrongfully reported. Let's add a custom select statement to fix that. Fixes: 5bc0b9be8544 ("dt-bindings: arm: bcm: Convert BCM2835 firmware binding to YAML") Signed-off-by: Maxime Ripard Acked-by: Florian Fainelli Acked-by: Rob Herring --- The original binding has been merged through the clock tree, so it should be merged there. Even though the original binding (and the DT) are using the simple-bus compatible, this creates some DTC warnings since the firmware really isn't a bus, so the node name doesn't match what a bus should have, none of the children have a reg property, #address-cells and #size-cells are missing, etc. I can only guess that simple-bus was used to make the sub-devices probe, but maybe simple-mfd would be more appropriate here? --- .../bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml index b48ed875eb8e..17e4f20c8d39 100644 --- a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml +++ b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml @@ -10,6 +10,15 @@ maintainers: - Eric Anholt - Stefan Wahren +select: + properties: + compatible: + contains: + const: raspberrypi,bcm2835-firmware + + required: + - compatible + properties: compatible: items: