| Message ID | 20200622192558.152828-8-konradybcio@gmail.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Add support for Sony SDM630-based boards | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 2 warnings, 24 lines checked |
| robh/checkpatch | warning | total: 0 errors, 2 warnings, 24 lines checked |
| robh/dt-meta-schema | success | |
| robh/dt-meta-schema | success |
On Mon 22 Jun 12:25 PDT 2020, Konrad Dybcio wrote: > The Qualcomm SDM660 platform has a APCS HMSS GLOBAL block, add the > compatible for this. > > Signed-off-by: Konrad Dybcio <konradybcio@gmail.com> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn > --- > .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 1 + > drivers/mailbox/qcom-apcs-ipc-mailbox.c | 5 +++++ > 2 files changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > index 12eff942708d..b4501c6b5c6f 100644 > --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > @@ -22,6 +22,7 @@ properties: > - qcom,msm8998-apcs-hmss-global > - qcom,qcs404-apcs-apps-global > - qcom,sc7180-apss-shared > + - qcom,sdm660-apcs-hmss-global > - qcom,sdm845-apss-shared > - qcom,sm8150-apss-shared > > diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c > index cec34f0af6ce..ab0275869434 100644 > --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c > +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c > @@ -49,6 +49,10 @@ static const struct qcom_apcs_ipc_data msm8998_apcs_data = { > .offset = 8, .clk_name = NULL > }; > > +static const struct qcom_apcs_ipc_data sdm660_apcs_data = { > + .offset = 8, .clk_name = NULL > +}; > + > static const struct qcom_apcs_ipc_data apps_shared_apcs_data = { > .offset = 12, .clk_name = NULL > }; > @@ -150,6 +154,7 @@ static const struct of_device_id qcom_apcs_ipc_of_match[] = { > { .compatible = "qcom,msm8998-apcs-hmss-global", .data = &msm8998_apcs_data }, > { .compatible = "qcom,qcs404-apcs-apps-global", .data = &msm8916_apcs_data }, > { .compatible = "qcom,sc7180-apss-shared", .data = &apps_shared_apcs_data }, > + { .compatible = "qcom,sdm660-apcs-hmss-global", .data = &sdm660_apcs_data }, > { .compatible = "qcom,sdm845-apss-shared", .data = &apps_shared_apcs_data }, > { .compatible = "qcom,sm8150-apss-shared", .data = &apps_shared_apcs_data }, > {} > -- > 2.27.0 >
Tue, 23 Jun. 2020. 10:29, Bjorn Andersson <bjorn.andersson@linaro.org>: > > On Mon 22 Jun 12:25 PDT 2020, Konrad Dybcio wrote: > > > Signed-off-by: Konrad Dybcio <konradybcio@gmail.com> > > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > Hi, I can see dts file in linux-next using compatible "qcom,sdm660-apcs-hmss-global", but not this patch that adds it into the driver?
On Mon, 22 Jun 2020 21:25:57 +0200, Konrad Dybcio wrote: > The Qualcomm SDM660 platform has a APCS HMSS GLOBAL block, add the > compatible for this. > > Signed-off-by: Konrad Dybcio <konradybcio@gmail.com> > --- > .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 1 + > drivers/mailbox/qcom-apcs-ipc-mailbox.c | 5 +++++ > 2 files changed, 6 insertions(+) > Acked-by: Rob Herring <robh@kernel.org>
On Fri 26 Jun 08:48 PDT 2020, Alexey Minnekhanov wrote: > Tue, 23 Jun. 2020. 10:29, Bjorn Andersson <bjorn.andersson@linaro.org>: > > > > On Mon 22 Jun 12:25 PDT 2020, Konrad Dybcio wrote: > > > > > Signed-off-by: Konrad Dybcio <konradybcio@gmail.com> > > > > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > > > > Hi, I can see dts file in linux-next using compatible > "qcom,sdm660-apcs-hmss-global", > but not this patch that adds it into the driver? I take the dts patches through the Qualcomm tree, but the driver patch should go through the mailbox tree. Regards, Bjorn
diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml index 12eff942708d..b4501c6b5c6f 100644 --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml @@ -22,6 +22,7 @@ properties: - qcom,msm8998-apcs-hmss-global - qcom,qcs404-apcs-apps-global - qcom,sc7180-apss-shared + - qcom,sdm660-apcs-hmss-global - qcom,sdm845-apss-shared - qcom,sm8150-apss-shared diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c index cec34f0af6ce..ab0275869434 100644 --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c @@ -49,6 +49,10 @@ static const struct qcom_apcs_ipc_data msm8998_apcs_data = { .offset = 8, .clk_name = NULL }; +static const struct qcom_apcs_ipc_data sdm660_apcs_data = { + .offset = 8, .clk_name = NULL +}; + static const struct qcom_apcs_ipc_data apps_shared_apcs_data = { .offset = 12, .clk_name = NULL }; @@ -150,6 +154,7 @@ static const struct of_device_id qcom_apcs_ipc_of_match[] = { { .compatible = "qcom,msm8998-apcs-hmss-global", .data = &msm8998_apcs_data }, { .compatible = "qcom,qcs404-apcs-apps-global", .data = &msm8916_apcs_data }, { .compatible = "qcom,sc7180-apss-shared", .data = &apps_shared_apcs_data }, + { .compatible = "qcom,sdm660-apcs-hmss-global", .data = &sdm660_apcs_data }, { .compatible = "qcom,sdm845-apss-shared", .data = &apps_shared_apcs_data }, { .compatible = "qcom,sm8150-apss-shared", .data = &apps_shared_apcs_data }, {}
The Qualcomm SDM660 platform has a APCS HMSS GLOBAL block, add the compatible for this. Signed-off-by: Konrad Dybcio <konradybcio@gmail.com> --- .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 1 + drivers/mailbox/qcom-apcs-ipc-mailbox.c | 5 +++++ 2 files changed, 6 insertions(+)