| Message ID | 20200622025907.32574-4-frank@allwinnertech.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | Allwinner A100 Initial support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success |
Hi, On Mon, Jun 22, 2020 at 10:58:59AM +0800, Frank Lee wrote: > Add device tree binding Documentation details for A100 pinctrl driver, > whic has an r pin controller and a pin controller with more irq lines. > > Signed-off-by: Frank Lee <frank@allwinnertech.com> > --- > .../pinctrl/allwinner,sun4i-a10-pinctrl.yaml | 72 +++++++++++++--------- > 1 file changed, 43 insertions(+), 29 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml > index bfefd09..2ac5eb5 100644 > --- a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml > @@ -48,6 +48,8 @@ properties: > - allwinner,sun9i-a80-r-pinctrl > - allwinner,sun50i-a64-pinctrl > - allwinner,sun50i-a64-r-pinctrl > + - allwinner,sun50i-a100-pinctrl > + - allwinner,sun50i-a100-r-pinctrl > - allwinner,sun50i-h5-pinctrl > - allwinner,sun50i-h6-pinctrl > - allwinner,sun50i-h6-r-pinctrl > @@ -144,75 +146,87 @@ allOf: > # FIXME: We should have the pin bank supplies here, but not a lot of > # boards are defining it at the moment so it would generate a lot of > # warnings. > - > - if: > properties: > compatible: > enum: > - - allwinner,sun9i-a80-pinctrl > + - allwinner,sun50i-a100-pinctrl > > then: > properties: > interrupts: > - minItems: 5 > - maxItems: 5 > + minItems: 7 > + maxItems: 7 > > else: > if: > properties: > compatible: > enum: > - - allwinner,sun6i-a31-pinctrl > - - allwinner,sun6i-a31s-pinctrl > - - allwinner,sun50i-h6-pinctrl > + - allwinner,sun9i-a80-pinctrl The diff is a bit of a mess here. I guess you just added a new if with the A100 pinctrl compatible? Also, since it's a new SoC and we don't really have to care about the existing DT for boards, it would be great if you could make the gpio banks supplies required. Thanks! Maxime
diff --git a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml index bfefd09..2ac5eb5 100644 --- a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml @@ -48,6 +48,8 @@ properties: - allwinner,sun9i-a80-r-pinctrl - allwinner,sun50i-a64-pinctrl - allwinner,sun50i-a64-r-pinctrl + - allwinner,sun50i-a100-pinctrl + - allwinner,sun50i-a100-r-pinctrl - allwinner,sun50i-h5-pinctrl - allwinner,sun50i-h6-pinctrl - allwinner,sun50i-h6-r-pinctrl @@ -144,75 +146,87 @@ allOf: # FIXME: We should have the pin bank supplies here, but not a lot of # boards are defining it at the moment so it would generate a lot of # warnings. - - if: properties: compatible: enum: - - allwinner,sun9i-a80-pinctrl + - allwinner,sun50i-a100-pinctrl then: properties: interrupts: - minItems: 5 - maxItems: 5 + minItems: 7 + maxItems: 7 else: if: properties: compatible: enum: - - allwinner,sun6i-a31-pinctrl - - allwinner,sun6i-a31s-pinctrl - - allwinner,sun50i-h6-pinctrl + - allwinner,sun9i-a80-pinctrl then: properties: interrupts: - minItems: 4 - maxItems: 4 + minItems: 5 + maxItems: 5 else: if: properties: compatible: enum: - - allwinner,sun8i-a23-pinctrl - - allwinner,sun8i-a83t-pinctrl - - allwinner,sun50i-a64-pinctrl - - allwinner,sun50i-h5-pinctrl - - allwinner,suniv-f1c100s-pinctrl + - allwinner,sun6i-a31-pinctrl + - allwinner,sun6i-a31s-pinctrl + - allwinner,sun50i-h6-pinctrl then: properties: interrupts: - minItems: 3 - maxItems: 3 + minItems: 4 + maxItems: 4 else: if: properties: compatible: enum: - - allwinner,sun6i-a31-r-pinctrl - - allwinner,sun8i-a33-pinctrl - - allwinner,sun8i-h3-pinctrl - - allwinner,sun8i-v3-pinctrl - - allwinner,sun8i-v3s-pinctrl - - allwinner,sun9i-a80-r-pinctrl - - allwinner,sun50i-h6-r-pinctrl + - allwinner,sun8i-a23-pinctrl + - allwinner,sun8i-a83t-pinctrl + - allwinner,sun50i-a64-pinctrl + - allwinner,sun50i-h5-pinctrl + - allwinner,suniv-f1c100s-pinctrl then: properties: interrupts: - minItems: 2 - maxItems: 2 + minItems: 3 + maxItems: 3 else: - properties: - interrupts: - minItems: 1 - maxItems: 1 + if: + properties: + compatible: + enum: + - allwinner,sun6i-a31-r-pinctrl + - allwinner,sun8i-a33-pinctrl + - allwinner,sun8i-h3-pinctrl + - allwinner,sun8i-v3-pinctrl + - allwinner,sun8i-v3s-pinctrl + - allwinner,sun9i-a80-r-pinctrl + - allwinner,sun50i-h6-r-pinctrl + + then: + properties: + interrupts: + minItems: 2 + maxItems: 2 + + else: + properties: + interrupts: + minItems: 1 + maxItems: 1 additionalProperties: false
Add device tree binding Documentation details for A100 pinctrl driver, whic has an r pin controller and a pin controller with more irq lines. Signed-off-by: Frank Lee <frank@allwinnertech.com> --- .../pinctrl/allwinner,sun4i-a10-pinctrl.yaml | 72 +++++++++++++--------- 1 file changed, 43 insertions(+), 29 deletions(-)