diff mbox series

[net-next,v9,1/5] dt-bindings: net: Add tx and rx internal delays

Message ID 20200619161813.2716-2-dmurphy@ti.com
State Superseded
Headers show
Series RGMII Internal delay common property | expand

Checks

Context Check Description
robh/dt-meta-schema success
robh/checkpatch success

Commit Message

Dan Murphy June 19, 2020, 4:18 p.m. UTC
tx-internal-delays and rx-internal-delays are a common setting for RGMII
capable devices.

These properties are used when the phy-mode or phy-controller is set to
rgmii-id, rgmii-rxid or rgmii-txid.  These modes indicate to the
controller that the PHY will add the internal delay for the connection.

Signed-off-by: Dan Murphy <dmurphy@ti.com>
---
 .../devicetree/bindings/net/ethernet-phy.yaml       | 13 +++++++++++++
 1 file changed, 13 insertions(+)

Comments

David Miller June 22, 2020, 10:40 p.m. UTC | #1
From: Dan Murphy <dmurphy@ti.com>
Date: Fri, 19 Jun 2020 11:18:09 -0500

> @@ -162,6 +162,19 @@ properties:
>      description:
>        Specifies a reference to a node representing a SFP cage.
>  
> +
> +  rx-internal-delay-ps:

Do you really want two empty lines between these two sections?
Dan Murphy June 23, 2020, 1:18 a.m. UTC | #2
David

Thanks for the review

On 6/22/20 5:40 PM, David Miller wrote:
> From: Dan Murphy <dmurphy@ti.com>
> Date: Fri, 19 Jun 2020 11:18:09 -0500
>
>> @@ -162,6 +162,19 @@ properties:
>>       description:
>>         Specifies a reference to a node representing a SFP cage.
>>   
>> +
>> +  rx-internal-delay-ps:
> Do you really want two empty lines between these two sections?

No.  Will fix.

Dan
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/ethernet-phy.yaml b/Documentation/devicetree/bindings/net/ethernet-phy.yaml
index 9b1f1147ca36..7d8265eb49d6 100644
--- a/Documentation/devicetree/bindings/net/ethernet-phy.yaml
+++ b/Documentation/devicetree/bindings/net/ethernet-phy.yaml
@@ -162,6 +162,19 @@  properties:
     description:
       Specifies a reference to a node representing a SFP cage.
 
+
+  rx-internal-delay-ps:
+    description: |
+      RGMII Receive PHY Clock Delay defined in pico seconds.  This is used for
+      PHY's that have configurable RX internal delays.  If this property is
+      present then the PHY applies the RX delay.
+
+  tx-internal-delay-ps:
+    description: |
+      RGMII Transmit PHY Clock Delay defined in pico seconds.  This is used for
+      PHY's that have configurable TX internal delays. If this property is
+      present then the PHY applies the TX delay.
+
 required:
   - reg