| Message ID | 20200601145857.5658-1-parthiban@linumiz.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [v2,1/2] dt-bindings: arm: fsl: Add MYiR Tech boards | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success |
On Mon, Jun 01, 2020 at 04:58:56PM +0200, Parthiban Nallathambi wrote: > Add entries for MYiR Tech imx6ULL eval boards. > > Signed-off-by: Parthiban Nallathambi <parthiban@linumiz.com> > --- > Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > index cd3fbe7e3948..592d73187da4 100644 > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > @@ -264,6 +264,8 @@ properties: > - armadeus,imx6ull-opos6uldev # OPOS6UL (i.MX6ULL) SoM on OPOS6ULDev board > - fsl,imx6ull-14x14-evk # i.MX6 UltraLiteLite 14x14 EVK Board > - kontron,imx6ull-n6411-som # Kontron N6411 SOM > + - myir,imx6ull-mys-6ulx # MYiR Tech iMX6ULL Evaluation Board > + - myir,imx6ull-mys-6ulx-nand # MYiR Tech iMX6ULL Evaluation Board with NAND Can't you tell there is nand by the presence of a nand nodes? > - toradex,colibri-imx6ull-eval # Colibri iMX6ULL Module on Colibri Evaluation Board > - toradex,colibri-imx6ull-wifi-eval # Colibri iMX6ULL Wi-Fi / Bluetooth Module on Colibri Evaluation Board > - const: fsl,imx6ull > -- > 2.26.2 >
On Mon, Jun 01, 2020 at 04:58:57PM +0200, Parthiban Nallathambi wrote: > Add support for the MYiR imx6ULL based single board computer > equipped with on board 256MB NAND & RAM. The board also > provides expansion header for expansion board, but this > commit adds only support for SBC. > > Signed-off-by: Parthiban Nallathambi <parthiban@linumiz.com> > --- > > Notes: > Changelog v2: > - moved regulator under root node > - status property removed > > arch/arm/boot/dts/Makefile | 1 + > .../boot/dts/imx6ull-myir-mys-6ulx-nand.dts | 19 ++ > arch/arm/boot/dts/imx6ull-myir-mys-6ulx.dtsi | 238 ++++++++++++++++++ > 3 files changed, 258 insertions(+) > create mode 100644 arch/arm/boot/dts/imx6ull-myir-mys-6ulx-nand.dts > create mode 100644 arch/arm/boot/dts/imx6ull-myir-mys-6ulx.dtsi > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index e8dd99201397..eab86051d782 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -612,6 +612,7 @@ dtb-$(CONFIG_SOC_IMX6UL) += \ > imx6ull-14x14-evk.dtb \ > imx6ull-colibri-eval-v3.dtb \ > imx6ull-colibri-wifi-eval-v3.dtb \ > + imx6ull-myir-mys-6ulx-nand.dtb \ > imx6ull-opos6uldev.dtb \ > imx6ull-phytec-segin-ff-rdk-nand.dtb \ > imx6ull-phytec-segin-ff-rdk-emmc.dtb \ > diff --git a/arch/arm/boot/dts/imx6ull-myir-mys-6ulx-nand.dts b/arch/arm/boot/dts/imx6ull-myir-mys-6ulx-nand.dts > new file mode 100644 > index 000000000000..43e072671ca4 > --- /dev/null > +++ b/arch/arm/boot/dts/imx6ull-myir-mys-6ulx-nand.dts > @@ -0,0 +1,19 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2020 Linumiz > + * Author: Parthiban Nallathambi <parthiban@linumiz.com> > + */ > + > +/dts-v1/; > +#include "imx6ull.dtsi" > +#include "imx6ull-myir-mys-6ulx.dtsi" > + > +/ { > + model = "MYiR i.MX6ULL MYS-6ULX Single Board Computer with NAND"; > + compatible = "myir,imx6ull-mys-6ulx-nand", "myir,imx6ull-mys-6ulx", > + "fsl,imx6ull"; Doesn't match the schema which says you have either "myir,imx6ull-mys-6ulx-nand" or "myir,imx6ull-mys-6ulx". You ran this against 'make dtbs_check', right? > +}; > + > +&gpmi { > + status = "okay"; > +}; > diff --git a/arch/arm/boot/dts/imx6ull-myir-mys-6ulx.dtsi b/arch/arm/boot/dts/imx6ull-myir-mys-6ulx.dtsi > new file mode 100644 > index 000000000000..03365a1ca8e6 > --- /dev/null > +++ b/arch/arm/boot/dts/imx6ull-myir-mys-6ulx.dtsi If w/o nand is a valid board config, don't you want to build this (i.e. make it a .dts)? > @@ -0,0 +1,238 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2020 Linumiz > + * Author: Parthiban Nallathambi <parthiban@linumiz.com> > + */ > + > +#include <dt-bindings/gpio/gpio.h> > +#include <dt-bindings/interrupt-controller/irq.h> > +#include <dt-bindings/pwm/pwm.h>
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml index cd3fbe7e3948..592d73187da4 100644 --- a/Documentation/devicetree/bindings/arm/fsl.yaml +++ b/Documentation/devicetree/bindings/arm/fsl.yaml @@ -264,6 +264,8 @@ properties: - armadeus,imx6ull-opos6uldev # OPOS6UL (i.MX6ULL) SoM on OPOS6ULDev board - fsl,imx6ull-14x14-evk # i.MX6 UltraLiteLite 14x14 EVK Board - kontron,imx6ull-n6411-som # Kontron N6411 SOM + - myir,imx6ull-mys-6ulx # MYiR Tech iMX6ULL Evaluation Board + - myir,imx6ull-mys-6ulx-nand # MYiR Tech iMX6ULL Evaluation Board with NAND - toradex,colibri-imx6ull-eval # Colibri iMX6ULL Module on Colibri Evaluation Board - toradex,colibri-imx6ull-wifi-eval # Colibri iMX6ULL Wi-Fi / Bluetooth Module on Colibri Evaluation Board - const: fsl,imx6ull
Add entries for MYiR Tech imx6ULL eval boards. Signed-off-by: Parthiban Nallathambi <parthiban@linumiz.com> --- Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++ 1 file changed, 2 insertions(+)