| Message ID | 20200528154625.17742-3-sumit.semwal@linaro.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Qualcomm labibb regulator driver | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 63 lines checked |
| robh/dt-meta-schema | fail | build log |
On Thu, 28 May 2020 21:16:22 +0530, Sumit Semwal wrote: > From: Nisha Kumari <nishakumari@codeaurora.org> > > Adding the devicetree binding for labibb regulator. > > Signed-off-by: Nisha Kumari <nishakumari@codeaurora.org> > Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org> > > -- > v2: updated for better compatible string and names. > v3: moved to yaml > > --- > .../regulator/qcom-labibb-regulator.yaml | 63 +++++++++++++++++++ > 1 file changed, 63 insertions(+) > create mode 100644 Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml > My bot found errors running 'make dt_binding_check' on your patch: Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml: while scanning for the next token found character that cannot start any token in "<unicode string>", line 48, column 1 Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.example.dts' failed make[1]: *** [Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.example.dts] Error 1 make[1]: *** Waiting for unfinished jobs.... /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml: ignoring, error parsing file warning: no schema found in file: ./Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml: ignoring, error parsing file warning: no schema found in file: ./Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml Makefile:1300: recipe for target 'dt_binding_check' failed make: *** [dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1299916 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml new file mode 100644 index 000000000000..5406601ecd65 --- /dev/null +++ b/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml @@ -0,0 +1,63 @@ +# SPDX-License-Identifier: GPL-2.0-only +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/regulator/qcom-labibb-regulator.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm's LAB(LCD AMOLED Boost)/IBB(Inverting Buck Boost) Regulator + +maintainers: + - Sumit Semwal <sumit.semwal@linaro.org> + +description: + LAB can be used as a positive boost power supply and IBB can be used as a + negative boost power supply for display panels. Currently implemented for + pmi8998. + +allOf: + - $ref: "regulator.yaml#" + +properties: + compatible: + const: qcom,pmi8998-lab-ibb + + lab: + type: object + interrupts: + items: + - description: Short-circuit interrupt for lab. + interrupt-names: + maxItems: 1 + items: + - const: sc-err + + ibb: + type: object + interrupts: + items: + - description: Short-circuit interrupt for lab. + interrupt-names: + maxItems: 1 + items: + - const: sc-err + +required: + - compatible + +examples: + pmi8998_lsid1: pmic@3 { + labibb { + compatible = "qcom,pmi8998-lab-ibb"; + + lab: lab { + interrupts = <0x3 0xde 0x0 IRQ_TYPE_EDGE_RISING>; + interrupt-names = "lab-sc-err"; + }; + + ibb: ibb { + interrupts = <0x3 0xdc 0x2 IRQ_TYPE_EDGE_RISING>; + interrupt-names = "ibb-sc-err"; + }; + + }; + };