| Message ID | 20200519164425.9729-1-jbx6244@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | dt-bindings: gpu: arm,mali-utgard: add additional properties | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success |
Hi, Am Dienstag, 19. Mai 2020, 18:44:25 CEST schrieb Johan Jonker: > In the old txt situation we add/describe only properties that are used > by the driver/hardware itself. With yaml it also filters things in a > node that are used by other drivers like 'assigned-clocks' and > 'assigned-clock-rates' for some older Rockchip SoCs in 'gpu' nodes, > so add them to 'arm,mali-utgard.yaml'. though the other option would be to just get rid assigned-clocks in dt-node for utgard malis ;-) Like any good gpu, lima should just use frequency scaling to achieve suitable (fast <-> powersaving) frequencies and it looks like a set of patches for this was posted in december already [0]. So I guess one could expect opp-based scaling to land at some point. Heiko [0] https://lwn.net/Articles/807444/
diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml index 4869258da..2fc97c544 100644 --- a/Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml +++ b/Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml @@ -95,6 +95,12 @@ properties: - const: bus - const: core + assigned-clocks: + maxItems: 1 + + assigned-clock-rates: + maxItems: 1 + memory-region: true mali-supply: true
In the old txt situation we add/describe only properties that are used by the driver/hardware itself. With yaml it also filters things in a node that are used by other drivers like 'assigned-clocks' and 'assigned-clock-rates' for some older Rockchip SoCs in 'gpu' nodes, so add them to 'arm,mali-utgard.yaml'. Signed-off-by: Johan Jonker <jbx6244@gmail.com> --- Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml | 6 ++++++ 1 file changed, 6 insertions(+)