| Message ID | 20200505140231.16600-2-brgl@bgdev.pl |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [01/11] dt-bindings: add a binding document for MediaTek PERICFG controller | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success |
On Tue, May 05, 2020 at 04:02:21PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > This adds a binding document for the PERICFG controller present on > MediaTek SoCs. For now the only variant supported is 'mt8516-pericfg'. > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > --- > .../arm/mediatek/mediatek,pericfg.yaml | 34 +++++++++++++++++++ > 1 file changed, 34 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,pericfg.yaml > > diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,pericfg.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,pericfg.yaml > new file mode 100644 > index 000000000000..74b2a6173ffb > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,pericfg.yaml > @@ -0,0 +1,34 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/arm/mediatek/mediatek,pericfg.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: MediaTek Peripheral Configuration Controller > + > +maintainers: > + - Bartosz Golaszewski <bgolaszewski@baylibre.com> > + > +properties: > + compatible: > + oneOf: Don't need oneOf. > + - items: > + - enum: > + - mediatek,pericfg PERICFG is exactly the same register set and functions on all Mediatek SoCs? Needs to be more specific. > + - const: syscon > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + pericfg: pericfg@10003050 { > + compatible = "mediatek,mt8516-pericfg", "syscon"; > + reg = <0 0x10003050 0 0x1000>; Default for examples is 1 cell for addr and size. > + }; > -- > 2.25.0 >
śr., 13 maj 2020 o 04:38 Rob Herring <robh@kernel.org> napisał(a): > > On Tue, May 05, 2020 at 04:02:21PM +0200, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > This adds a binding document for the PERICFG controller present on > > MediaTek SoCs. For now the only variant supported is 'mt8516-pericfg'. > > > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > --- > > .../arm/mediatek/mediatek,pericfg.yaml | 34 +++++++++++++++++++ > > 1 file changed, 34 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,pericfg.yaml > > > > diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,pericfg.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,pericfg.yaml > > new file mode 100644 > > index 000000000000..74b2a6173ffb > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,pericfg.yaml > > @@ -0,0 +1,34 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: "http://devicetree.org/schemas/arm/mediatek/mediatek,pericfg.yaml#" > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > + > > +title: MediaTek Peripheral Configuration Controller > > + > > +maintainers: > > + - Bartosz Golaszewski <bgolaszewski@baylibre.com> > > + > > +properties: > > + compatible: > > + oneOf: > > Don't need oneOf. > > > + - items: > > + - enum: > > + - mediatek,pericfg > > PERICFG is exactly the same register set and functions on all Mediatek > SoCs? Needs to be more specific. > > > + - const: syscon > > + > > + reg: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + pericfg: pericfg@10003050 { > > + compatible = "mediatek,mt8516-pericfg", "syscon"; > > + reg = <0 0x10003050 0 0x1000>; > > Default for examples is 1 cell for addr and size. > > > + }; > > -- > > 2.25.0 > > Hi Rob, I somehow missed the fact that there already is an old-style txt binding document for pericfg. I'll first convert it and then add the new compatible. Bart
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,pericfg.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,pericfg.yaml new file mode 100644 index 000000000000..74b2a6173ffb --- /dev/null +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,pericfg.yaml @@ -0,0 +1,34 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/arm/mediatek/mediatek,pericfg.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: MediaTek Peripheral Configuration Controller + +maintainers: + - Bartosz Golaszewski <bgolaszewski@baylibre.com> + +properties: + compatible: + oneOf: + - items: + - enum: + - mediatek,pericfg + - const: syscon + + reg: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + pericfg: pericfg@10003050 { + compatible = "mediatek,mt8516-pericfg", "syscon"; + reg = <0 0x10003050 0 0x1000>; + };