| Message ID | 20200505111204.963-3-manafm@codeaurora.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add 0C (zeorC) interrupt support to tsens driver | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | fail | build log |
On Tue, May 5, 2020 at 4:43 PM Manaf Meethalavalappu Pallikunhi <manafm@codeaurora.org> wrote: > > Add 0C (zeroc) interrupt support for tsens in yaml. > > Signed-off-by: Manaf Meethalavalappu Pallikunhi <manafm@codeaurora.org> > --- > Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > index 2ddd39d96766..8a0893f77d20 100644 > --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > @@ -52,12 +52,14 @@ properties: > items: > - description: Combined interrupt if upper or lower threshold crossed > - description: Interrupt if critical threshold crossed > + - description: Interrupt if zeroC threshold is crossed > > interrupt-names: > minItems: 1 > items: > - const: uplow > - const: critical > + - const: zeroc > > nvmem-cells: > minItems: 1 > @@ -168,8 +170,9 @@ examples: > <0xc222000 0x1ff>; > > interrupts = <GIC_SPI 506 IRQ_TYPE_LEVEL_HIGH>, > - <GIC_SPI 508 IRQ_TYPE_LEVEL_HIGH>; > - interrupt-names = "uplow", "critical"; > + <GIC_SPI 508 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 510 IRQ_TYPE_EDGE_RISING>; > + interrupt-names = "uplow", "critical", "zeroc"; Add a new example for v2 with 0C interrupt here instead of reusing the old one. > #qcom,sensors = <13>; > #thermal-sensor-cells = <1>; > -- > 2.26.2
On Tue, 5 May 2020 16:42:04 +0530, Manaf Meethalavalappu Pallikunhi wrote: > Add 0C (zeroc) interrupt support for tsens in yaml. > > Signed-off-by: Manaf Meethalavalappu Pallikunhi <manafm@codeaurora.org> > --- > Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/qcom-tsens.example.dt.yaml: thermal-sensor@c263000: interrupt-names: ['uplow', 'critical', 'zeroc'] is too long /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/qcom-tsens.example.dt.yaml: thermal-sensor@c263000: interrupts: [[0, 506, 4], [0, 508, 4], [0, 510, 1]] is too long See https://patchwork.ozlabs.org/patch/1283470 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit.
On 2020-05-05 17:41, Amit Kucheria wrote: > On Tue, May 5, 2020 at 4:43 PM Manaf Meethalavalappu Pallikunhi > <manafm@codeaurora.org> wrote: >> >> Add 0C (zeroc) interrupt support for tsens in yaml. >> >> Signed-off-by: Manaf Meethalavalappu Pallikunhi >> <manafm@codeaurora.org> >> --- >> Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 7 +++++-- >> 1 file changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >> b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >> index 2ddd39d96766..8a0893f77d20 100644 >> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >> @@ -52,12 +52,14 @@ properties: >> items: >> - description: Combined interrupt if upper or lower threshold >> crossed >> - description: Interrupt if critical threshold crossed >> + - description: Interrupt if zeroC threshold is crossed >> >> interrupt-names: >> minItems: 1 >> items: >> - const: uplow >> - const: critical >> + - const: zeroc >> >> nvmem-cells: >> minItems: 1 >> @@ -168,8 +170,9 @@ examples: >> <0xc222000 0x1ff>; >> >> interrupts = <GIC_SPI 506 IRQ_TYPE_LEVEL_HIGH>, >> - <GIC_SPI 508 IRQ_TYPE_LEVEL_HIGH>; >> - interrupt-names = "uplow", "critical"; >> + <GIC_SPI 508 IRQ_TYPE_LEVEL_HIGH>, >> + <GIC_SPI 510 IRQ_TYPE_EDGE_RISING>; >> + interrupt-names = "uplow", "critical", "zeroc"; > > > Add a new example for v2 with 0C interrupt here instead of reusing the > old one. Done > >> #qcom,sensors = <13>; >> #thermal-sensor-cells = <1>; >> -- >> 2.26.2
On 2020-05-05 21:08, Rob Herring wrote: > On Tue, 5 May 2020 16:42:04 +0530, Manaf Meethalavalappu Pallikunhi > wrote: >> Add 0C (zeroc) interrupt support for tsens in yaml. >> >> Signed-off-by: Manaf Meethalavalappu Pallikunhi >> <manafm@codeaurora.org> >> --- >> Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 7 +++++-- >> 1 file changed, 5 insertions(+), 2 deletions(-) >> > > My bot found errors running 'make dt_binding_check' on your patch: > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/qcom-tsens.example.dt.yaml: > thermal-sensor@c263000: interrupt-names: ['uplow', 'critical', > 'zeroc'] is too long > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/qcom-tsens.example.dt.yaml: > thermal-sensor@c263000: interrupts: [[0, 506, 4], [0, 508, 4], [0, > 510, 1]] is too long > > See https://patchwork.ozlabs.org/patch/1283470 > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure dt-schema is up to date: > > pip3 install > git+https://github.com/devicetree-org/dt-schema.git@master --upgrade > > Please check and re-submit. Addressed above errors for Documentation/devicetree/bindings/thermal/qcom-tsens.yaml in v2
diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml index 2ddd39d96766..8a0893f77d20 100644 --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml @@ -52,12 +52,14 @@ properties: items: - description: Combined interrupt if upper or lower threshold crossed - description: Interrupt if critical threshold crossed + - description: Interrupt if zeroC threshold is crossed interrupt-names: minItems: 1 items: - const: uplow - const: critical + - const: zeroc nvmem-cells: minItems: 1 @@ -168,8 +170,9 @@ examples: <0xc222000 0x1ff>; interrupts = <GIC_SPI 506 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 508 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names = "uplow", "critical"; + <GIC_SPI 508 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 510 IRQ_TYPE_EDGE_RISING>; + interrupt-names = "uplow", "critical", "zeroc"; #qcom,sensors = <13>; #thermal-sensor-cells = <1>;
Add 0C (zeroc) interrupt support for tsens in yaml. Signed-off-by: Manaf Meethalavalappu Pallikunhi <manafm@codeaurora.org> --- Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)