Message ID | 20200426162032.52220-1-samuel@sholland.org |
---|---|
State | Accepted, archived |
Headers | show |
Series | dt-bindings: timer: Document allwinner,erratum-unknown1 property | expand |
Context | Check | Description |
---|---|---|
robh/checkpatch | warning | "total: 0 errors, 2 warnings, 12 lines checked" |
robh/dt-meta-schema | success |
On Sun, 26 Apr 2020 11:20:32 -0500, Samuel Holland wrote: > This arch_timer property was added in commit c950ca8c35ee > ("clocksource/drivers/arch_timer: Workaround for Allwinner A64 timer instability") > but I omitted the device tree binding documentation. Now > `make dtbs_check` prints the following warning for all A64 boards: > > timer: 'allwinner,erratum-unknown1' does not match any of the regexes: 'pinctrl-[0-9]+' > > Resolve this by documenting the erratum property. > > Signed-off-by: Samuel Holland <samuel@sholland.org> > --- > Documentation/devicetree/bindings/timer/arm,arch_timer.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > Applied, thanks!
diff --git a/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml b/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml index fa255672e8e5..cf520c7e9094 100644 --- a/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml +++ b/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml @@ -51,6 +51,12 @@ properties: description: If present, the timer is powered through an always-on power domain, therefore it never loses context. + allwinner,erratum-unknown1: + type: boolean + description: Indicates the presence of an erratum found in Allwinner SoCs, + where reading certain values from the counter is unreliable. This also + affects writes to the tval register, due to the implicit counter read. + fsl,erratum-a008585: type: boolean description: Indicates the presence of QorIQ erratum A-008585, which says
This arch_timer property was added in commit c950ca8c35ee ("clocksource/drivers/arch_timer: Workaround for Allwinner A64 timer instability") but I omitted the device tree binding documentation. Now `make dtbs_check` prints the following warning for all A64 boards: timer: 'allwinner,erratum-unknown1' does not match any of the regexes: 'pinctrl-[0-9]+' Resolve this by documenting the erratum property. Signed-off-by: Samuel Holland <samuel@sholland.org> --- Documentation/devicetree/bindings/timer/arm,arch_timer.yaml | 6 ++++++ 1 file changed, 6 insertions(+)