| Message ID | 20200422142428.1249684-7-jiaxun.yang@flygoat.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | Loongson PCH IRQ Support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success |
Hi, Jiaxun, On Wed, Apr 22, 2020 at 10:28 PM Jiaxun Yang <jiaxun.yang@flygoat.com> wrote: > > Add binding for Loongson PCH MSI controller. > > Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com> > --- > .../loongson,pch-msi.yaml | 56 +++++++++++++++++++ > 1 file changed, 56 insertions(+) > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/loongson,pch-msi.yaml > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/loongson,pch-msi.yaml b/Documentation/devicetree/bindings/interrupt-controller/loongson,pch-msi.yaml > new file mode 100644 > index 000000000000..dfb9cecacba0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/interrupt-controller/loongson,pch-msi.yaml > @@ -0,0 +1,56 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/interrupt-controller/loongson,pch-msi.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Loongson PCH MSI Controller > + > +maintainers: > + - Jiaxun Yang <jiaxun.yang@flygoat.com> > + > +description: | > + This interrupt controller is found in the Loongson-7A family of PCH for Please use "Loongson's LS7A family" here. > + transforming interrupts from PCIe MSI into HyperTransport vectorized > + interrupts. > + > +properties: > + compatible: > + const: loongson,pch-msi-1.0 > + > + reg: > + maxItems: 1 > + > + loongson,msi-base-vec: > + $ref: '/schemas/types.yaml#/definitions/uint32' > + description: | > + u32 value of the base of parent HyperTransport vector allocated > + to PCH MSI. > + > + loongson,msi-num-vecs: > + $ref: '/schemas/types.yaml#/definitions/uint32' > + description: | > + u32 value of the number of parent HyperTransport vectors allocated > + to PCH MSI. > + > + msi-controller: true > + > +required: > + - compatible > + - reg > + - msi-controller > + - loongson,msi-base-vec > + - loongson,msi-num-vecs > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + msi: msi-controller@2ff00000 { > + compatible = "loongson,pch-msi-1.0"; > + reg = <0x2ff00000 0x4>; > + msi-controller; > + loongson,msi-base-vec = <64>; > + loongson,msi-num-vecs = <64>; > + interrupt-parent = <&htvec>; > + }; > +... > -- > 2.26.0.rc2 >
Huacai, On 2020-04-23 06:55, Huacai Chen wrote: > Hi, Jiaxun, > > On Wed, Apr 22, 2020 at 10:28 PM Jiaxun Yang <jiaxun.yang@flygoat.com> > wrote: >> >> Add binding for Loongson PCH MSI controller. >> >> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com> >> --- >> .../loongson,pch-msi.yaml | 56 >> +++++++++++++++++++ >> 1 file changed, 56 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/interrupt-controller/loongson,pch-msi.yaml >> >> diff --git >> a/Documentation/devicetree/bindings/interrupt-controller/loongson,pch-msi.yaml >> b/Documentation/devicetree/bindings/interrupt-controller/loongson,pch-msi.yaml >> new file mode 100644 >> index 000000000000..dfb9cecacba0 >> --- /dev/null >> +++ >> b/Documentation/devicetree/bindings/interrupt-controller/loongson,pch-msi.yaml >> @@ -0,0 +1,56 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: >> "http://devicetree.org/schemas/interrupt-controller/loongson,pch-msi.yaml#" >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" >> + >> +title: Loongson PCH MSI Controller >> + >> +maintainers: >> + - Jiaxun Yang <jiaxun.yang@flygoat.com> >> + >> +description: | >> + This interrupt controller is found in the Loongson-7A family of PCH >> for > Please use "Loongson's LS7A family" here. It's the fourth email you send on the same subject. I think the author has got the message already. Frankly, it is only a name, and if they want to call it Bob, so be it. Thanks, M.
Hi, Marc, On Thu, Apr 23, 2020 at 8:46 PM Marc Zyngier <maz@kernel.org> wrote: > > Huacai, > > On 2020-04-23 06:55, Huacai Chen wrote: > > Hi, Jiaxun, > > > > On Wed, Apr 22, 2020 at 10:28 PM Jiaxun Yang <jiaxun.yang@flygoat.com> > > wrote: > >> > >> Add binding for Loongson PCH MSI controller. > >> > >> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com> > >> --- > >> .../loongson,pch-msi.yaml | 56 > >> +++++++++++++++++++ > >> 1 file changed, 56 insertions(+) > >> create mode 100644 > >> Documentation/devicetree/bindings/interrupt-controller/loongson,pch-msi.yaml > >> > >> diff --git > >> a/Documentation/devicetree/bindings/interrupt-controller/loongson,pch-msi.yaml > >> b/Documentation/devicetree/bindings/interrupt-controller/loongson,pch-msi.yaml > >> new file mode 100644 > >> index 000000000000..dfb9cecacba0 > >> --- /dev/null > >> +++ > >> b/Documentation/devicetree/bindings/interrupt-controller/loongson,pch-msi.yaml > >> @@ -0,0 +1,56 @@ > >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >> +%YAML 1.2 > >> +--- > >> +$id: > >> "http://devicetree.org/schemas/interrupt-controller/loongson,pch-msi.yaml#" > >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > >> + > >> +title: Loongson PCH MSI Controller > >> + > >> +maintainers: > >> + - Jiaxun Yang <jiaxun.yang@flygoat.com> > >> + > >> +description: | > >> + This interrupt controller is found in the Loongson-7A family of PCH > >> for > > Please use "Loongson's LS7A family" here. > > It's the fourth email you send on the same subject. I think the author > has got the message already. Frankly, it is only a name, and if they > want to call it Bob, so be it. I'm sorry that make so much noise, and I will not do this again. Yes, a name is just a name, but we can do something to avoid confusing as much as possible. > > Thanks, > > M. > -- > Jazz is not dead. It just smells funny... Thanks, Huacai
diff --git a/Documentation/devicetree/bindings/interrupt-controller/loongson,pch-msi.yaml b/Documentation/devicetree/bindings/interrupt-controller/loongson,pch-msi.yaml new file mode 100644 index 000000000000..dfb9cecacba0 --- /dev/null +++ b/Documentation/devicetree/bindings/interrupt-controller/loongson,pch-msi.yaml @@ -0,0 +1,56 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/interrupt-controller/loongson,pch-msi.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Loongson PCH MSI Controller + +maintainers: + - Jiaxun Yang <jiaxun.yang@flygoat.com> + +description: | + This interrupt controller is found in the Loongson-7A family of PCH for + transforming interrupts from PCIe MSI into HyperTransport vectorized + interrupts. + +properties: + compatible: + const: loongson,pch-msi-1.0 + + reg: + maxItems: 1 + + loongson,msi-base-vec: + $ref: '/schemas/types.yaml#/definitions/uint32' + description: | + u32 value of the base of parent HyperTransport vector allocated + to PCH MSI. + + loongson,msi-num-vecs: + $ref: '/schemas/types.yaml#/definitions/uint32' + description: | + u32 value of the number of parent HyperTransport vectors allocated + to PCH MSI. + + msi-controller: true + +required: + - compatible + - reg + - msi-controller + - loongson,msi-base-vec + - loongson,msi-num-vecs + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + msi: msi-controller@2ff00000 { + compatible = "loongson,pch-msi-1.0"; + reg = <0x2ff00000 0x4>; + msi-controller; + loongson,msi-base-vec = <64>; + loongson,msi-num-vecs = <64>; + interrupt-parent = <&htvec>; + }; +...
Add binding for Loongson PCH MSI controller. Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com> --- .../loongson,pch-msi.yaml | 56 +++++++++++++++++++ 1 file changed, 56 insertions(+) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/loongson,pch-msi.yaml