| Message ID | 20200412132139.11418-2-sam@ravnborg.org |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [v2,1/1] dt-bindings: display: allow port and ports in panel-lvds | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | "total: 0 errors, 1 warnings, 21 lines checked" |
| robh/dt-meta-schema | success |
On Sun, Apr 12, 2020 at 03:21:39PM +0200, Sam Ravnborg wrote: > Both port and ports names may be used in a panel-lvds binding > port - for a single port > ports - if there is more than one port in sub-nodes > > Fixes the following warning: > advantech,idk-2121wr.example.dt.yaml: panel-lvds: 'port' is a required property > > advantech,idk-2121wr.yaml needs several ports, so uses a ports node. > > v2: > - Use oneOf - makes the logic more obvious (Rob) > - Added Fixes tag > - Added port: true, ports:true > > Signed-off-by: Sam Ravnborg <sam@ravnborg.org> > Cc: Rob Herring <robh@kernel.org> > Fixes: 8efef33eff50 ("dt-bindings: display: Add idk-2121wr binding") > Cc: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > Cc: Sam Ravnborg <sam@ravnborg.org> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: dri-devel@lists.freedesktop.org > --- > .../devicetree/bindings/display/panel/lvds.yaml | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) Reviewed-by: Rob Herring <robh@kernel.org> One nit below... > > diff --git a/Documentation/devicetree/bindings/display/panel/lvds.yaml b/Documentation/devicetree/bindings/display/panel/lvds.yaml > index d0083301acbe..a5587c4f5ad0 100644 > --- a/Documentation/devicetree/bindings/display/panel/lvds.yaml > +++ b/Documentation/devicetree/bindings/display/panel/lvds.yaml > @@ -96,12 +96,20 @@ properties: > If set, reverse the bit order described in the data mappings below on all > data lanes, transmitting bits for slots 6 to 0 instead of 0 to 6. > > + port: true > + ports: true > + > required: > - compatible > - data-mapping > - width-mm > - height-mm > - panel-timing > - - port > + > +oneOf: > + - required: > + - port > + - required: > + - ports Should be indented 2 more spaces. It only matters for any scripted processing we do on the files. Rob
Hi Rob. > > Cc: Thierry Reding <thierry.reding@gmail.com> > > Cc: dri-devel@lists.freedesktop.org > > --- > > .../devicetree/bindings/display/panel/lvds.yaml | 10 +++++++++- > > 1 file changed, 9 insertions(+), 1 deletion(-) > > Reviewed-by: Rob Herring <robh@kernel.org> > > One nit below... > > > > > diff --git a/Documentation/devicetree/bindings/display/panel/lvds.yaml b/Documentation/devicetree/bindings/display/panel/lvds.yaml > > index d0083301acbe..a5587c4f5ad0 100644 > > --- a/Documentation/devicetree/bindings/display/panel/lvds.yaml > > +++ b/Documentation/devicetree/bindings/display/panel/lvds.yaml > > @@ -96,12 +96,20 @@ properties: > > If set, reverse the bit order described in the data mappings below on all > > data lanes, transmitting bits for slots 6 to 0 instead of 0 to 6. > > > > + port: true > > + ports: true > > + > > required: > > - compatible > > - data-mapping > > - width-mm > > - height-mm > > - panel-timing > > - - port > > + > > +oneOf: > > + - required: > > + - port > > + - required: > > + - ports > > Should be indented 2 more spaces. It only matters for any scripted > processing we do on the files. Fixed and pushed to drm-misc-next. Will cherry-pick to drm-fixes. Sam
diff --git a/Documentation/devicetree/bindings/display/panel/lvds.yaml b/Documentation/devicetree/bindings/display/panel/lvds.yaml index d0083301acbe..a5587c4f5ad0 100644 --- a/Documentation/devicetree/bindings/display/panel/lvds.yaml +++ b/Documentation/devicetree/bindings/display/panel/lvds.yaml @@ -96,12 +96,20 @@ properties: If set, reverse the bit order described in the data mappings below on all data lanes, transmitting bits for slots 6 to 0 instead of 0 to 6. + port: true + ports: true + required: - compatible - data-mapping - width-mm - height-mm - panel-timing - - port + +oneOf: + - required: + - port + - required: + - ports ...
Both port and ports names may be used in a panel-lvds binding port - for a single port ports - if there is more than one port in sub-nodes Fixes the following warning: advantech,idk-2121wr.example.dt.yaml: panel-lvds: 'port' is a required property advantech,idk-2121wr.yaml needs several ports, so uses a ports node. v2: - Use oneOf - makes the logic more obvious (Rob) - Added Fixes tag - Added port: true, ports:true Signed-off-by: Sam Ravnborg <sam@ravnborg.org> Cc: Rob Herring <robh@kernel.org> Fixes: 8efef33eff50 ("dt-bindings: display: Add idk-2121wr binding") Cc: Fabrizio Castro <fabrizio.castro@bp.renesas.com> Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Cc: Sam Ravnborg <sam@ravnborg.org> Cc: Thierry Reding <thierry.reding@gmail.com> Cc: dri-devel@lists.freedesktop.org --- .../devicetree/bindings/display/panel/lvds.yaml | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)