| Message ID | 20200409070448.3209-1-paweldembicki@gmail.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [v2,1/2] dt-bindings: vendor-prefixes: Add Check Point | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success |
Hi Pawel. On Thu, Apr 09, 2020 at 09:04:43AM +0200, Pawel Dembicki wrote: > Check Point Software Technologies Ltd. is a company based in Israel and > USA. They manufacture network devices and provide software > products for IT security. > > Signed-off-by: Pawel Dembicki <paweldembicki@gmail.com> Looks good now. Acked-by: Sam Ravnborg <sam@ravnborg.org> I expect someone else to pick it up. Sam > --- > Changes in v2: > - corrected line order > > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml > index d3891386d671..3819192d035d 100644 > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml > @@ -181,6 +181,8 @@ patternProperties: > description: CDTech(H.K.) Electronics Limited > "^ceva,.*": > description: Ceva, Inc. > + "^checkpoint,.*": > + description: Check Point Software Technologies Ltd. > "^chipidea,.*": > description: Chipidea, Inc > "^chipone,.*": > -- > 2.20.1
On Thu, Apr 09, 2020 at 09:04:44AM +0200, Pawel Dembicki wrote: > This patch adds dts for the Check Point L-50 from 600/1100 series > routers. Hi Pawel Looks very good. Just a minor comment: > +ð1 { > + status = "okay"; > + ethernet1-port@0 { > + speed = <1000>; > + duplex = <1>; > + }; > +}; This is a non-standard way of doing a fixed link. But looking at the driver, that is all it supports. I also don't think it is worth the effort converting it. Kirkwood is so old we hardly see any new boards using it. So: Reviewed-by: Andrew Lunn <andrew@lunn.ch> Since we are in the merge window at the moment, this won't be merged for a while. Andrew
On Thu, 9 Apr 2020 09:04:43 +0200, Pawel Dembicki wrote: > Check Point Software Technologies Ltd. is a company based in Israel and > USA. They manufacture network devices and provide software > products for IT security. > > Signed-off-by: Pawel Dembicki <paweldembicki@gmail.com> > --- > Changes in v2: > - corrected line order > > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Applied, thanks. Rob
Hi Pawel Dembicki, > This patch adds dts for the Check Point L-50 from 600/1100 series > routers. > > Specification: > -CPU: Marvell Kirkwood 88F6821 1200MHz > -RAM: 512MB > -Flash: NAND 512MB > -WiFi: mPCIe card based on Atheros AR9287 b/g/n > -WAN: 1 Gigabit Port (Marvell 88E1116R PHY) > -LAN: 9 Gigabit Ports (2x Marvell 88E6171(5+3)) > -USB: 2x USB2.0 > -Express card slot > -SD card slot > -Serial console: RJ-45 115200 8n1 > -Unsupported DSL > > Signed-off-by: Pawel Dembicki <paweldembicki@gmail.com> Applied on mvebu/dt. I think the first patch should be applied by the device tree maintainers. Thanks, Gregory > --- > Changes in v2: > - none > > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/kirkwood-l-50.dts | 441 ++++++++++++++++++++++++++++ > 2 files changed, 442 insertions(+) > create mode 100644 arch/arm/boot/dts/kirkwood-l-50.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index e8dd99201397..eba030b3ba69 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -279,6 +279,7 @@ dtb-$(CONFIG_MACH_KIRKWOOD) += \ > kirkwood-iomega_ix2_200.dtb \ > kirkwood-is2.dtb \ > kirkwood-km_kirkwood.dtb \ > + kirkwood-l-50.dtb \ > kirkwood-laplug.dtb \ > kirkwood-linkstation-lsqvl.dtb \ > kirkwood-linkstation-lsvl.dtb \ > diff --git a/arch/arm/boot/dts/kirkwood-l-50.dts b/arch/arm/boot/dts/kirkwood-l-50.dts > new file mode 100644 > index 000000000000..ab3a90287260 > --- /dev/null > +++ b/arch/arm/boot/dts/kirkwood-l-50.dts > @@ -0,0 +1,441 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Check Point L-50 Board Description > + * Copyright 2020 Pawel Dembicki <paweldembicki@gmail.com> > + */ > + > +/dts-v1/; > + > +#include "kirkwood.dtsi" > +#include "kirkwood-6281.dtsi" > + > +/ { > + model = "Check Point L-50"; > + compatible = "checkpoint,l-50", "marvell,kirkwood-88f6281", "marvell,kirkwood"; > + > + memory { > + device_type = "memory"; > + reg = <0x00000000 0x20000000>; > + }; > + > + chosen { > + bootargs = "console=ttyS0,115200n8"; > + stdout-path = &uart0; > + }; > + > + ocp@f1000000 { > + pinctrl: pin-controller@10000 { > + pinctrl-0 = <&pmx_led38 &pmx_sysrst &pmx_button29>; > + pinctrl-names = "default"; > + > + pmx_sysrst: pmx-sysrst { > + marvell,pins = "mpp6"; > + marvell,function = "sysrst"; > + }; > + > + pmx_button29: pmx_button29 { > + marvell,pins = "mpp29"; > + marvell,function = "gpio"; > + }; > + > + pmx_led38: pmx_led38 { > + marvell,pins = "mpp38"; > + marvell,function = "gpio"; > + }; > + > + pmx_sdio_cd: pmx-sdio-cd { > + marvell,pins = "mpp46"; > + marvell,function = "gpio"; > + }; > + }; > + > + serial@12000 { > + status = "okay"; > + }; > + > + mvsdio@90000 { > + status = "okay"; > + cd-gpios = <&gpio1 14 9>; > + }; > + > + i2c@11000 { > + status = "okay"; > + clock-frequency = <400000>; > + > + gpio2: gpio-expander@20{ > + #gpio-cells = <2>; > + #interrupt-cells = <2>; > + compatible = "semtech,sx1505q"; > + reg = <0x20>; > + > + gpio-controller; > + }; > + > + /* Three GPIOs from 0x21 exp. are undescribed in dts: > + * 1: DSL module reset (active low) > + * 5: mPCIE reset (active low) > + * 6: Express card reset (active low) > + */ > + gpio3: gpio-expander@21{ > + #gpio-cells = <2>; > + #interrupt-cells = <2>; > + compatible = "semtech,sx1505q"; > + reg = <0x21>; > + > + gpio-controller; > + }; > + > + rtc@30 { > + compatible = "s35390a"; > + reg = <0x30>; > + }; > + }; > + }; > + > + leds { > + compatible = "gpio-leds"; > + > + status_green { > + label = "l-50:green:status"; > + gpios = <&gpio1 6 GPIO_ACTIVE_LOW>; > + }; > + > + status_orange { > + label = "l-50:orange:status"; > + gpios = <&gpio3 2 GPIO_ACTIVE_LOW>; > + }; > + > + wifi { > + label = "l-50:green:wifi"; > + gpios = <&gpio2 7 GPIO_ACTIVE_LOW>; > + linux,default-trigger = "phy0tpt"; > + }; > + > + internet_green { > + label = "l-50:green:internet"; > + gpios = <&gpio2 3 GPIO_ACTIVE_LOW>; > + }; > + > + internet_red { > + label = "l-50:red:internet"; > + gpios = <&gpio2 1 GPIO_ACTIVE_LOW>; > + }; > + > + usb1_green { > + label = "l-50:green:usb1"; > + gpios = <&gpio2 0 GPIO_ACTIVE_LOW>; > + linux,default-trigger = "usbport"; > + trigger-sources = <&hub_port3>; > + }; > + > + usb1_red { > + label = "l-50:red:usb1"; > + gpios = <&gpio2 4 GPIO_ACTIVE_LOW>; > + }; > + > + usb2_green { > + label = "l-50:green:usb2"; > + gpios = <&gpio2 2 GPIO_ACTIVE_LOW>; > + linux,default-trigger = "usbport"; > + trigger-sources = <&hub_port1>; > + }; > + > + usb2_red { > + label = "l-50:red:usb2"; > + gpios = <&gpio2 5 GPIO_ACTIVE_LOW>; > + }; > + }; > + > + usb2_pwr { > + compatible = "regulator-fixed"; > + regulator-name = "usb2_pwr"; > + > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + gpio = <&gpio3 3 GPIO_ACTIVE_LOW>; > + enable-active-low; > + regulator-always-on; > + }; > + > + usb1_pwr { > + compatible = "regulator-fixed"; > + regulator-name = "usb1_pwr"; > + > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + gpio = <&gpio3 4 GPIO_ACTIVE_LOW>; > + enable-active-low; > + regulator-always-on; > + }; > + > + mpcie_pwr { > + compatible = "regulator-fixed"; > + regulator-name = "mpcie_pwr"; > + > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + gpio = <&gpio3 5 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + regulator-always-on; > + }; > + > + express_card_pwr { > + compatible = "regulator-fixed"; > + regulator-name = "express_card_pwr"; > + > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + gpio = <&gpio3 7 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + regulator-always-on; > + }; > + > + keys { > + compatible = "gpio-keys-polled"; > + poll-interval = <20>; > + > + factory_defaults { > + label = "factory_defaults"; > + gpios = <&gpio0 29 GPIO_ACTIVE_LOW>; > + linux,code = <KEY_RESTART>; > + }; > + > + }; > +}; > + > +&mdio { > + status = "okay"; > + > + ethphy0: ethernet-phy@8 { > + reg = <0x08>; > + }; > + > + switch0: switch@10 { > + compatible = "marvell,mv88e6085"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x10>; > + dsa,member = <0 0>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + label = "lan5"; > + }; > + > + port@1 { > + reg = <1>; > + label = "lan1"; > + }; > + > + port@2 { > + reg = <2>; > + label = "lan6"; > + }; > + > + port@3 { > + reg = <3>; > + label = "lan2"; > + }; > + > + port@4 { > + reg = <4>; > + label = "lan7"; > + }; > + > + switch0port5: port@5 { > + reg = <5>; > + phy-mode = "rgmii-txid"; > + link = <&switch1port5>; > + fixed-link { > + speed = <1000>; > + full-duplex; > + }; > + }; > + > + port@6 { > + reg = <6>; > + label = "cpu"; > + phy-mode = "rgmii-id"; > + ethernet = <ð1port>; > + fixed-link { > + speed = <1000>; > + full-duplex; > + }; > + }; > + }; > + }; > + switch@11 { > + compatible = "marvell,mv88e6085"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x11>; > + dsa,member = <0 1>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + label = "lan3"; > + }; > + > + port@1 { > + reg = <1>; > + label = "lan8"; > + }; > + > + port@2 { > + reg = <2>; > + label = "lan4"; > + }; > + > + port@3 { > + reg = <3>; > + label = "dmz"; > + }; > + > + switch1port5: port@5 { > + reg = <5>; > + phy-mode = "rgmii-txid"; > + link = <&switch0port5>; > + fixed-link { > + speed = <1000>; > + full-duplex; > + }; > + }; > + > + port@6 { > + reg = <6>; > + label = "dsl"; > + fixed-link { > + speed = <100>; > + full-duplex; > + }; > + }; > + }; > + }; > +}; > + > +ð0 { > + status = "okay"; > + ethernet0-port@0 { > + phy-handle = <ðphy0>; > + }; > +}; > + > +ð1 { > + status = "okay"; > + ethernet1-port@0 { > + speed = <1000>; > + duplex = <1>; > + }; > +}; > + > +&nand { > + status = "okay"; > + pinctrl-0 = <&pmx_nand>; > + pinctrl-names = "default"; > + > + partition@0 { > + label = "u-boot"; > + reg = <0x0000000 0xc0000>; > + }; > + > + partition@a0000 { > + label = "bootldr-env"; > + reg = <0x000c0000 0x40000>; > + }; > + > + partition@100000 { > + label = "kernel-1"; > + reg = <0x00100000 0x800000>; > + }; > + > + partition@900000 { > + label = "rootfs-1"; > + reg = <0x08200000 0x7100000>; > + }; > + > + partition@7a00000 { > + label = "kernel-2"; > + reg = <0x07a00000 0x800000>; > + }; > + > + partition@8200000 { > + label = "rootfs-2"; > + reg = <0x08200000 0x7100000>; > + }; > + > + partition@f300000 { > + label = "default_sw"; > + reg = <0x0f300000 0x7900000>; > + }; > + > + partition@16c00000 { > + label = "logs"; > + reg = <0x16c00000 0x1800000>; > + }; > + > + partition@18400000 { > + label = "preset_cfg"; > + reg = <0x18400000 0x100000>; > + }; > + > + partition@18500000 { > + label = "adsl"; > + reg = <0x18500000 0x100000>; > + }; > + > + partition@18600000 { > + label = "storage"; > + reg = <0x18600000 0x7A00000>; > + }; > +}; > + > +&rtc { > + status = "disabled"; > +}; > + > +&pciec { > + status = "okay"; > +}; > + > +&pcie0 { > + status = "okay"; > +}; > + > +&sata_phy0 { > + status = "disabled"; > +}; > + > +&sata_phy1 { > + status = "disabled"; > +}; > + > +&usb0 { > + #address-cells = <1>; > + #size-cells = <0>; > + status = "okay"; > + > + port@1 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <1>; > + #trigger-source-cells = <0>; > + > + hub_port1: port@1 { > + reg = <1>; > + #trigger-source-cells = <0>; > + }; > + > + hub_port3: port@3 { > + reg = <3>; > + #trigger-source-cells = <0>; > + }; > + }; > +}; > -- > 2.20.1 >
On 17.05.2020 at 17:26 Gregory CLEMENT <gregory.clement@bootlin.com> wrote: > > Hi Pawel Dembicki, > Hi Gregory, > > Applied on mvebu/dt. I think the first patch should be applied by the > device tree maintainers. > > Thanks, > > Gregory > I sent v3 of this patch some time ago: https://lkml.org/lkml/2020/4/22/1353 Is possible to use it instead v2? Best Regards, Pawel Dembicki
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml index d3891386d671..3819192d035d 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml @@ -181,6 +181,8 @@ patternProperties: description: CDTech(H.K.) Electronics Limited "^ceva,.*": description: Ceva, Inc. + "^checkpoint,.*": + description: Check Point Software Technologies Ltd. "^chipidea,.*": description: Chipidea, Inc "^chipone,.*":
Check Point Software Technologies Ltd. is a company based in Israel and USA. They manufacture network devices and provide software products for IT security. Signed-off-by: Pawel Dembicki <paweldembicki@gmail.com> --- Changes in v2: - corrected line order Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+)