| Message ID | 20200406230855.13772-2-hyunki00.koo@samsung.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [v6,1/2] dt-bindings: serial: Add reg-io-width compatible | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | fail | build log |
On Tue, Apr 07, 2020 at 08:08:50AM +0900, Hyunki Koo wrote: > Add a description for reg-io-width options for the samsung serial > UART peripheral. > > Signed-off-by: Hyunki Koo <hyunki00.koo@samsung.com> > --- > v5: first added in this series > v6: clean description of reg-io-width > --- > Documentation/devicetree/bindings/serial/samsung_uart.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) Please keep accumulated tags (review, ack, tested etc.) with new versions of paches. Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof
On Tue, 7 Apr 2020 08:08:50 +0900, Hyunki Koo wrote: > Add a description for reg-io-width options for the samsung serial > UART peripheral. > > Signed-off-by: Hyunki Koo <hyunki00.koo@samsung.com> > --- > v5: first added in this series > v6: clean description of reg-io-width > --- > Documentation/devicetree/bindings/serial/samsung_uart.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: Documentation/devicetree/bindings/serial/samsung_uart.yaml: mapping values are not allowed in this context in "<unicode string>", line 36, column 13 Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/serial/samsung_uart.example.dts' failed make[1]: *** [Documentation/devicetree/bindings/serial/samsung_uart.example.dts] Error 1 make[1]: *** Waiting for unfinished jobs.... Makefile:1262: recipe for target 'dt_binding_check' failed make: *** [dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1267104 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit.
On Mon, Apr 6, 2020 at 5:09 PM Hyunki Koo <hyunki00.koo@samsung.com> wrote: > > Add a description for reg-io-width options for the samsung serial > UART peripheral. > > Signed-off-by: Hyunki Koo <hyunki00.koo@samsung.com> > --- > v5: first added in this series > v6: clean description of reg-io-width > --- > Documentation/devicetree/bindings/serial/samsung_uart.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/serial/samsung_uart.yaml b/Documentation/devicetree/bindings/serial/samsung_uart.yaml > index 9d2ce347875b..1a0bb7619e2e 100644 > --- a/Documentation/devicetree/bindings/serial/samsung_uart.yaml > +++ b/Documentation/devicetree/bindings/serial/samsung_uart.yaml > @@ -29,6 +29,12 @@ properties: > reg: > maxItems: 1 > > + reg-io-width: > + description: > + The size (in bytes) of the IO accesses that should be performed > + on the device. If omitted, default of 1 is used. > + - enum: [ 1, 4 ] Can't this be implied by the compatible strings? This isn't actual json-schema either with the enum under the description. Run 'make dt_binding_check' before you send schemas. There's a keyword for expressing the default value too. Hint: It's 'default'. Rob
diff --git a/Documentation/devicetree/bindings/serial/samsung_uart.yaml b/Documentation/devicetree/bindings/serial/samsung_uart.yaml index 9d2ce347875b..1a0bb7619e2e 100644 --- a/Documentation/devicetree/bindings/serial/samsung_uart.yaml +++ b/Documentation/devicetree/bindings/serial/samsung_uart.yaml @@ -29,6 +29,12 @@ properties: reg: maxItems: 1 + reg-io-width: + description: + The size (in bytes) of the IO accesses that should be performed + on the device. If omitted, default of 1 is used. + - enum: [ 1, 4 ] + clocks: minItems: 2 maxItems: 5
Add a description for reg-io-width options for the samsung serial UART peripheral. Signed-off-by: Hyunki Koo <hyunki00.koo@samsung.com> --- v5: first added in this series v6: clean description of reg-io-width --- Documentation/devicetree/bindings/serial/samsung_uart.yaml | 6 ++++++ 1 file changed, 6 insertions(+)