| Message ID | 20200330164328.2944505-2-robert.marko@sartura.hr |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | None | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | fail | build log |
On Mon, 30 Mar 2020 18:43:29 +0200, Robert Marko wrote: > This patch adds the binding documentation for the HS/SS USB PHY found > inside Qualcom Dakota SoCs. > > Signed-off-by: John Crispin <john@phrozen.org> > Signed-off-by: Robert Marko <robert.marko@sartura.hr> > Cc: Luka Perkov <luka.perkov@sartura.hr> > --- > Changes from v4 to v5: > * Replace tabs with whitespaces > * Add maintainer property > > .../bindings/phy/qcom-usb-ipq4019-phy.yaml | 48 +++++++++++++++++++ > 1 file changed, 48 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.yaml > My bot found errors running 'make dt_binding_check' on your patch: Error: Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.example.dts:21.25-26 syntax error FATAL ERROR: Unable to parse input tree scripts/Makefile.lib:311: recipe for target 'Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.example.dt.yaml' failed make[1]: *** [Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.example.dt.yaml] Error 1 make[1]: *** Waiting for unfinished jobs.... Makefile:1262: recipe for target 'dt_binding_check' failed make: *** [dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1264091 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit.
On Tue, Mar 31, 2020 at 6:31 PM Rob Herring <robh@kernel.org> wrote: > > On Mon, 30 Mar 2020 18:43:29 +0200, Robert Marko wrote: > > This patch adds the binding documentation for the HS/SS USB PHY found > > inside Qualcom Dakota SoCs. > > > > Signed-off-by: John Crispin <john@phrozen.org> > > Signed-off-by: Robert Marko <robert.marko@sartura.hr> > > Cc: Luka Perkov <luka.perkov@sartura.hr> > > --- > > Changes from v4 to v5: > > * Replace tabs with whitespaces > > * Add maintainer property > > > > .../bindings/phy/qcom-usb-ipq4019-phy.yaml | 48 +++++++++++++++++++ > > 1 file changed, 48 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.yaml > > > > My bot found errors running 'make dt_binding_check' on your patch: > > Error: Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.example.dts:21.25-26 syntax error > FATAL ERROR: Unable to parse input tree > scripts/Makefile.lib:311: recipe for target 'Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.example.dt.yaml' failed > make[1]: *** [Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.example.dt.yaml] Error 1 > make[1]: *** Waiting for unfinished jobs.... > Makefile:1262: recipe for target 'dt_binding_check' failed > make: *** [dt_binding_check] Error 2 > > See https://patchwork.ozlabs.org/patch/1264091 > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure dt-schema is up to date: > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade > > Please check and re-submit. Hi Rob, I tested locally before submitting and it will pass. It appears that the bot will fail in your tree as a patch to add DT nodes is part of the series and not yet upstream. Best regards Robert
On Tue, Mar 31, 2020 at 10:39 AM Robert Marko <robert.marko@sartura.hr> wrote: > > On Tue, Mar 31, 2020 at 6:31 PM Rob Herring <robh@kernel.org> wrote: > > > > On Mon, 30 Mar 2020 18:43:29 +0200, Robert Marko wrote: > > > This patch adds the binding documentation for the HS/SS USB PHY found > > > inside Qualcom Dakota SoCs. > > > > > > Signed-off-by: John Crispin <john@phrozen.org> > > > Signed-off-by: Robert Marko <robert.marko@sartura.hr> > > > Cc: Luka Perkov <luka.perkov@sartura.hr> > > > --- > > > Changes from v4 to v5: > > > * Replace tabs with whitespaces > > > * Add maintainer property > > > > > > .../bindings/phy/qcom-usb-ipq4019-phy.yaml | 48 +++++++++++++++++++ > > > 1 file changed, 48 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.yaml > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > Error: Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.example.dts:21.25-26 syntax error > > FATAL ERROR: Unable to parse input tree > > scripts/Makefile.lib:311: recipe for target 'Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.example.dt.yaml' failed > > make[1]: *** [Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.example.dt.yaml] Error 1 > > make[1]: *** Waiting for unfinished jobs.... > > Makefile:1262: recipe for target 'dt_binding_check' failed > > make: *** [dt_binding_check] Error 2 > > > > See https://patchwork.ozlabs.org/patch/1264091 > > > > If you already ran 'make dt_binding_check' and didn't see the above > > error(s), then make sure dt-schema is up to date: > > > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade > > > > Please check and re-submit. > Hi Rob, > I tested locally before submitting and it will pass. Impossible. Your example has defines, but there are no include files listed. Rob
On Wed, Apr 1, 2020 at 5:45 PM Rob Herring <robh@kernel.org> wrote: > > On Tue, Mar 31, 2020 at 10:39 AM Robert Marko <robert.marko@sartura.hr> wrote: > > > > On Tue, Mar 31, 2020 at 6:31 PM Rob Herring <robh@kernel.org> wrote: > > > > > > On Mon, 30 Mar 2020 18:43:29 +0200, Robert Marko wrote: > > > > This patch adds the binding documentation for the HS/SS USB PHY found > > > > inside Qualcom Dakota SoCs. > > > > > > > > Signed-off-by: John Crispin <john@phrozen.org> > > > > Signed-off-by: Robert Marko <robert.marko@sartura.hr> > > > > Cc: Luka Perkov <luka.perkov@sartura.hr> > > > > --- > > > > Changes from v4 to v5: > > > > * Replace tabs with whitespaces > > > > * Add maintainer property > > > > > > > > .../bindings/phy/qcom-usb-ipq4019-phy.yaml | 48 +++++++++++++++++++ > > > > 1 file changed, 48 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.yaml > > > > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > > > Error: Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.example.dts:21.25-26 syntax error > > > FATAL ERROR: Unable to parse input tree > > > scripts/Makefile.lib:311: recipe for target 'Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.example.dt.yaml' failed > > > make[1]: *** [Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.example.dt.yaml] Error 1 > > > make[1]: *** Waiting for unfinished jobs.... > > > Makefile:1262: recipe for target 'dt_binding_check' failed > > > make: *** [dt_binding_check] Error 2 > > > > > > See https://patchwork.ozlabs.org/patch/1264091 > > > > > > If you already ran 'make dt_binding_check' and didn't see the above > > > error(s), then make sure dt-schema is up to date: > > > > > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade > > > > > > Please check and re-submit. > > Hi Rob, > > I tested locally before submitting and it will pass. > > Impossible. Your example has defines, but there are no include files listed. I don't know how it passed, but I definitively tested with make dtbs_check and then make dt_binding_check It could possibly be old DT schema files, I updated today and now it pops up. I will fix it and send a new version ASAP. Thanks > > Rob
diff --git a/Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.yaml b/Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.yaml new file mode 100644 index 000000000000..4a6b5aa83925 --- /dev/null +++ b/Documentation/devicetree/bindings/phy/qcom-usb-ipq4019-phy.yaml @@ -0,0 +1,48 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/phy/qcom-usb-ipq4019-phy.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Qualcom IPQ40xx Dakota HS/SS USB PHY + +maintainers: + - Robert Marko <robert.marko@sartura.hr> + +properties: + compatible: + enum: + - qcom,usb-ss-ipq4019-phy + - qcom,usb-hs-ipq4019-phy + + reg: + maxItems: 1 + + resets: + maxItems: 2 + + reset-names: + items: + - const: por_rst + - const: srif_rst + + "#phy-cells": + const: 0 + +required: + - compatible + - reg + - resets + - reset-names + - "#phy-cells" + +examples: + - | + hsphy@a8000 { + compatible = "qcom,usb-hs-ipq4019-phy"; + phy-cells = <0>; + reg = <0xa8000 0x40>; + resets = <&gcc USB2_HSPHY_POR_ARES>, + <&gcc USB2_HSPHY_S_ARES>; + reset-names = "por_rst", "srif_rst"; + };