diff mbox series

[3/4] dt-bindings: mfd: Add ENE KB3930 Embedded Controller binding

Message ID 20200309203818.31266-4-lkundrak@v3.sk
State Changes Requested, archived
Headers show
Series mfd: Add ENE KB3930 Embedded Controller driver | expand

Checks

Context Check Description
robh/checkpatch success
robh/dt-meta-schema fail build log

Commit Message

Lubomir Rintel March 9, 2020, 8:38 p.m. UTC
Add binding document for the ENE KB3930 Embedded Controller.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
 .../devicetree/bindings/mfd/ene-kb3930.yaml   | 46 +++++++++++++++++++
 1 file changed, 46 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/ene-kb3930.yaml

Comments

Rob Herring (Arm) March 10, 2020, 6:36 p.m. UTC | #1
On Mon,  9 Mar 2020 21:38:17 +0100, Lubomir Rintel wrote:
> 
> Add binding document for the ENE KB3930 Embedded Controller.
> 
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> ---
>  .../devicetree/bindings/mfd/ene-kb3930.yaml   | 46 +++++++++++++++++++
>  1 file changed, 46 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/ene-kb3930.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

Error: Documentation/devicetree/bindings/mfd/ene-kb3930.example.dts:22.34-35 syntax error
FATAL ERROR: Unable to parse input tree
scripts/Makefile.lib:311: recipe for target 'Documentation/devicetree/bindings/mfd/ene-kb3930.example.dt.yaml' failed
make[1]: *** [Documentation/devicetree/bindings/mfd/ene-kb3930.example.dt.yaml] Error 1
make[1]: *** Waiting for unfinished jobs....
Makefile:1262: recipe for target 'dt_binding_check' failed
make: *** [dt_binding_check] Error 2

See https://patchwork.ozlabs.org/patch/1251828
Please check and re-submit.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mfd/ene-kb3930.yaml b/Documentation/devicetree/bindings/mfd/ene-kb3930.yaml
new file mode 100644
index 0000000000000..5c9009617aea2
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/ene-kb3930.yaml
@@ -0,0 +1,46 @@ 
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/ene-kb3930.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ENE KB3930 Embedded Controller bindings
+
+description: |
+  This binding describes the ENE KB3930 Embedded Controller attached to a
+  I2C bus.
+
+maintainers:
+  - Lubomir Rintel <lkundrak@v3.sk>
+
+properties:
+  compatible:
+    const: ene,kb3930
+
+  reg:
+    maxItems: 1
+
+  power-gpios:
+    description: GPIO used for the power pin
+    maxItems: 2
+
+  system-power-controller: true
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    embedded-controller@58 {
+      compatible = "ene,kb3930";
+      reg = <0x58>;
+      system-power-controller;
+
+      off-gpios = <&gpio 126 GPIO_ACTIVE_HIGH>,
+                  <&gpio 127 GPIO_ACTIVE_HIGH>;
+    };
+
+...