diff mbox series

[v2,1/3] dt-bindings: Add vendor prefix for Caninos Loucos

Message ID 20200307002453.350430-2-matheus@castello.eng.br
State Superseded, archived
Headers show
Series [v2,1/3] dt-bindings: Add vendor prefix for Caninos Loucos | expand

Checks

Context Check Description
robh/checkpatch success
robh/dt-meta-schema success

Commit Message

Matheus Castello March 7, 2020, 12:24 a.m. UTC
The Caninos Loucos Program develops Single Board Computers with an open
structure. The Program wants to form a community of developers to use
the IoT technology and disseminate the learning of embedded systems in
Brazil.

The boards are designed and manufactured by LSI-TEC NPO.

Signed-off-by: Matheus Castello <matheus@castello.eng.br>
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)

--
2.25.0

Comments

Andreas Färber March 7, 2020, 12:34 p.m. UTC | #1
Hi Matheus,

Am 07.03.20 um 01:24 schrieb Matheus Castello:
> The Caninos Loucos Program develops Single Board Computers with an open
> structure. The Program wants to form a community of developers to use
> the IoT technology and disseminate the learning of embedded systems in

I would suggest "IoT technologies" without "the".

> Brazil.
> 
> The boards are designed and manufactured by LSI-TEC NPO.
> 
> Signed-off-by: Matheus Castello <matheus@castello.eng.br>
> ---
>   Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 9e67944bec9c..3e974dd563cf 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -167,6 +167,8 @@ patternProperties:
>       description: Calxeda
>     "^capella,.*":
>       description: Capella Microsystems, Inc
> +  "^caninos,.*":
> +    description: Caninos Loucos LSI-TEC NPO

Alphabetical order: n goes before p.

I'm confused by the description... Either this Caninos Loucos is an 
independent vendor and gets its own prefix, or it's LSI-Tec and uses 
something like lsi-tec,caninosloucos-foo. Please clarify commit message 
and/or description line, at least by inserting something like "program 
by", "brand by" or the like rather than just concatenating names. Maybe 
compare UDOO by SECO. Is caninos,foo unique enough or should it be 
caninosloucos,foo? (crazy canines?)

Note that I usually attempt to CC the organizations I'm assigning a 
vendor prefix for. Do you represent them or coordinated with them?

Regards,
Andreas

>     "^cascoda,.*":
>       description: Cascoda, Ltd.
>     "^catalyst,.*":
Matheus Castello March 11, 2020, 4:04 a.m. UTC | #2
Hi Andreas,

Em 3/7/20 9:34 AM, Andreas Färber escreveu:
> Hi Matheus,
> 
> Am 07.03.20 um 01:24 schrieb Matheus Castello:
>> The Caninos Loucos Program develops Single Board Computers with an open
>> structure. The Program wants to form a community of developers to use
>> the IoT technology and disseminate the learning of embedded systems in
> 
> I would suggest "IoT technologies" without "the".
> 

ack

>> Brazil.
>>
>> The boards are designed and manufactured by LSI-TEC NPO.
>>
>> Signed-off-by: Matheus Castello <matheus@castello.eng.br>
>> ---
>>   Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml 
>> b/Documentation/devicetree/bindings/vendor-prefixes.yaml
>> index 9e67944bec9c..3e974dd563cf 100644
>> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
>> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
>> @@ -167,6 +167,8 @@ patternProperties:
>>       description: Calxeda
>>     "^capella,.*":
>>       description: Capella Microsystems, Inc
>> +  "^caninos,.*":
>> +    description: Caninos Loucos LSI-TEC NPO
> 

I will change this to "Caninos Loucos Program"

> Alphabetical order: n goes before p.
> 
> I'm confused by the description... Either this Caninos Loucos is an 
> independent vendor and gets its own prefix, or it's LSI-Tec and uses 
> something like lsi-tec,caninosloucos-foo. Please clarify commit message 
> and/or description line, at least by inserting something like "program 
> by", "brand by" or the like rather than just concatenating names. Maybe 
> compare UDOO by SECO. Is caninos,foo unique enough or should it be 
> caninosloucos,foo? (crazy canines?)
> 

Yes "Caninos Loucos" means crazy canines (or mad dog) in Portuguese. 
This is a initiative that have as co-founder the Jon Maddog Hall, 
because of Jon we have the "maddog", but in Portuguese, on the name of 
program.

 From their website: https://caninosloucos.org/en/program-en/:
"It is an initiative of the Technological Integrated Systems Laboratory 
(LSI-TEC) with the support of Polytechnic School of the University of 
São Paulo (Poli-USP) and Jon “Maddog” Hall"

So I think we can put this instead "The boards are designed and 
manufactured by LSI-TEC NPO." on description.

Let me know what you think about this.

> Note that I usually attempt to CC the organizations I'm assigning a 
> vendor prefix for. Do you represent them or coordinated with them?
>

Thanks for the review and tips. I am adding Edgar Bernardi Righi and 
Igor Ruschi from Caninos team as CC on this patch series.

Best Regards,
Matheus Castello

> Regards,
> Andreas
>
>>     "^cascoda,.*":
>>       description: Cascoda, Ltd.
>>     "^catalyst,.*":
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 9e67944bec9c..3e974dd563cf 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -167,6 +167,8 @@  patternProperties:
     description: Calxeda
   "^capella,.*":
     description: Capella Microsystems, Inc
+  "^caninos,.*":
+    description: Caninos Loucos LSI-TEC NPO
   "^cascoda,.*":
     description: Cascoda, Ltd.
   "^catalyst,.*":