| Message ID | 20200121200011.32296-1-kdasu.kdev@gmail.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [V2,1/3] dt: bindings: brcmnand: Add support for flash-edu | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On 1/21/20 12:00 PM, Kamal Dasu wrote: > Nand controller v5.0 and v6.0 have nand edu blocks that enable > dma nand flash transfers. This allows for faster read and write > access. > > Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Hi Kamal, On Tue, Jan 21, 2020 at 03:00:07PM -0500, Kamal Dasu wrote: > Nand controller v5.0 and v6.0 have nand edu blocks that enable > dma nand flash transfers. This allows for faster read and write > access. > > Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com> > --- > arch/mips/boot/dts/brcm/bcm7425.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/mips/boot/dts/brcm/bcm7425.dtsi b/arch/mips/boot/dts/brcm/bcm7425.dtsi > index 410e61ebaf9e..aa0b2d39c902 100644 > --- a/arch/mips/boot/dts/brcm/bcm7425.dtsi > +++ b/arch/mips/boot/dts/brcm/bcm7425.dtsi > @@ -403,8 +403,8 @@ > compatible = "brcm,brcmnand-v5.0", "brcm,brcmnand"; > #address-cells = <1>; > #size-cells = <0>; > - reg-names = "nand"; > - reg = <0x41b800 0x400>; > + reg-names = "nand", "flash-edu"; > + reg = <0x41b800 0x400>, <0x41bc00 0x24>; > interrupt-parent = <&hif_l2_intc>; > interrupts = <24>; > status = "disabled"; I wasn't copied on the rest of the series, but presuming patch 1 documents flash-edu in the binding documentation at Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt: Acked-by: Paul Burton <paulburton@kernel.org> Thanks, Paul
On Tue, 21 Jan 2020 15:00:06 -0500, Kamal Dasu wrote: > Adding support for EBI DMA unit (EDU). > > Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com> > --- > .../devicetree/bindings/mtd/brcm,brcmnand.txt | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. If a tag was not added on purpose, please state why and what changed.
diff --git a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt index 82156dc8f304..05651a654c66 100644 --- a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt +++ b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt @@ -35,11 +35,11 @@ Required properties: (optional) NAND flash cache range (if at non-standard offset) - reg-names : a list of the names corresponding to the previous register ranges. Should contain "nand" and (optionally) - "flash-dma" and/or "nand-cache". -- interrupts : The NAND CTLRDY interrupt and (if Flash DMA is available) - FLASH_DMA_DONE -- interrupt-names : May be "nand_ctlrdy" or "flash_dma_done", if broken out as - individual interrupts. + "flash-dma" or "flash-edu" and/or "nand-cache". +- interrupts : The NAND CTLRDY interrupt, (if Flash DMA is available) + FLASH_DMA_DONE and if EDU is avaialble and used FLASH_EDU_DONE +- interrupt-names : May be "nand_ctlrdy" or "flash_dma_done" or "flash_edu_done", + if broken out as individual interrupts. May be "nand", if the SoC has the individual NAND interrupts multiplexed behind another custom piece of hardware
Adding support for EBI DMA unit (EDU). Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com> --- .../devicetree/bindings/mtd/brcm,brcmnand.txt | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)