| Message ID | 20191220065314.237624-4-lkundrak@v3.sk |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [1/5] dt-bindings: marvell,mmp2: Add clock ids for the HSIC clocks | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | fail | build log |
On Fri, Dec 20, 2019 at 1:01 AM Lubomir Rintel <lkundrak@v3.sk> wrote: > > This is the PHY chip for USB HSIC on MMP3 platform. > > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk> > --- > .../bindings/phy/marvell,mmp3-hsic-phy.yaml | 41 +++++++++++++++++++ > 1 file changed, 41 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml Seems this is already in -next, but it breaks dt_binding_check. > > diff --git a/Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml b/Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml > new file mode 100644 > index 0000000000000..7917a95cda78d > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml > @@ -0,0 +1,41 @@ > +# SPDX-License-Identifier: GPL-2.0-or-later Dual license new bindings: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright 2019 Lubomir Rintel <lkundrak@v3.sk> > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/phy/marvell,mmp3-hsic-phy.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Marvell MMP3 HSIC PHY > + > +maintainers: > + - Lubomir Rintel <lkundrak@v3.sk> > + > +properties: > + compatible: > + const: marvell,mmp3-hsic-phy > + > + reg: > + maxItems: 1 > + description: base address of the device Drop description. That's *every* 'reg' property. > + > + reset-gpios: > + maxItems: 1 > + description: GPIO connected to reset > + > + "#phy-cells": > + const: 0 > + > +required: > + - compatible > + - reg > + - reset-gpios > + - "#phy-cells" > + > +examples: > + - | > + hsic-phy@f0001800 { > + compatible = "marvell,mmp3-hsic-phy"; > + reg = <0xf0001800 0x40>; > + reset-gpios = <&gpio 63 GPIO_ACTIVE_HIGH>; Examples are built now and this one doesn't. You need the include for the define. Check with 'make dt_binding_check'. > + #phy-cells = <0>; > + }; > -- > 2.24.1 >
diff --git a/Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml b/Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml new file mode 100644 index 0000000000000..7917a95cda78d --- /dev/null +++ b/Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml @@ -0,0 +1,41 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# Copyright 2019 Lubomir Rintel <lkundrak@v3.sk> +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/phy/marvell,mmp3-hsic-phy.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Marvell MMP3 HSIC PHY + +maintainers: + - Lubomir Rintel <lkundrak@v3.sk> + +properties: + compatible: + const: marvell,mmp3-hsic-phy + + reg: + maxItems: 1 + description: base address of the device + + reset-gpios: + maxItems: 1 + description: GPIO connected to reset + + "#phy-cells": + const: 0 + +required: + - compatible + - reg + - reset-gpios + - "#phy-cells" + +examples: + - | + hsic-phy@f0001800 { + compatible = "marvell,mmp3-hsic-phy"; + reg = <0xf0001800 0x40>; + reset-gpios = <&gpio 63 GPIO_ACTIVE_HIGH>; + #phy-cells = <0>; + };
This is the PHY chip for USB HSIC on MMP3 platform. Signed-off-by: Lubomir Rintel <lkundrak@v3.sk> --- .../bindings/phy/marvell,mmp3-hsic-phy.yaml | 41 +++++++++++++++++++ 1 file changed, 41 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml