| Message ID | 20191025102915.23677-2-chunyan.zhang@unisoc.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Add Unisoc's SC9863A support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
Hi Chunyan, On Fri, Oct 25, 2019 at 6:30 PM Chunyan Zhang <chunyan.zhang@unisoc.com> wrote: > > > SC9863A use the same serial device which SC9836 uses. > > Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com> > --- > Documentation/devicetree/bindings/serial/sprd-uart.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.txt b/Documentation/devicetree/bindings/serial/sprd-uart.txt > index 9607dc616205..0a9f8a7809e1 100644 > --- a/Documentation/devicetree/bindings/serial/sprd-uart.txt > +++ b/Documentation/devicetree/bindings/serial/sprd-uart.txt > @@ -4,6 +4,7 @@ Required properties: > - compatible: must be one of: > * "sprd,sc9836-uart" > * "sprd,sc9860-uart", "sprd,sc9836-uart" > + * "sprd,sc9863-uart", "sprd,sc9836-uart" Duplicated 9836 with above line? -Orson > > - reg: offset and length of the register set for the device > - interrupts: exactly one interrupt specifier > -- > 2.20.1 > >
On Sat, 26 Oct 2019 at 10:11, Orson Zhai <orsonzhai@gmail.com> wrote: > > Hi Chunyan, > > On Fri, Oct 25, 2019 at 6:30 PM Chunyan Zhang <chunyan.zhang@unisoc.com> wrote: > > > > > > SC9863A use the same serial device which SC9836 uses. > > > > Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com> > > --- > > Documentation/devicetree/bindings/serial/sprd-uart.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.txt b/Documentation/devicetree/bindings/serial/sprd-uart.txt > > index 9607dc616205..0a9f8a7809e1 100644 > > --- a/Documentation/devicetree/bindings/serial/sprd-uart.txt > > +++ b/Documentation/devicetree/bindings/serial/sprd-uart.txt > > @@ -4,6 +4,7 @@ Required properties: > > - compatible: must be one of: > > * "sprd,sc9836-uart" > > * "sprd,sc9860-uart", "sprd,sc9836-uart" > > + * "sprd,sc9863-uart", "sprd,sc9836-uart" > > Duplicated 9836 with above line? We can just use "sprd,sc9836-uart" for SC9860 and SC9863 SoCs though, added a new compatible string in case we'll have some difference for serial on SC9863A in the furture. Thanks, Chunyan > > -Orson > > > > > - reg: offset and length of the register set for the device > > - interrupts: exactly one interrupt specifier > > -- > > 2.20.1 > > > >
On Fri, 25 Oct 2019 18:29:13 +0800, Chunyan Zhang wrote: > > SC9863A use the same serial device which SC9836 uses. > > Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com> > --- > Documentation/devicetree/bindings/serial/sprd-uart.txt | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring <robh@kernel.org>
On Wed, 30 Oct 2019 at 05:44, Rob Herring <robh@kernel.org> wrote: > > On Fri, 25 Oct 2019 18:29:13 +0800, Chunyan Zhang wrote: > > > > SC9863A use the same serial device which SC9836 uses. > > > > Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com> > > --- > > Documentation/devicetree/bindings/serial/sprd-uart.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > Acked-by: Rob Herring <robh@kernel.org> Should we convert this to yaml schema as well? Thanks, Chunyan
diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.txt b/Documentation/devicetree/bindings/serial/sprd-uart.txt index 9607dc616205..0a9f8a7809e1 100644 --- a/Documentation/devicetree/bindings/serial/sprd-uart.txt +++ b/Documentation/devicetree/bindings/serial/sprd-uart.txt @@ -4,6 +4,7 @@ Required properties: - compatible: must be one of: * "sprd,sc9836-uart" * "sprd,sc9860-uart", "sprd,sc9836-uart" + * "sprd,sc9863-uart", "sprd,sc9836-uart" - reg: offset and length of the register set for the device - interrupts: exactly one interrupt specifier
SC9863A use the same serial device which SC9836 uses. Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com> --- Documentation/devicetree/bindings/serial/sprd-uart.txt | 1 + 1 file changed, 1 insertion(+)