diff mbox series

[1/2] dt-bindings: iio: imu: add fxos8700 imu binding

Message ID 20190918012856.18963-2-rjones@gateworks.com
State Changes Requested, archived
Headers show
Series iio: imu: add support for FXOS8700 | expand

Checks

Context Check Description
robh/checkpatch warning "total: 0 errors, 1 warnings, 15 lines checked"

Commit Message

Robert Jones Sept. 18, 2019, 1:28 a.m. UTC
This adds documentation for the Freescale FXOS8700 Inertial Measurement Unit
device-tree bindings.

Signed-off-by: Robert Jones <rjones@gateworks.com>
---
 Documentation/devicetree/bindings/iio/imu/fxos8700.txt | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/imu/fxos8700.txt

Comments

Rob Herring (Arm) Oct. 1, 2019, 11:39 a.m. UTC | #1
On Tue, Sep 17, 2019 at 06:28:55PM -0700, Robert Jones wrote:
> This adds documentation for the Freescale FXOS8700 Inertial Measurement Unit
> device-tree bindings.
> 
> Signed-off-by: Robert Jones <rjones@gateworks.com>
> ---
>  Documentation/devicetree/bindings/iio/imu/fxos8700.txt | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/imu/fxos8700.txt

Please convert to a DT schema. See Documentation/devicetree/writing-schema.rst.

> 
> diff --git a/Documentation/devicetree/bindings/iio/imu/fxos8700.txt b/Documentation/devicetree/bindings/iio/imu/fxos8700.txt
> new file mode 100644
> index 0000000..770605d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/imu/fxos8700.txt
> @@ -0,0 +1,15 @@
> +Freescale FXOS8700 - Inertial Measurement Unit with Accelerometer and Magnetometer
> +
> +https://www.nxp.com/products/sensors/motion-sensors/6-axis/digital-motion-sensor-3d-accelerometer-2g-4g-8g-plus-3d-magnetometer:FXOS8700CQ
> +
> +Required properties:
> + - compatible : must be "fsl,fxos8700"
> + - reg : the I2C address or SPI chip select number of the device
> + - spi-max-frequency : set maximum clock frequency (only for SPI)

Looks like the device has 2 interrupts, 2 supplies, and a reset line. 
Please make the binding complete even if the driver or you board doesn't 
support some things yet.

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/imu/fxos8700.txt b/Documentation/devicetree/bindings/iio/imu/fxos8700.txt
new file mode 100644
index 0000000..770605d
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/imu/fxos8700.txt
@@ -0,0 +1,15 @@ 
+Freescale FXOS8700 - Inertial Measurement Unit with Accelerometer and Magnetometer
+
+https://www.nxp.com/products/sensors/motion-sensors/6-axis/digital-motion-sensor-3d-accelerometer-2g-4g-8g-plus-3d-magnetometer:FXOS8700CQ
+
+Required properties:
+ - compatible : must be "fsl,fxos8700"
+ - reg : the I2C address or SPI chip select number of the device
+ - spi-max-frequency : set maximum clock frequency (only for SPI)
+
+Example:
+
+bmi160@1e {
+	compatible = "fsl,fxos8700";
+	reg = <0x1e>;
+};