| Message ID | 20190310182836.20841-5-jacek.anaszewski@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add generic support for composing LED class device name | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
Jacek On 3/10/19 1:28 PM, Jacek Anaszewski wrote: > Add common LED color name definitions for use in Device Tree. > > Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> > Cc: Baolin Wang <baolin.wang@linaro.org> > Cc: Daniel Mack <daniel@zonque.org> > Cc: Dan Murphy <dmurphy@ti.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Oleh Kravchenko <oleg@kaa.org.ua> > Cc: Sakari Ailus <sakari.ailus@linux.intel.com> > Cc: Simon Shields <simon@lineageos.org> > --- > include/dt-bindings/leds/common.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h > index ffcd46317307..0e986bb59391 100644 > --- a/include/dt-bindings/leds/common.h > +++ b/include/dt-bindings/leds/common.h > @@ -57,4 +57,13 @@ > #define LED_FUNCTION_WLAN "wlan" > #define LED_FUNCTION_WPS "wps" > > +/* Standard LED colors */ > +#define LED_COLOR_NAME_WHITE "white" > +#define LED_COLOR_NAME_RED "red" > +#define LED_COLOR_NAME_GREEN "green" > +#define LED_COLOR_NAME_BLUE "blue" > +#define LED_COLOR_NAME_AMBER "amber" > +#define LED_COLOR_NAME_VIOLET "violet" > +#define LED_COLOR_NAME_YELLOW "yellow" > + #define LED_COLOR_NAME_INFRARED "ir" Dan > #endif /* __DT_BINDINGS_LEDS_H */ >
Dan, On 3/11/19 1:23 PM, Dan Murphy wrote: > Jacek > > On 3/10/19 1:28 PM, Jacek Anaszewski wrote: >> Add common LED color name definitions for use in Device Tree. >> >> Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> >> Cc: Baolin Wang <baolin.wang@linaro.org> >> Cc: Daniel Mack <daniel@zonque.org> >> Cc: Dan Murphy <dmurphy@ti.com> >> Cc: Linus Walleij <linus.walleij@linaro.org> >> Cc: Oleh Kravchenko <oleg@kaa.org.ua> >> Cc: Sakari Ailus <sakari.ailus@linux.intel.com> >> Cc: Simon Shields <simon@lineageos.org> >> --- >> include/dt-bindings/leds/common.h | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h >> index ffcd46317307..0e986bb59391 100644 >> --- a/include/dt-bindings/leds/common.h >> +++ b/include/dt-bindings/leds/common.h >> @@ -57,4 +57,13 @@ >> #define LED_FUNCTION_WLAN "wlan" >> #define LED_FUNCTION_WPS "wps" >> >> +/* Standard LED colors */ >> +#define LED_COLOR_NAME_WHITE "white" >> +#define LED_COLOR_NAME_RED "red" >> +#define LED_COLOR_NAME_GREEN "green" >> +#define LED_COLOR_NAME_BLUE "blue" >> +#define LED_COLOR_NAME_AMBER "amber" >> +#define LED_COLOR_NAME_VIOLET "violet" >> +#define LED_COLOR_NAME_YELLOW "yellow" >> + > > #define LED_COLOR_NAME_INFRARED "ir" Ack. > Dan > >> #endif /* __DT_BINDINGS_LEDS_H */ >> > >
On Sun 2019-03-10 19:28:15, Jacek Anaszewski wrote: > Add common LED color name definitions for use in Device Tree. Could we do "LED_COLOR_NAME_" => "LED_COLOR_"? Pavel > Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> > Cc: Baolin Wang <baolin.wang@linaro.org> > Cc: Daniel Mack <daniel@zonque.org> > Cc: Dan Murphy <dmurphy@ti.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Oleh Kravchenko <oleg@kaa.org.ua> > Cc: Sakari Ailus <sakari.ailus@linux.intel.com> > Cc: Simon Shields <simon@lineageos.org> > --- > include/dt-bindings/leds/common.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h > index ffcd46317307..0e986bb59391 100644 > --- a/include/dt-bindings/leds/common.h > +++ b/include/dt-bindings/leds/common.h > @@ -57,4 +57,13 @@ > #define LED_FUNCTION_WLAN "wlan" > #define LED_FUNCTION_WPS "wps" > > +/* Standard LED colors */ > +#define LED_COLOR_NAME_WHITE "white" > +#define LED_COLOR_NAME_RED "red" > +#define LED_COLOR_NAME_GREEN "green" > +#define LED_COLOR_NAME_BLUE "blue" > +#define LED_COLOR_NAME_AMBER "amber" > +#define LED_COLOR_NAME_VIOLET "violet" > +#define LED_COLOR_NAME_YELLOW "yellow" > + > #endif /* __DT_BINDINGS_LEDS_H */
On Sun, Mar 10, 2019 at 07:28:15PM +0100, Jacek Anaszewski wrote: > Add common LED color name definitions for use in Device Tree. Do we actually have variations in color strings? Maybe someone uses "RED" or something. If not, I think this adds less value compared to function names. Just my 2 cents, either way is fine. > > Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> > Cc: Baolin Wang <baolin.wang@linaro.org> > Cc: Daniel Mack <daniel@zonque.org> > Cc: Dan Murphy <dmurphy@ti.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Oleh Kravchenko <oleg@kaa.org.ua> > Cc: Sakari Ailus <sakari.ailus@linux.intel.com> > Cc: Simon Shields <simon@lineageos.org> > --- > include/dt-bindings/leds/common.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h > index ffcd46317307..0e986bb59391 100644 > --- a/include/dt-bindings/leds/common.h > +++ b/include/dt-bindings/leds/common.h > @@ -57,4 +57,13 @@ > #define LED_FUNCTION_WLAN "wlan" > #define LED_FUNCTION_WPS "wps" > > +/* Standard LED colors */ > +#define LED_COLOR_NAME_WHITE "white" > +#define LED_COLOR_NAME_RED "red" > +#define LED_COLOR_NAME_GREEN "green" > +#define LED_COLOR_NAME_BLUE "blue" > +#define LED_COLOR_NAME_AMBER "amber" > +#define LED_COLOR_NAME_VIOLET "violet" > +#define LED_COLOR_NAME_YELLOW "yellow" > + > #endif /* __DT_BINDINGS_LEDS_H */ > -- > 2.11.0 >
diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h index ffcd46317307..0e986bb59391 100644 --- a/include/dt-bindings/leds/common.h +++ b/include/dt-bindings/leds/common.h @@ -57,4 +57,13 @@ #define LED_FUNCTION_WLAN "wlan" #define LED_FUNCTION_WPS "wps" +/* Standard LED colors */ +#define LED_COLOR_NAME_WHITE "white" +#define LED_COLOR_NAME_RED "red" +#define LED_COLOR_NAME_GREEN "green" +#define LED_COLOR_NAME_BLUE "blue" +#define LED_COLOR_NAME_AMBER "amber" +#define LED_COLOR_NAME_VIOLET "violet" +#define LED_COLOR_NAME_YELLOW "yellow" + #endif /* __DT_BINDINGS_LEDS_H */
Add common LED color name definitions for use in Device Tree. Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> Cc: Baolin Wang <baolin.wang@linaro.org> Cc: Daniel Mack <daniel@zonque.org> Cc: Dan Murphy <dmurphy@ti.com> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Oleh Kravchenko <oleg@kaa.org.ua> Cc: Sakari Ailus <sakari.ailus@linux.intel.com> Cc: Simon Shields <simon@lineageos.org> --- include/dt-bindings/leds/common.h | 9 +++++++++ 1 file changed, 9 insertions(+)