| Message ID | 20181023155035.9101-14-jagan@amarulasolutions.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | drm/sun4i: Allwinner A64 MIPI-DSI support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Tue, Oct 23, 2018 at 09:20:33PM +0530, Jagan Teki wrote: > The MIPI DSI PHY HDMI controller on Allwinner A64 is similar > on the one on A31. > > Add A64 compatible and append A31 compatible as fallback. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > Changes for v2: > - new patch > > Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt b/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt > index 9fa6e7a758ad..704fb31962f2 100644 > --- a/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt > +++ b/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt > @@ -36,7 +36,7 @@ D-PHY > > Required properties: > - compatible: value must be one of: > - * allwinner,sun6i-a31-mipi-dphy > + * "allwinner,sun50i-a64-mipi-dphy", "allwinner,sun6i-a31-mipi-dphy" No. you need both. The A64 MIPI DPHY one needs to be always set with the A31 fallback, but the A31 is also usable on its own. Maxime
On Wed, Oct 24, 2018 at 11:39 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > On Tue, Oct 23, 2018 at 09:20:33PM +0530, Jagan Teki wrote: > > The MIPI DSI PHY HDMI controller on Allwinner A64 is similar > > on the one on A31. > > > > Add A64 compatible and append A31 compatible as fallback. > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > --- > > Changes for v2: > > - new patch > > > > Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt b/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt > > index 9fa6e7a758ad..704fb31962f2 100644 > > --- a/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt > > +++ b/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt > > @@ -36,7 +36,7 @@ D-PHY > > > > Required properties: > > - compatible: value must be one of: > > - * allwinner,sun6i-a31-mipi-dphy > > + * "allwinner,sun50i-a64-mipi-dphy", "allwinner,sun6i-a31-mipi-dphy" > > No. you need both. The A64 MIPI DPHY one needs to be always set with > the A31 fallback, but the A31 is also usable on its own. Why wouldn't be, because we don't have any difference dphy right?
On Thu, Oct 25, 2018 at 06:22:51PM +0530, Jagan Teki wrote: > On Wed, Oct 24, 2018 at 11:39 PM Maxime Ripard > <maxime.ripard@bootlin.com> wrote: > > > > On Tue, Oct 23, 2018 at 09:20:33PM +0530, Jagan Teki wrote: > > > The MIPI DSI PHY HDMI controller on Allwinner A64 is similar > > > on the one on A31. > > > > > > Add A64 compatible and append A31 compatible as fallback. > > > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > > --- > > > Changes for v2: > > > - new patch > > > > > > Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt b/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt > > > index 9fa6e7a758ad..704fb31962f2 100644 > > > --- a/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt > > > +++ b/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt > > > @@ -36,7 +36,7 @@ D-PHY > > > > > > Required properties: > > > - compatible: value must be one of: > > > - * allwinner,sun6i-a31-mipi-dphy > > > + * "allwinner,sun50i-a64-mipi-dphy", "allwinner,sun6i-a31-mipi-dphy" > > > > No. you need both. The A64 MIPI DPHY one needs to be always set with > > the A31 fallback, but the A31 is also usable on its own. > > Why wouldn't be, because we don't have any difference dphy right? That's not my point. You removed from the binding documentation that allwinner,sun6i-a31-mipi-dphy was a valid option on its own. It's not ok to do so. Maxime
diff --git a/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt b/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt index 9fa6e7a758ad..704fb31962f2 100644 --- a/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt +++ b/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt @@ -36,7 +36,7 @@ D-PHY Required properties: - compatible: value must be one of: - * allwinner,sun6i-a31-mipi-dphy + * "allwinner,sun50i-a64-mipi-dphy", "allwinner,sun6i-a31-mipi-dphy" - reg: base address and size of memory-mapped region - clocks: phandles to the clocks feeding the DSI encoder * bus: the DSI interface clock
The MIPI DSI PHY HDMI controller on Allwinner A64 is similar on the one on A31. Add A64 compatible and append A31 compatible as fallback. Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- Changes for v2: - new patch Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)