From patchwork Tue Aug 7 05:14:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Douglas Anderson X-Patchwork-Id: 954361 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=reject dis=none) header.from=chromium.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="XmfVoMdb"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41l2lG0f15z9s4s for ; Tue, 7 Aug 2018 15:15:06 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727123AbeHGH1T (ORCPT ); Tue, 7 Aug 2018 03:27:19 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:35318 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728261AbeHGH1T (ORCPT ); Tue, 7 Aug 2018 03:27:19 -0400 Received: by mail-pf1-f194.google.com with SMTP id p12-v6so7971754pfh.2 for ; Mon, 06 Aug 2018 22:14:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FYmgDqGIYZE7AwVwri2JVn1gQgTGaRcVTGj7r05KcB8=; b=XmfVoMdbLXyKZtxynE6K/a+8+EAnv5m0CXInAiPYlq66qPGJPE4tPiTk6rzRLd3ue9 Q8nAMGvJnjdpacNsKuf9DCUlgm6SP5VT3AoWTf32HQ0OquHIOaR0jJOeF7iUo0WyKHUH AhT+pTZC43DFnrKNtqhBZLBHAGIc03pUAADWM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FYmgDqGIYZE7AwVwri2JVn1gQgTGaRcVTGj7r05KcB8=; b=bHManv0TtI3nPRymDuZWTjJuk+WE3q8Mmw1Bqh0M8TMXFaCQrCo4D3Z4yCwdW2zBA9 Gmsf+T0Gg75ykzJyC/yMz8PHAn8BN0W5DHq5ga8E98U+V8OoRpg0OI4TONruLcWd+++a ahg28Z2hxTZSMULi+PRRR1rZOsWqLOa2y189FClvi3BozTEWB6O4iiR4Plo8gmVJjJW0 ojn9XDOuOrRhq69MFwAQG/oA/hrVZtQiSrkMx6/seZIXa58D06QbyC0ozdYhvYeq3SYd vVwTfElAM++aLQzZpU4w2K9T2dVzLjVTSGupzW4Ao3q4d35ercJnwOjHTBKhRajydRM/ zfUA== X-Gm-Message-State: AOUpUlExznfgZQcQxi+ytKQYtVQCjKWQ4L6K6H3GDAATlcji22k0JbU3 45rzcSRz5rMYitgYRxGGJyN+Hw== X-Google-Smtp-Source: AAOMgpfJbqcrmr41soYMJXQeQLIAfYfybwywNg40ZbJDln4ur/Y3IIbCqkG5eBLttsBsSwYY6r/fFw== X-Received: by 2002:a63:c00b:: with SMTP id h11-v6mr16707570pgg.279.1533618886202; Mon, 06 Aug 2018 22:14:46 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:c8e0:70d7:4be7:a36]) by smtp.gmail.com with ESMTPSA id i3-v6sm373164pgq.35.2018.08.06.22.14.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Aug 2018 22:14:45 -0700 (PDT) From: Douglas Anderson To: Rob Herring , Kishon Vijay Abraham I Cc: Douglas Anderson , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manu Gautam , Mark Rutland , Varadarajan Narayanan Subject: [PATCH] dt-bindings: phy: qcom-qmp: Cleanup the 'reg' documentation as per review Date: Mon, 6 Aug 2018 22:14:12 -0700 Message-Id: <20180807051412.126003-1-dianders@chromium.org> X-Mailer: git-send-email 2.18.0.597.ga71716f1ad-goog MIME-Version: 1.0 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org After the commit 8b1087fa3a27 ("phy: qcom-qmp: Fix dts bindings to reflect reality") landed there was some review feedback that 'reg' should have been documented differently. Fix it as per review feedback. As per that feedback: - Subject should have been 'dt-bindings: phy:' which this patch now has. - We should leave no ambiguity in the ordering of 'reg' ranges even if 'reg-names' are also specified. - Normally using reg-names is discouraged unless there's a strong reason it's needed (like if there are optional ranges). In this case reg-names wasn't needed but the driver already landed relying on reg-names so we'll just document it and move on. Fixes: 8b1087fa3a27 ("phy: qcom-qmp: Fix dts bindings to reflect reality") Suggested-by: Rob Herring Signed-off-by: Douglas Anderson Reviewed-by: Rob Herring --- .../devicetree/bindings/phy/qcom-qmp-phy.txt | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt index 0c7629e88bf3..2b161bf15d5d 100644 --- a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt +++ b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt @@ -12,14 +12,17 @@ Required properties: "qcom,sdm845-qmp-usb3-phy" for USB3 QMP V3 phy on sdm845, "qcom,sdm845-qmp-usb3-uni-phy" for USB3 QMP V3 UNI phy on sdm845. - - reg: - - For "qcom,sdm845-qmp-usb3-phy": - - index 0: address and length of register set for PHY's common serdes - block. - - named register "dp_com" (using reg-names): address and length of the - DP_COM control block. - - For all others: - - offset and length of register set for PHY's common serdes block. +- reg: + - index 0: address and length of register set for PHY's common + serdes block. + - index 1: address and length of the DP_COM control block (for + "qcom,sdm845-qmp-usb3-phy" only). + +- reg-names: + - For "qcom,sdm845-qmp-usb3-phy": + - Should be: "reg-base", "dp_com" + - For all others: + - The reg-names property shouldn't be defined. - #clock-cells: must be 1 - Phy pll outputs a bunch of clocks for Tx, Rx and Pipe