| Message ID | 20180309174858.24017-1-s.nawrocki@samsung.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [v2,1/7] ASoC: max98090: Add #sound-dai-cells property documentation | expand |
On Fri, Mar 9, 2018 at 6:48 PM, Sylwester Nawrocki <s.nawrocki@samsung.com> wrote: > The RCLKSRC mux input 0 is a default configuration after reset, so > there is no need for this explicit snd_soc_dai_set_sysclk() call. > Also, this static mux clock configuration can be specified in DT. > > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > --- > Changes since v1: > - none. > --- > sound/soc/samsung/snow.c | 5 ----- > 1 file changed, 5 deletions(-) Acked-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Mar 9, 2018 at 6:48 PM, Sylwester Nawrocki <s.nawrocki@samsung.com> wrote: > This patch updates the driver so, in addition to current DT bindings, > the new DT bindings with cpu, codec subnodes can be used, in order to > support sound on the HDMI interface. > > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > --- > Changes since v1: > - adjustments to changed order of codecs in codec/cpu-dai property, > - fixed errors in snow_remove(). > --- > sound/soc/samsung/snow.c | 226 +++++++++++++++++++++++++++++++++++++---------- > 1 file changed, 178 insertions(+), 48 deletions(-) > > diff --git a/sound/soc/samsung/snow.c b/sound/soc/samsung/snow.c > index fc62110f500f..f00ca1ca0171 100644 > --- a/sound/soc/samsung/snow.c > +++ b/sound/soc/samsung/snow.c > @@ -11,92 +11,207 @@ > * General Public License for more details. > */ > > +#include <linux/clk.h> > #include <linux/module.h> > #include <linux/platform_device.h> > #include <linux/of.h> > #include <linux/of_device.h> > - > +#include <sound/pcm_params.h> > #include <sound/soc.h> > > #include "i2s.h" > > -#define FIN_PLL_RATE 24000000 > +#define FIN_PLL_RATE 24000000UL This change looks unrelated so how about making it separate patch? For the rest: Acked-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 03/12/2018 08:39 AM, Krzysztof Kozlowski wrote: >> -#define FIN_PLL_RATE 24000000 >> +#define FIN_PLL_RATE 24000000UL > > This change looks unrelated so how about making it separate patch? I knew you will find this! ;P I don't want to be making this kind of funny patches :), I can repost v3 in a few days with this bit removed.
On Mon, Mar 12, 2018 at 05:21:03PM +0100, Sylwester Nawrocki wrote: > On 03/12/2018 08:39 AM, Krzysztof Kozlowski wrote: > >> -#define FIN_PLL_RATE 24000000 > >> +#define FIN_PLL_RATE 24000000UL > > > > This change looks unrelated so how about making it separate patch? > > I knew you will find this! ;P I don't want to be making this kind > of funny patches :), I can repost v3 in a few days with this bit removed. Ah, you know, after working with crappy code and crappy history, I find very useful to have strict approach around changes. This one might be harmless... or you might be fixing some warning caught by your compiler thus it looks like nice candidate for seaprate patch. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/sound/max98090.txt b/Documentation/devicetree/bindings/sound/max98090.txt index 4e3be6682c98..7e1bbd5c27fd 100644 --- a/Documentation/devicetree/bindings/sound/max98090.txt +++ b/Documentation/devicetree/bindings/sound/max98090.txt @@ -16,6 +16,8 @@ Optional properties: - clock-names: Should be "mclk" +- #sound-dai-cells : should be 0. + - maxim,dmic-freq: Frequency at which to clock DMIC - maxim,micbias: Micbias voltage applies to the analog mic, valid voltages value are:
MAX98090 CODEC supports 1 input DAI, adding the #sound-dai-cells property helps to reference the DAI in DT in a standard way. Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> --- Changes since v1: - new patch. Documentation/devicetree/bindings/sound/max98090.txt | 2 ++ 1 file changed, 2 insertions(+) -- 2.14.2 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html