| Message ID | 20180205154403.13520-8-s.nawrocki@samsung.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | ASoC: samsung: Add HDMI sound support for tm2 board | expand |
On Mon, Feb 5, 2018 at 4:44 PM, Sylwester Nawrocki <s.nawrocki@samsung.com> wrote: > The #sound-dai-cells property might be helpful in selecting primary > or secondary CPU DAI and it's already present in i2s nodes for some > exynos SoCs so let's add it to the DT binding documentation. The description above looks like you are documenting existing optional property but you added it as a required property. Best regards, Krzysztof > > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > --- > Documentation/devicetree/bindings/sound/samsung-i2s.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/samsung-i2s.txt b/Documentation/devicetree/bindings/sound/samsung-i2s.txt > index 5d7bb2735824..dd1b6e329941 100644 > --- a/Documentation/devicetree/bindings/sound/samsung-i2s.txt > +++ b/Documentation/devicetree/bindings/sound/samsung-i2s.txt > @@ -54,6 +54,9 @@ in the IIS Multi Audio Interface. > Note: Old DTs may not have the #clock-cells property and then not use the I2S > node as a clock supplier. > > + - #sound-dai-cells: should be 1. > + > + > Optional SoC Specific Properties: > > - samsung,idma-addr: Internal DMA register base address of the audio > @@ -79,4 +82,5 @@ i2s0: i2s@3830000 { > samsung,idma-addr = <0x03000000>; > pinctrl-names = "default"; > pinctrl-0 = <&i2s0_bus>; > + #sound-dai-cells = <1>; > }; > -- > 2.14.2 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 02/06/2018 02:02 PM, Krzysztof Kozlowski wrote: > On Mon, Feb 5, 2018 at 4:44 PM, Sylwester Nawrocki > <s.nawrocki@samsung.com> wrote: >> The #sound-dai-cells property might be helpful in selecting primary >> or secondary CPU DAI and it's already present in i2s nodes for some >> exynos SoCs so let's add it to the DT binding documentation. > > The description above looks like you are documenting existing optional > property but you added it as a required property. Actually, it would be better to have it as a required property, but that could be done with any new device bindings. For the exisitng ones I will move this property to the "Optional SoC Specific Properties" paragraph.
diff --git a/Documentation/devicetree/bindings/sound/samsung-i2s.txt b/Documentation/devicetree/bindings/sound/samsung-i2s.txt index 5d7bb2735824..dd1b6e329941 100644 --- a/Documentation/devicetree/bindings/sound/samsung-i2s.txt +++ b/Documentation/devicetree/bindings/sound/samsung-i2s.txt @@ -54,6 +54,9 @@ in the IIS Multi Audio Interface. Note: Old DTs may not have the #clock-cells property and then not use the I2S node as a clock supplier. + - #sound-dai-cells: should be 1. + + Optional SoC Specific Properties: - samsung,idma-addr: Internal DMA register base address of the audio @@ -79,4 +82,5 @@ i2s0: i2s@3830000 { samsung,idma-addr = <0x03000000>; pinctrl-names = "default"; pinctrl-0 = <&i2s0_bus>; + #sound-dai-cells = <1>; };
The #sound-dai-cells property might be helpful in selecting primary or secondary CPU DAI and it's already present in i2s nodes for some exynos SoCs so let's add it to the DT binding documentation. Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> --- Documentation/devicetree/bindings/sound/samsung-i2s.txt | 4 ++++ 1 file changed, 4 insertions(+)