| Message ID | 20180103122609.5482-3-sebastian.reichel@collabora.co.uk |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | GEHC Bx50 Switch Support | expand |
On Wed, Jan 03, 2018 at 01:26:05PM +0100, Sebastian Reichel wrote: > Add compatible for Marvell 88E6240 switch. > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk> > --- > Documentation/devicetree/bindings/net/dsa/marvell.txt | 6 ++++-- > drivers/net/dsa/mv88e6xxx/chip.c | 4 ++++ > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/dsa/marvell.txt b/Documentation/devicetree/bindings/net/dsa/marvell.txt > index 1d4d0f49c9d0..cf437b526f7f 100644 > --- a/Documentation/devicetree/bindings/net/dsa/marvell.txt > +++ b/Documentation/devicetree/bindings/net/dsa/marvell.txt > @@ -14,8 +14,10 @@ The properties described here are those specific to Marvell devices. > Additional required and optional properties can be found in dsa.txt. > > Required properties: > -- compatible : Should be one of "marvell,mv88e6085" or > - "marvell,mv88e6190" > +- compatible : Should be one of the following > + * "marvell,mv88e6085" > + * "marvell,mv88e6190" > + * "marvell,mv88e6240" Hi Sebastian This is not required. The 6240 is compatible with the 6085, so please use "marvell,mv88e6085". We don't add compatible strings per device. All the compatible string is used for is to find the ID register in the device. Nothing more. Andrew -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/net/dsa/marvell.txt b/Documentation/devicetree/bindings/net/dsa/marvell.txt index 1d4d0f49c9d0..cf437b526f7f 100644 --- a/Documentation/devicetree/bindings/net/dsa/marvell.txt +++ b/Documentation/devicetree/bindings/net/dsa/marvell.txt @@ -14,8 +14,10 @@ The properties described here are those specific to Marvell devices. Additional required and optional properties can be found in dsa.txt. Required properties: -- compatible : Should be one of "marvell,mv88e6085" or - "marvell,mv88e6190" +- compatible : Should be one of the following + * "marvell,mv88e6085" + * "marvell,mv88e6190" + * "marvell,mv88e6240" - reg : Address on the MII bus for the switch. Optional properties: diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 66d33e97cbc5..78ff06239b58 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -4012,6 +4012,10 @@ static const struct of_device_id mv88e6xxx_of_match[] = { .compatible = "marvell,mv88e6190", .data = &mv88e6xxx_table[MV88E6190], }, + { + .compatible = "marvell,mv88e6240", + .data = &mv88e6xxx_table[MV88E6240], + }, { /* sentinel */ }, };
Add compatible for Marvell 88E6240 switch. Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk> --- Documentation/devicetree/bindings/net/dsa/marvell.txt | 6 ++++-- drivers/net/dsa/mv88e6xxx/chip.c | 4 ++++ 2 files changed, 8 insertions(+), 2 deletions(-)