From patchwork Tue Nov 12 17:40:01 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sebastian Andrzej Siewior X-Patchwork-Id: 290736 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 826392C00A4 for ; Wed, 13 Nov 2013 04:41:08 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932188Ab3KLRlF (ORCPT ); Tue, 12 Nov 2013 12:41:05 -0500 Received: from www.linutronix.de ([62.245.132.108]:48757 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932182Ab3KLRkD convert rfc822-to-8bit (ORCPT ); Tue, 12 Nov 2013 12:40:03 -0500 Received: from bigeasy by Galois.linutronix.de with local (Exim 4.72) (envelope-from ) id 1VgHwX-00083P-6f; Tue, 12 Nov 2013 18:40:01 +0100 Date: Tue, 12 Nov 2013 18:40:01 +0100 From: Sebastian Andrzej Siewior To: Kumar Gala Cc: Dmitry Torokhov , linux-input@vger.kernel.org, Felipe Balbi , Grant Likely , Rob Herring , devicetree@vger.kernel.org, o2g.org.ru@gmail.com Subject: [PATCH v2] input: ti_am33x_tsc: make the documentation for the ti,wire-config parameter clear Message-ID: <20131112174001.GA21881@linutronix.de> References: <1384273323-15329-1-git-send-email-bigeasy@linutronix.de> <5C68A2CC-A8C8-4B56-A414-B9EBE438F767@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5C68A2CC-A8C8-4B56-A414-B9EBE438F767@codeaurora.org> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The document says "first four bits" and means the upper nibble. Most people would probably agree that the first four bits are bits 0…3 and that is the lower nibble. This patch updates the documentation so it is clear what is meant. Signed-off-by: Sebastian Andrzej Siewior Acked-by: Kumar Gala --- v1…v2: - use most/least significant instead of upper/ lower nibble - add an example. .../devicetree/bindings/input/touchscreen/ti-tsc-adc.txt | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt b/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt index 491c97b..b25a2fe 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt +++ b/Documentation/devicetree/bindings/input/touchscreen/ti-tsc-adc.txt @@ -17,13 +17,16 @@ remaining 4 can be used by the ADC. ti,wire-config: Different boards could have a different order for connecting wires on touchscreen. We need to provide an - 8 bit number where in the 1st four bits represent the - analog lines and the next 4 bits represent positive/ - negative terminal on that input line. Notations to - represent the input lines and terminals resoectively - is as follows: + 8 bit number where the most significant nibble represent + the analog lines and the least significant nibble + represent positive/ negative terminal on that input + line. Notations to represent the input lines and + terminals resoectively is as follows: AIN0 = 0, AIN1 = 1 and so on till AIN7 = 7. XP = 0, XN = 1, YP = 2, YN = 3. + + Example: ti,wire-config = <0x71>; + => line AIN7, configuration XN - child "adc" ti,adc-channels: List of analog inputs available for ADC. AIN0 = 0, AIN1 = 1 and so on till AIN7 = 7.