| Message ID | 1698811270-76312-1-git-send-email-quic_ziqichen@quicinc.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | dt-bindings: ufs: qcom: Add msi-parent for UFS MCQ | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Wed, Nov 01, 2023 at 12:01:09PM +0800, Ziqi Chen wrote: > The Message Signaled Interrupt (MSI) has been used > by UFS driver since the MCQ be enabled. Hence in UFS > DT node, we need to give the msi-parent property that > point to the hardware entity that serves as the MSI > controller for this UFS controller. > > Signed-off-by: Ziqi Chen <quic_ziqichen@quicinc.com> > --- > Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > index 462ead5..d2f505a 100644 > --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > @@ -103,6 +103,8 @@ properties: > description: > GPIO connected to the RESET pin of the UFS memory device. > > + msi-parent: true > + This property is not Qcom specific. So this should be part of ufs-common.yaml. - Mani > required: > - compatible > - reg > @@ -318,5 +320,6 @@ examples: > <0 0>, > <0 0>; > qcom,ice = <&ice>; > + msi-parent = <&gic_its 0x60>; > }; > }; > -- > 2.7.4 >
On 11/1/2023 1:01 PM, Manivannan Sadhasivam wrote: > On Wed, Nov 01, 2023 at 12:01:09PM +0800, Ziqi Chen wrote: >> The Message Signaled Interrupt (MSI) has been used >> by UFS driver since the MCQ be enabled. Hence in UFS >> DT node, we need to give the msi-parent property that >> point to the hardware entity that serves as the MSI >> controller for this UFS controller. >> >> Signed-off-by: Ziqi Chen <quic_ziqichen@quicinc.com> >> --- >> Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >> index 462ead5..d2f505a 100644 >> --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >> +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >> @@ -103,6 +103,8 @@ properties: >> description: >> GPIO connected to the RESET pin of the UFS memory device. >> >> + msi-parent: true >> + > > This property is not Qcom specific. So this should be part of ufs-common.yaml. Make sense, thanks for review, I will update to ufs-common.yam. > > - Mani > >> required: >> - compatible >> - reg >> @@ -318,5 +320,6 @@ examples: >> <0 0>, >> <0 0>; >> qcom,ice = <&ice>; >> + msi-parent = <&gic_its 0x60>; >> }; >> }; >> -- >> 2.7.4 >> >
diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml index 462ead5..d2f505a 100644 --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml @@ -103,6 +103,8 @@ properties: description: GPIO connected to the RESET pin of the UFS memory device. + msi-parent: true + required: - compatible - reg @@ -318,5 +320,6 @@ examples: <0 0>, <0 0>; qcom,ice = <&ice>; + msi-parent = <&gic_its 0x60>; }; };
The Message Signaled Interrupt (MSI) has been used by UFS driver since the MCQ be enabled. Hence in UFS DT node, we need to give the msi-parent property that point to the hardware entity that serves as the MSI controller for this UFS controller. Signed-off-by: Ziqi Chen <quic_ziqichen@quicinc.com> --- Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 3 +++ 1 file changed, 3 insertions(+)