| Message ID | 1666588648-1047-1-git-send-email-jun.li@nxp.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [1/2] dt-bindings: usb: usb-nop-xceiv: add wakeup-source property | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success | |
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 24/10/2022 01:17, Li Jun wrote: > usb phy may be part of wakeup source, so add wakeup source property s/usb/USB/ "part of wakeup source" is actually not descriptive. What do you want to say here? > to keep its resource(e.g power domain) active to make usb remote space before ( s/e.g/e.g./ s/usb/USB/ > wakeup work. > > Signed-off-by: Li Jun <jun.li@nxp.com> > --- > Documentation/devicetree/bindings/usb/usb-nop-xceiv.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/usb-nop-xceiv.yaml b/Documentation/devicetree/bindings/usb/usb-nop-xceiv.yaml > index 2824c17285ee..7b71e32d1df0 100644 > --- a/Documentation/devicetree/bindings/usb/usb-nop-xceiv.yaml > +++ b/Documentation/devicetree/bindings/usb/usb-nop-xceiv.yaml > @@ -39,6 +39,11 @@ properties: > the VBus line. > $ref: /schemas/types.yaml#/definitions/phandle > > + wakeup-source: > + $ref: /schemas/types.yaml#/definitions/flag This shouldn't be needed, as it is a standard property. > + description: > + Specify if it's USB remote wakeup capable. Now you have to explain in the bindings what is "USB remote wakeup". Best regards, Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Tuesday, October 25, 2022 8:23 AM > To: Jun Li <jun.li@nxp.com>; gregkh@linuxfoundation.org; > robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org > Cc: balbi@kernel.org; linux-usb@vger.kernel.org; > devicetree@vger.kernel.org; Xu Yang <xu.yang_2@nxp.com> > Subject: Re: [PATCH 1/2] dt-bindings: usb: usb-nop-xceiv: add wakeup-source > property > > On 24/10/2022 01:17, Li Jun wrote: > > usb phy may be part of wakeup source, so add wakeup source property > > s/usb/USB/ > > "part of wakeup source" is actually not descriptive. What do you want to > say here? Will change to be "USB phy may be a system wakeup source". > > > to keep its resource(e.g power domain) active to make usb remote > > space before ( > s/e.g/e.g./ > s/usb/USB/ Okay. > > > wakeup work. > > > > Signed-off-by: Li Jun <jun.li@nxp.com> > > --- > > Documentation/devicetree/bindings/usb/usb-nop-xceiv.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/usb/usb-nop-xceiv.yaml > > b/Documentation/devicetree/bindings/usb/usb-nop-xceiv.yaml > > index 2824c17285ee..7b71e32d1df0 100644 > > --- a/Documentation/devicetree/bindings/usb/usb-nop-xceiv.yaml > > +++ b/Documentation/devicetree/bindings/usb/usb-nop-xceiv.yaml > > @@ -39,6 +39,11 @@ properties: > > the VBus line. > > $ref: /schemas/types.yaml#/definitions/phandle > > > > + wakeup-source: > > + $ref: /schemas/types.yaml#/definitions/flag > > This shouldn't be needed, as it is a standard property. Will remove. > > > + description: > > + Specify if it's USB remote wakeup capable. > > Now you have to explain in the bindings what is "USB remote wakeup". "USB remote wakeup" is a standard concept in USB world/spec, change the description like "if the USB phy can detect the remote wakeup signal while the system sleep" make sense to you? Thanks Li Jun > > Best regards, > Krzysztof
On 25/10/2022 06:43, Jun Li wrote: > >> -----Original Message----- >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Sent: Tuesday, October 25, 2022 8:23 AM >> To: Jun Li <jun.li@nxp.com>; gregkh@linuxfoundation.org; >> robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org >> Cc: balbi@kernel.org; linux-usb@vger.kernel.org; >> devicetree@vger.kernel.org; Xu Yang <xu.yang_2@nxp.com> >> Subject: Re: [PATCH 1/2] dt-bindings: usb: usb-nop-xceiv: add wakeup-source >> property >> >> On 24/10/2022 01:17, Li Jun wrote: >>> usb phy may be part of wakeup source, so add wakeup source property >> >> s/usb/USB/ >> >> "part of wakeup source" is actually not descriptive. What do you want to >> say here? > > Will change to be "USB phy may be a system wakeup source". > >> >>> to keep its resource(e.g power domain) active to make usb remote >> >> space before ( >> s/e.g/e.g./ >> s/usb/USB/ > > Okay. > >> >>> wakeup work. >>> >>> Signed-off-by: Li Jun <jun.li@nxp.com> >>> --- >>> Documentation/devicetree/bindings/usb/usb-nop-xceiv.yaml | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/usb/usb-nop-xceiv.yaml >>> b/Documentation/devicetree/bindings/usb/usb-nop-xceiv.yaml >>> index 2824c17285ee..7b71e32d1df0 100644 >>> --- a/Documentation/devicetree/bindings/usb/usb-nop-xceiv.yaml >>> +++ b/Documentation/devicetree/bindings/usb/usb-nop-xceiv.yaml >>> @@ -39,6 +39,11 @@ properties: >>> the VBus line. >>> $ref: /schemas/types.yaml#/definitions/phandle >>> >>> + wakeup-source: >>> + $ref: /schemas/types.yaml#/definitions/flag >> >> This shouldn't be needed, as it is a standard property. > > Will remove. > >> >>> + description: >>> + Specify if it's USB remote wakeup capable. >> >> Now you have to explain in the bindings what is "USB remote wakeup". > > "USB remote wakeup" is a standard concept in USB world/spec, change > the description like "if the USB phy can detect the remote wakeup > signal while the system sleep" make sense to you? If it is a standard concept, keep it. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/usb/usb-nop-xceiv.yaml b/Documentation/devicetree/bindings/usb/usb-nop-xceiv.yaml index 2824c17285ee..7b71e32d1df0 100644 --- a/Documentation/devicetree/bindings/usb/usb-nop-xceiv.yaml +++ b/Documentation/devicetree/bindings/usb/usb-nop-xceiv.yaml @@ -39,6 +39,11 @@ properties: the VBus line. $ref: /schemas/types.yaml#/definitions/phandle + wakeup-source: + $ref: /schemas/types.yaml#/definitions/flag + description: + Specify if it's USB remote wakeup capable. + required: - compatible - '#phy-cells'
usb phy may be part of wakeup source, so add wakeup source property to keep its resource(e.g power domain) active to make usb remote wakeup work. Signed-off-by: Li Jun <jun.li@nxp.com> --- Documentation/devicetree/bindings/usb/usb-nop-xceiv.yaml | 5 +++++ 1 file changed, 5 insertions(+)