diff mbox series

[RESEND,v3,1/3] dt-bindings: clocks: imx8mp: Add ID for usb suspend clock

Message ID 1663929905-10492-1-git-send-email-jun.li@nxp.com
State Not Applicable, archived
Headers show
Series [RESEND,v3,1/3] dt-bindings: clocks: imx8mp: Add ID for usb suspend clock | expand

Checks

Context Check Description
robh/checkpatch warning total: 0 errors, 1 warnings, 10 lines checked
robh/patch-applied success
robh/checkpatch warning total: 0 errors, 1 warnings, 10 lines checked
robh/patch-applied success

Commit Message

Jun Li Sept. 23, 2022, 10:45 a.m. UTC
usb suspend clock has a gate shared with usb_root_clk.

Fixes: 9c140d9926761 ("clk: imx: Add support for i.MX8MP clock driver")
Cc: stable@vger.kernel.org # v5.19+
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Tested-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Signed-off-by: Li Jun <jun.li@nxp.com>
---
 include/dt-bindings/clock/imx8mp-clock.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Stephen Boyd Sept. 30, 2022, 12:53 a.m. UTC | #1
Quoting Li Jun (2022-09-23 03:45:04)
> 32K usb suspend clock gate is shared with usb_root_clk.
> 
> Fixes: 9c140d9926761 ("clk: imx: Add support for i.MX8MP clock driver")
> Cc: stable@vger.kernel.org # v5.19+

Why is stable Cced? The commit text doesn't tell me what sort of
regression is being fixed. Please help!
Jun Li Sept. 30, 2022, 2:14 a.m. UTC | #2
Hi Stephen,

> -----Original Message-----
> From: Stephen Boyd <sboyd@kernel.org>
> Sent: Friday, September 30, 2022 8:54 AM
> To: Jun Li <jun.li@nxp.com>; abelvesa@kernel.org
> Cc: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org;
> shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de;
> festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com>;
> mturquette@baylibre.com; l.stach@pengutronix.de; Peng Fan
> <peng.fan@nxp.com>; alexander.stein@ew.tq-group.com;
> gregkh@linuxfoundation.org; devicetree@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; linux-clk@vger.kernel.org
> Subject: Re: [PATCH RESEND v3 2/3] clk: imx: imx8mp: add shared clk gate
> for usb suspend clk
> 
> Quoting Li Jun (2022-09-23 03:45:04)
> > 32K usb suspend clock gate is shared with usb_root_clk.
> >
> > Fixes: 9c140d9926761 ("clk: imx: Add support for i.MX8MP clock
> > driver")
> > Cc: stable@vger.kernel.org # v5.19+
> 
> Why is stable Cced? The commit text doesn't tell me what sort of regression
> is being fixed. Please help!

Sorry, I missed this again, Rob commented on this.
I will resend with commit text improved to explain this.

Thanks
Li Jun
diff mbox series

Patch

diff --git a/include/dt-bindings/clock/imx8mp-clock.h b/include/dt-bindings/clock/imx8mp-clock.h
index 9d5cc2ddde89..1417b7b1b7df 100644
--- a/include/dt-bindings/clock/imx8mp-clock.h
+++ b/include/dt-bindings/clock/imx8mp-clock.h
@@ -324,8 +324,9 @@ 
 #define IMX8MP_CLK_CLKOUT2_SEL			317
 #define IMX8MP_CLK_CLKOUT2_DIV			318
 #define IMX8MP_CLK_CLKOUT2			319
+#define IMX8MP_CLK_USB_SUSP			320
 
-#define IMX8MP_CLK_END				320
+#define IMX8MP_CLK_END				321
 
 #define IMX8MP_CLK_AUDIOMIX_SAI1_IPG		0
 #define IMX8MP_CLK_AUDIOMIX_SAI1_MCLK1		1