| Message ID | 1646647704-2331-2-git-send-email-u0084500@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add Richtek RT5190A PMIC support | expand |
| Context | Check | Description |
|---|---|---|
| robh/patch-applied | success | |
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 138 lines checked |
| robh/dtbs-check | success | |
| robh/dt-meta-schema | fail | build log |
On 07/03/2022 11:08, cy_huang wrote: > From: ChiYuan Huang <cy_huang@richtek.com> > > Add bindings for Richtek RT5190A PMIC. > > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com> > --- > .../regulator/richtek,rt5190a-regulator.yaml | 138 +++++++++++++++++++++ > 1 file changed, 138 insertions(+) > create mode 100644 Documentation/devicetree/bindings/regulator/richtek,rt5190a-regulator.yaml > > diff --git a/Documentation/devicetree/bindings/regulator/richtek,rt5190a-regulator.yaml b/Documentation/devicetree/bindings/regulator/richtek,rt5190a-regulator.yaml > new file mode 100644 > index 00000000..b9f5836 > --- /dev/null > +++ b/Documentation/devicetree/bindings/regulator/richtek,rt5190a-regulator.yaml > @@ -0,0 +1,138 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/regulator/richtek,rt5190a-regulator.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Richtek RT5190A PMIC Regulator > + > +maintainers: > + - ChiYuan Huang <cy_huang@richtek.com> > + > +description: | > + The RT5190A integrates 1 channel buck controller, 3 channels high efficiency > + synchronous buck converters, 1 LDO, I2C control interface and peripherial > + logical control. > + > + It also supports mute AC OFF depop sound and quick setting storage while > + input power is removed. > + > +properties: > + compatible: > + enum: > + - richtek,rt5190a > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + vin2-supply: > + description: phandle to buck2 input voltage. > + > + vin3-supply: > + description: phandle to buck3 input voltage. > + > + vin4-supply: > + description: phandle to buck4 input voltage. > + > + vinldo-supply: > + description: phandle to ldo input voltage > + > + richtek,buck1-fixed-microvolt: > + description: buck1 fixed voltage that depends on the external resistor. > + $ref: "/schemas/types.yaml#/definitions/uint32" You should use standard bindings for it. > + > + richtek,buck4-fixed-microvolt: > + description: buck4 fixed voltage that depends on the external resistor. > + $ref: "/schemas/types.yaml#/definitions/uint32" > + > + richtek,ldo-fixed-microvolt: > + description: ldo fixed voltage that depends on the external resistor. > + $ref: "/schemas/types.yaml#/definitions/uint32" > + > + richtek,mute-enable: > + description: this can be used to enable mute function. Please describe what is "mute" function". Your description copied property name, so it is not useful. > + type: boolean > + > + regulators: > + type: object > + > + patternProperties: > + "^buck[1-4]$|^ldo$": > + type: object > + $ref: regulator.yaml# > + description: | > + regulator description for buck[1-4] and ldo. > + > + properties: > + richtek,latchup-enable: > + type: boolean > + description: | > + If specified, undervolt protection mode changes from the default > + hiccup to latchup. > + > + unevaluatedProperties: false > + > + additionalProperties: false > + > +required: > + - compatible > + - reg > + - richtek,buck1-fixed-microvolt > + - richtek,buck4-fixed-microvolt > + - richtek,ldo-fixed-microvolt > + - regulators > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + rt5190a@64 { Generic node name, so "pmic". > + compatible = "richtek,rt5190a"; > + reg = <0x64>; > + interrupts-extended = <&gpio26 0 IRQ_TYPE_LEVEL_LOW>; > + vin2-supply = <&rt5190_buck1>; > + vin3-supply = <&rt5190_buck1>; > + vin4-supply = <&rt5190_buck1>; > + richtek,buck1-fixed-microvolt = <5090000>; > + richtek,buck4-fixed-microvolt = <850000>; > + richtek,ldo-fixed-microvolt = <1200000>; > + > + regulators { > + rt5190_buck1: buck1 { > + regulator-name = "rt5190a-buck1"; > + regulator-allowed-modes = <0 1>; Please describe these in header file in bindings and mention as one of regulator properties with description and enum. Best regards, Krzysztof
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> 於 2022年3月7日 週一 下午7:14寫道： > > On 07/03/2022 11:08, cy_huang wrote: > > From: ChiYuan Huang <cy_huang@richtek.com> > > > > Add bindings for Richtek RT5190A PMIC. > > > > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com> > > --- > > .../regulator/richtek,rt5190a-regulator.yaml | 138 +++++++++++++++++++++ > > 1 file changed, 138 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/regulator/richtek,rt5190a-regulator.yaml > > > > diff --git a/Documentation/devicetree/bindings/regulator/richtek,rt5190a-regulator.yaml b/Documentation/devicetree/bindings/regulator/richtek,rt5190a-regulator.yaml > > new file mode 100644 > > index 00000000..b9f5836 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/regulator/richtek,rt5190a-regulator.yaml > > @@ -0,0 +1,138 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/regulator/richtek,rt5190a-regulator.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Richtek RT5190A PMIC Regulator > > + > > +maintainers: > > + - ChiYuan Huang <cy_huang@richtek.com> > > + > > +description: | > > + The RT5190A integrates 1 channel buck controller, 3 channels high efficiency > > + synchronous buck converters, 1 LDO, I2C control interface and peripherial > > + logical control. > > + > > + It also supports mute AC OFF depop sound and quick setting storage while > > + input power is removed. > > + > > +properties: > > + compatible: > > + enum: > > + - richtek,rt5190a > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + vin2-supply: > > + description: phandle to buck2 input voltage. > > + > > + vin3-supply: > > + description: phandle to buck3 input voltage. > > + > > + vin4-supply: > > + description: phandle to buck4 input voltage. > > + > > + vinldo-supply: > > + description: phandle to ldo input voltage > > + > > + richtek,buck1-fixed-microvolt: > > + description: buck1 fixed voltage that depends on the external resistor. > > + $ref: "/schemas/types.yaml#/definitions/uint32" > > You should use standard bindings for it. > Sorry, I didn't get the point for the meaning 'standard binding'. Do you mean to change 'richtek,buck1-fixed-microvolt' or 'uint32' definition? This voltage depends on the external resistor selection. It's 'fixed' by the application. > > + > > + richtek,buck4-fixed-microvolt: > > + description: buck4 fixed voltage that depends on the external resistor. > > + $ref: "/schemas/types.yaml#/definitions/uint32" > > + > > + richtek,ldo-fixed-microvolt: > > + description: ldo fixed voltage that depends on the external resistor. > > + $ref: "/schemas/types.yaml#/definitions/uint32" > > + > > + richtek,mute-enable: > > + description: this can be used to enable mute function. > > Please describe what is "mute" function". Your description copied > property name, so it is not useful. > OK, I'll describe more detailed. > > + type: boolean > > + > > + regulators: > > + type: object > > + > > + patternProperties: > > + "^buck[1-4]$|^ldo$": > > + type: object > > + $ref: regulator.yaml# > > + description: | > > + regulator description for buck[1-4] and ldo. > > + > > + properties: > > + richtek,latchup-enable: > > + type: boolean > > + description: | > > + If specified, undervolt protection mode changes from the default > > + hiccup to latchup. > > + > > + unevaluatedProperties: false > > + > > + additionalProperties: false > > + > > +required: > > + - compatible > > + - reg > > + - richtek,buck1-fixed-microvolt > > + - richtek,buck4-fixed-microvolt > > + - richtek,ldo-fixed-microvolt > > + - regulators > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/interrupt-controller/irq.h> > > + > > + i2c { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + rt5190a@64 { > > Generic node name, so "pmic". > Ack in next. > > + compatible = "richtek,rt5190a"; > > + reg = <0x64>; > > + interrupts-extended = <&gpio26 0 IRQ_TYPE_LEVEL_LOW>; > > + vin2-supply = <&rt5190_buck1>; > > + vin3-supply = <&rt5190_buck1>; > > + vin4-supply = <&rt5190_buck1>; > > + richtek,buck1-fixed-microvolt = <5090000>; > > + richtek,buck4-fixed-microvolt = <850000>; > > + richtek,ldo-fixed-microvolt = <1200000>; > > + > > + regulators { > > + rt5190_buck1: buck1 { > > + regulator-name = "rt5190a-buck1"; > > + regulator-allowed-modes = <0 1>; > > Please describe these in header file in bindings and mention as one of > regulator properties with description and enum. > OK, will add one dt-binding header file for the constant and mentioned as one regulator property. Ack in next. > > > Best regards, > Krzysztof
On 07/03/2022 14:21, ChiYuan Huang wrote: > Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> 於 2022年3月7日 週一 下午7:14寫道： >> >> On 07/03/2022 11:08, cy_huang wrote: >>> From: ChiYuan Huang <cy_huang@richtek.com> >>> >>> Add bindings for Richtek RT5190A PMIC. >>> >>> Signed-off-by: ChiYuan Huang <cy_huang@richtek.com> >>> --- >>> .../regulator/richtek,rt5190a-regulator.yaml | 138 +++++++++++++++++++++ >>> 1 file changed, 138 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/regulator/richtek,rt5190a-regulator.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/regulator/richtek,rt5190a-regulator.yaml b/Documentation/devicetree/bindings/regulator/richtek,rt5190a-regulator.yaml >>> new file mode 100644 >>> index 00000000..b9f5836 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/regulator/richtek,rt5190a-regulator.yaml >>> @@ -0,0 +1,138 @@ >>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/regulator/richtek,rt5190a-regulator.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Richtek RT5190A PMIC Regulator >>> + >>> +maintainers: >>> + - ChiYuan Huang <cy_huang@richtek.com> >>> + >>> +description: | >>> + The RT5190A integrates 1 channel buck controller, 3 channels high efficiency >>> + synchronous buck converters, 1 LDO, I2C control interface and peripherial >>> + logical control. >>> + >>> + It also supports mute AC OFF depop sound and quick setting storage while >>> + input power is removed. >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - richtek,rt5190a >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> + interrupts: >>> + maxItems: 1 >>> + >>> + vin2-supply: >>> + description: phandle to buck2 input voltage. >>> + >>> + vin3-supply: >>> + description: phandle to buck3 input voltage. >>> + >>> + vin4-supply: >>> + description: phandle to buck4 input voltage. >>> + >>> + vinldo-supply: >>> + description: phandle to ldo input voltage >>> + >>> + richtek,buck1-fixed-microvolt: >>> + description: buck1 fixed voltage that depends on the external resistor. >>> + $ref: "/schemas/types.yaml#/definitions/uint32" >> >> You should use standard bindings for it. >> > Sorry, I didn't get the point for the meaning 'standard binding'. > Do you mean to change 'richtek,buck1-fixed-microvolt' or 'uint32' definition? > This voltage depends on the external resistor selection. It's 'fixed' > by the application. I meant that you should not have dedicated binding to set regulator voltage, but use regulator-min/max-microvolt instead, within one regulator node. Just set min/max to same level and handle it in the driver. See for example: drivers/regulator/scmi-regulator.c Best regards, Krzysztof
HI, Krzysztof: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> 於 2022年3月7日 週一 下午9:27寫道： > > On 07/03/2022 14:21, ChiYuan Huang wrote: > > Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> 於 2022年3月7日 週一 下午7:14寫道： > >> > >> On 07/03/2022 11:08, cy_huang wrote: > >>> From: ChiYuan Huang <cy_huang@richtek.com> > >>> > >>> Add bindings for Richtek RT5190A PMIC. > >>> > >>> Signed-off-by: ChiYuan Huang <cy_huang@richtek.com> > >>> --- > >>> .../regulator/richtek,rt5190a-regulator.yaml | 138 +++++++++++++++++++++ > >>> 1 file changed, 138 insertions(+) > >>> create mode 100644 Documentation/devicetree/bindings/regulator/richtek,rt5190a-regulator.yaml > >>> > >>> diff --git a/Documentation/devicetree/bindings/regulator/richtek,rt5190a-regulator.yaml b/Documentation/devicetree/bindings/regulator/richtek,rt5190a-regulator.yaml > >>> new file mode 100644 > >>> index 00000000..b9f5836 > >>> --- /dev/null > >>> +++ b/Documentation/devicetree/bindings/regulator/richtek,rt5190a-regulator.yaml > >>> @@ -0,0 +1,138 @@ > >>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > >>> +%YAML 1.2 > >>> +--- > >>> +$id: http://devicetree.org/schemas/regulator/richtek,rt5190a-regulator.yaml# > >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >>> + > >>> +title: Richtek RT5190A PMIC Regulator > >>> + > >>> +maintainers: > >>> + - ChiYuan Huang <cy_huang@richtek.com> > >>> + > >>> +description: | > >>> + The RT5190A integrates 1 channel buck controller, 3 channels high efficiency > >>> + synchronous buck converters, 1 LDO, I2C control interface and peripherial > >>> + logical control. > >>> + > >>> + It also supports mute AC OFF depop sound and quick setting storage while > >>> + input power is removed. > >>> + > >>> +properties: > >>> + compatible: > >>> + enum: > >>> + - richtek,rt5190a > >>> + > >>> + reg: > >>> + maxItems: 1 > >>> + > >>> + interrupts: > >>> + maxItems: 1 > >>> + > >>> + vin2-supply: > >>> + description: phandle to buck2 input voltage. > >>> + > >>> + vin3-supply: > >>> + description: phandle to buck3 input voltage. > >>> + > >>> + vin4-supply: > >>> + description: phandle to buck4 input voltage. > >>> + > >>> + vinldo-supply: > >>> + description: phandle to ldo input voltage > >>> + > >>> + richtek,buck1-fixed-microvolt: > >>> + description: buck1 fixed voltage that depends on the external resistor. > >>> + $ref: "/schemas/types.yaml#/definitions/uint32" > >> > >> You should use standard bindings for it. > >> > > Sorry, I didn't get the point for the meaning 'standard binding'. > > Do you mean to change 'richtek,buck1-fixed-microvolt' or 'uint32' definition? > > This voltage depends on the external resistor selection. It's 'fixed' > > by the application. > > I meant that you should not have dedicated binding to set regulator > voltage, but use regulator-min/max-microvolt instead, within one > regulator node. Just set min/max to same level and handle it in the > driver. See for example: > drivers/regulator/scmi-regulator.c > As I know, regulator-min/max-microvolt is used as the usage constraint. But out buck1/buck4/ldo vout is defined by Vout = VFb * (1 + R1/R2) where R1/R2 is chosen by the circuit design. It seems not similar with the scmi-regulator. Do you really suggest to use regulator-min/max-microvolt???? > > Best regards, > Krzysztof
On 07/03/2022 15:21, ChiYuan Huang wrote: > HI, Krzysztof: > > Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> 於 2022年3月7日 週一 下午9:27寫道： >> >> On 07/03/2022 14:21, ChiYuan Huang wrote: >>> Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> 於 2022年3月7日 週一 下午7:14寫道： >>>> >>>> On 07/03/2022 11:08, cy_huang wrote: >>>>> From: ChiYuan Huang <cy_huang@richtek.com> >>>>> >>>>> Add bindings for Richtek RT5190A PMIC. >>>>> >>>>> Signed-off-by: ChiYuan Huang <cy_huang@richtek.com> >>>>> --- >>>>> .../regulator/richtek,rt5190a-regulator.yaml | 138 +++++++++++++++++++++ >>>>> 1 file changed, 138 insertions(+) >>>>> create mode 100644 Documentation/devicetree/bindings/regulator/richtek,rt5190a-regulator.yaml >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/regulator/richtek,rt5190a-regulator.yaml b/Documentation/devicetree/bindings/regulator/richtek,rt5190a-regulator.yaml >>>>> new file mode 100644 >>>>> index 00000000..b9f5836 >>>>> --- /dev/null >>>>> +++ b/Documentation/devicetree/bindings/regulator/richtek,rt5190a-regulator.yaml >>>>> @@ -0,0 +1,138 @@ >>>>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >>>>> +%YAML 1.2 >>>>> +--- >>>>> +$id: http://devicetree.org/schemas/regulator/richtek,rt5190a-regulator.yaml# >>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>>> + >>>>> +title: Richtek RT5190A PMIC Regulator >>>>> + >>>>> +maintainers: >>>>> + - ChiYuan Huang <cy_huang@richtek.com> >>>>> + >>>>> +description: | >>>>> + The RT5190A integrates 1 channel buck controller, 3 channels high efficiency >>>>> + synchronous buck converters, 1 LDO, I2C control interface and peripherial >>>>> + logical control. >>>>> + >>>>> + It also supports mute AC OFF depop sound and quick setting storage while >>>>> + input power is removed. >>>>> + >>>>> +properties: >>>>> + compatible: >>>>> + enum: >>>>> + - richtek,rt5190a >>>>> + >>>>> + reg: >>>>> + maxItems: 1 >>>>> + >>>>> + interrupts: >>>>> + maxItems: 1 >>>>> + >>>>> + vin2-supply: >>>>> + description: phandle to buck2 input voltage. >>>>> + >>>>> + vin3-supply: >>>>> + description: phandle to buck3 input voltage. >>>>> + >>>>> + vin4-supply: >>>>> + description: phandle to buck4 input voltage. >>>>> + >>>>> + vinldo-supply: >>>>> + description: phandle to ldo input voltage >>>>> + >>>>> + richtek,buck1-fixed-microvolt: >>>>> + description: buck1 fixed voltage that depends on the external resistor. >>>>> + $ref: "/schemas/types.yaml#/definitions/uint32" >>>> >>>> You should use standard bindings for it. >>>> >>> Sorry, I didn't get the point for the meaning 'standard binding'. >>> Do you mean to change 'richtek,buck1-fixed-microvolt' or 'uint32' definition? >>> This voltage depends on the external resistor selection. It's 'fixed' >>> by the application. >> >> I meant that you should not have dedicated binding to set regulator >> voltage, but use regulator-min/max-microvolt instead, within one >> regulator node. Just set min/max to same level and handle it in the >> driver. See for example: >> drivers/regulator/scmi-regulator.c >> > As I know, regulator-min/max-microvolt is used as the usage constraint. True, bindings mention the consumers, but I don't think this is treated literally. > > But out buck1/buck4/ldo vout is defined by > Vout = VFb * (1 + R1/R2) where R1/R2 is chosen by the circuit design. > > It seems not similar with the scmi-regulator. > > Do you really suggest to use regulator-min/max-microvolt???? The same as existing fixed-regulator. Why this regulator should be different than fixed-regulator? Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/regulator/richtek,rt5190a-regulator.yaml b/Documentation/devicetree/bindings/regulator/richtek,rt5190a-regulator.yaml new file mode 100644 index 00000000..b9f5836 --- /dev/null +++ b/Documentation/devicetree/bindings/regulator/richtek,rt5190a-regulator.yaml @@ -0,0 +1,138 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/regulator/richtek,rt5190a-regulator.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Richtek RT5190A PMIC Regulator + +maintainers: + - ChiYuan Huang <cy_huang@richtek.com> + +description: | + The RT5190A integrates 1 channel buck controller, 3 channels high efficiency + synchronous buck converters, 1 LDO, I2C control interface and peripherial + logical control. + + It also supports mute AC OFF depop sound and quick setting storage while + input power is removed. + +properties: + compatible: + enum: + - richtek,rt5190a + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + vin2-supply: + description: phandle to buck2 input voltage. + + vin3-supply: + description: phandle to buck3 input voltage. + + vin4-supply: + description: phandle to buck4 input voltage. + + vinldo-supply: + description: phandle to ldo input voltage + + richtek,buck1-fixed-microvolt: + description: buck1 fixed voltage that depends on the external resistor. + $ref: "/schemas/types.yaml#/definitions/uint32" + + richtek,buck4-fixed-microvolt: + description: buck4 fixed voltage that depends on the external resistor. + $ref: "/schemas/types.yaml#/definitions/uint32" + + richtek,ldo-fixed-microvolt: + description: ldo fixed voltage that depends on the external resistor. + $ref: "/schemas/types.yaml#/definitions/uint32" + + richtek,mute-enable: + description: this can be used to enable mute function. + type: boolean + + regulators: + type: object + + patternProperties: + "^buck[1-4]$|^ldo$": + type: object + $ref: regulator.yaml# + description: | + regulator description for buck[1-4] and ldo. + + properties: + richtek,latchup-enable: + type: boolean + description: | + If specified, undervolt protection mode changes from the default + hiccup to latchup. + + unevaluatedProperties: false + + additionalProperties: false + +required: + - compatible + - reg + - richtek,buck1-fixed-microvolt + - richtek,buck4-fixed-microvolt + - richtek,ldo-fixed-microvolt + - regulators + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + + i2c { + #address-cells = <1>; + #size-cells = <0>; + + rt5190a@64 { + compatible = "richtek,rt5190a"; + reg = <0x64>; + interrupts-extended = <&gpio26 0 IRQ_TYPE_LEVEL_LOW>; + vin2-supply = <&rt5190_buck1>; + vin3-supply = <&rt5190_buck1>; + vin4-supply = <&rt5190_buck1>; + richtek,buck1-fixed-microvolt = <5090000>; + richtek,buck4-fixed-microvolt = <850000>; + richtek,ldo-fixed-microvolt = <1200000>; + + regulators { + rt5190_buck1: buck1 { + regulator-name = "rt5190a-buck1"; + regulator-allowed-modes = <0 1>; + regulator-boot-on; + }; + buck2 { + regulator-name = "rt5190a-buck2"; + regulator-min-microvolt = <600000>; + regulator-max-microvolt = <1400000>; + regulator-boot-on; + }; + buck3 { + regulator-name = "rt5190a-buck3"; + regulator-min-microvolt = <600000>; + regulator-max-microvolt = <1400000>; + regulator-boot-on; + }; + buck4 { + regulator-name = "rt5190a-buck4"; + regulator-allowed-modes = <0 1>; + regulator-boot-on; + }; + ldo { + regulator-name = "rt5190a-ldo"; + regulator-boot-on; + }; + }; + }; + };