diff mbox series

[1/4] dt-bindings: phy: phy-imx8-pcie: Add binding for the pad modes of imx8 pcie phy

Message ID 1631845863-24249-2-git-send-email-hongxing.zhu@nxp.com
State Changes Requested, archived
Headers show
Series add the imx8 pcie phy driver support | expand

Checks

Context Check Description
robh/checkpatch success

Commit Message

Richard Zhu Sept. 17, 2021, 2:31 a.m. UTC 
Add binding for reference clock PAD modes of the i.MX8 PCIe PHY.

Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
---
 include/dt-bindings/phy/phy-imx8-pcie.h | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 include/dt-bindings/phy/phy-imx8-pcie.h

Comments

Rob Herring (Arm) Sept. 22, 2021, 7:25 p.m. UTC | #1 
On Fri, Sep 17, 2021 at 10:31:00AM +0800, Richard Zhu wrote:
> Add binding for reference clock PAD modes of the i.MX8 PCIe PHY.
> 
> Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> ---
>  include/dt-bindings/phy/phy-imx8-pcie.h | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>  create mode 100644 include/dt-bindings/phy/phy-imx8-pcie.h
> 
> diff --git a/include/dt-bindings/phy/phy-imx8-pcie.h b/include/dt-bindings/phy/phy-imx8-pcie.h
> new file mode 100644
> index 000000000000..fe198a0cc12c
> --- /dev/null
> +++ b/include/dt-bindings/phy/phy-imx8-pcie.h
> @@ -0,0 +1,14 @@
> +/* SPDX-License-Identifier: GPL-2.0 */

Perhaps this should match the dts files license...

> +/*
> + * This header provides constants for i.MX8 PCIe.
> + */
> +
> +#ifndef _DT_BINDINGS_IMX8_PCIE_H
> +#define _DT_BINDINGS_IMX8_PCIE_H
> +
> +/* Reference clock PAD mode */
> +#define IMX8_PCIE_REFCLK_PAD_NO_USED	0
> +#define IMX8_PCIE_REFCLK_PAD_INPUT	1
> +#define IMX8_PCIE_REFCLK_PAD_OUTPUT	2
> +
> +#endif /* _DT_BINDINGS_IMX8_PCIE_H */
> -- 
> 2.25.1
> 
>
Richard Zhu Sept. 23, 2021, 5:56 a.m. UTC | #2 
> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Thursday, September 23, 2021 3:26 AM
> To: Richard Zhu <hongxing.zhu@nxp.com>
> Cc: l.stach@pengutronix.de; kishon@ti.com; vkoul@kernel.org;
> galak@kernel.crashing.org; shawnguo@kernel.org;
> linux-phy@lists.infradead.org; devicetree@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> kernel@pengutronix.de; dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH 1/4] dt-bindings: phy: phy-imx8-pcie: Add binding for the
> pad modes of imx8 pcie phy
> 
> On Fri, Sep 17, 2021 at 10:31:00AM +0800, Richard Zhu wrote:
> > Add binding for reference clock PAD modes of the i.MX8 PCIe PHY.
> >
> > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> > ---
> >  include/dt-bindings/phy/phy-imx8-pcie.h | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >  create mode 100644 include/dt-bindings/phy/phy-imx8-pcie.h
> >
> > diff --git a/include/dt-bindings/phy/phy-imx8-pcie.h
> b/include/dt-bindings/phy/phy-imx8-pcie.h
> > new file mode 100644
> > index 000000000000..fe198a0cc12c
> > --- /dev/null
> > +++ b/include/dt-bindings/phy/phy-imx8-pcie.h
> > @@ -0,0 +1,14 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> 
> Perhaps this should match the dts files license...
> 
Hi Rob: 
What's the means of the "dts files license"?
I'm not clear understand that.
I found that there are almost similar "/* SPDX-License-Identifier: GPL-2.0 */" license contained in the files of the /include/dt-bindings/phy folder.

Best Regards
Richard Zhu
> > +/*
> > + * This header provides constants for i.MX8 PCIe.
> > + */
> > +
> > +#ifndef _DT_BINDINGS_IMX8_PCIE_H
> > +#define _DT_BINDINGS_IMX8_PCIE_H
> > +
> > +/* Reference clock PAD mode */
> > +#define IMX8_PCIE_REFCLK_PAD_NO_USED	0
> > +#define IMX8_PCIE_REFCLK_PAD_INPUT	1
> > +#define IMX8_PCIE_REFCLK_PAD_OUTPUT	2
> > +
> > +#endif /* _DT_BINDINGS_IMX8_PCIE_H */
> > --
> > 2.25.1
> >
> >
Rob Herring (Arm) Sept. 23, 2021, 2:43 p.m. UTC | #3 
On Thu, Sep 23, 2021 at 12:56 AM Richard Zhu <hongxing.zhu@nxp.com> wrote:
>
>
> > -----Original Message-----
> > From: Rob Herring <robh@kernel.org>
> > Sent: Thursday, September 23, 2021 3:26 AM
> > To: Richard Zhu <hongxing.zhu@nxp.com>
> > Cc: l.stach@pengutronix.de; kishon@ti.com; vkoul@kernel.org;
> > galak@kernel.crashing.org; shawnguo@kernel.org;
> > linux-phy@lists.infradead.org; devicetree@vger.kernel.org;
> > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> > kernel@pengutronix.de; dl-linux-imx <linux-imx@nxp.com>
> > Subject: Re: [PATCH 1/4] dt-bindings: phy: phy-imx8-pcie: Add binding for the
> > pad modes of imx8 pcie phy
> >
> > On Fri, Sep 17, 2021 at 10:31:00AM +0800, Richard Zhu wrote:
> > > Add binding for reference clock PAD modes of the i.MX8 PCIe PHY.
> > >
> > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> > > ---
> > >  include/dt-bindings/phy/phy-imx8-pcie.h | 14 ++++++++++++++
> > >  1 file changed, 14 insertions(+)
> > >  create mode 100644 include/dt-bindings/phy/phy-imx8-pcie.h
> > >
> > > diff --git a/include/dt-bindings/phy/phy-imx8-pcie.h
> > b/include/dt-bindings/phy/phy-imx8-pcie.h
> > > new file mode 100644
> > > index 000000000000..fe198a0cc12c
> > > --- /dev/null
> > > +++ b/include/dt-bindings/phy/phy-imx8-pcie.h
> > > @@ -0,0 +1,14 @@
> > > +/* SPDX-License-Identifier: GPL-2.0 */
> >
> > Perhaps this should match the dts files license...
> >
> Hi Rob:
> What's the means of the "dts files license"?

You include this into .dts files and those are dual licensed. The
licenses should match (or be compatible).

> I'm not clear understand that.
> I found that there are almost similar "/* SPDX-License-Identifier: GPL-2.0 */" license contained in the files of the /include/dt-bindings/phy folder.

Yes, licenses are a mess. But what other files in
include/dt-bindings/phy have don't matter. Where you use this file is
what matters.

Rob
Richard Zhu Sept. 24, 2021, 2:08 a.m. UTC | #4 
> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Thursday, September 23, 2021 10:44 PM
> To: Richard Zhu <hongxing.zhu@nxp.com>
> Cc: l.stach@pengutronix.de; kishon@ti.com; vkoul@kernel.org;
> galak@kernel.crashing.org; shawnguo@kernel.org;
> linux-phy@lists.infradead.org; devicetree@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> kernel@pengutronix.de; dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH 1/4] dt-bindings: phy: phy-imx8-pcie: Add binding for the
> pad modes of imx8 pcie phy
> 
> On Thu, Sep 23, 2021 at 12:56 AM Richard Zhu <hongxing.zhu@nxp.com>
> wrote:
> >
> >
> > > -----Original Message-----
> > > From: Rob Herring <robh@kernel.org>
> > > Sent: Thursday, September 23, 2021 3:26 AM
> > > To: Richard Zhu <hongxing.zhu@nxp.com>
> > > Cc: l.stach@pengutronix.de; kishon@ti.com; vkoul@kernel.org;
> > > galak@kernel.crashing.org; shawnguo@kernel.org;
> > > linux-phy@lists.infradead.org; devicetree@vger.kernel.org;
> > > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> > > kernel@pengutronix.de; dl-linux-imx <linux-imx@nxp.com>
> > > Subject: Re: [PATCH 1/4] dt-bindings: phy: phy-imx8-pcie: Add
> > > binding for the pad modes of imx8 pcie phy
> > >
> > > On Fri, Sep 17, 2021 at 10:31:00AM +0800, Richard Zhu wrote:
> > > > Add binding for reference clock PAD modes of the i.MX8 PCIe PHY.
> > > >
> > > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> > > > ---
> > > >  include/dt-bindings/phy/phy-imx8-pcie.h | 14 ++++++++++++++
> > > >  1 file changed, 14 insertions(+)
> > > >  create mode 100644 include/dt-bindings/phy/phy-imx8-pcie.h
> > > >
> > > > diff --git a/include/dt-bindings/phy/phy-imx8-pcie.h
> > > b/include/dt-bindings/phy/phy-imx8-pcie.h
> > > > new file mode 100644
> > > > index 000000000000..fe198a0cc12c
> > > > --- /dev/null
> > > > +++ b/include/dt-bindings/phy/phy-imx8-pcie.h
> > > > @@ -0,0 +1,14 @@
> > > > +/* SPDX-License-Identifier: GPL-2.0 */
> > >
> > > Perhaps this should match the dts files license...
> > >
> > Hi Rob:
> > What's the means of the "dts files license"?
> 
> You include this into .dts files and those are dual licensed. The licenses should
> match (or be compatible).
> 
[Richard Zhu] Thanks a lot. I'm clear now.
Would change the license to "SPDX-License-Identifier: GPL-2.0+" to make it compatible later.

Best Regards
Richard Zhu
> > I'm not clear understand that.
> > I found that there are almost similar "/* SPDX-License-Identifier: GPL-2.0
> */" license contained in the files of the /include/dt-bindings/phy folder.
> 
> Yes, licenses are a mess. But what other files in include/dt-bindings/phy have
> don't matter. Where you use this file is what matters.
> 
> Rob
diff mbox series

Patch

diff --git a/include/dt-bindings/phy/phy-imx8-pcie.h b/include/dt-bindings/phy/phy-imx8-pcie.h
new file mode 100644
index 000000000000..fe198a0cc12c
--- /dev/null
+++ b/include/dt-bindings/phy/phy-imx8-pcie.h
@@ -0,0 +1,14 @@ 
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * This header provides constants for i.MX8 PCIe.
+ */
+
+#ifndef _DT_BINDINGS_IMX8_PCIE_H
+#define _DT_BINDINGS_IMX8_PCIE_H
+
+/* Reference clock PAD mode */
+#define IMX8_PCIE_REFCLK_PAD_NO_USED	0
+#define IMX8_PCIE_REFCLK_PAD_INPUT	1
+#define IMX8_PCIE_REFCLK_PAD_OUTPUT	2
+
+#endif /* _DT_BINDINGS_IMX8_PCIE_H */